Re: [Buildroot] [PATCH 1/7] board/olimex/a20_olinuxino/genimage.cfg: fix build failure due to wrong offset value suffix

From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: Luca Ceresoli <luca@lucaceresoli.net>, buildroot@buildroot.org
Cc: "Yann E . MORIN" <yann.morin.1998@free.fr>,
	"Michael Walle" <michael@walle.cc>,
	"Jagan Teki" <jagan@amarulasolutions.com>,
	"Michał Łyszczek" <michal.lyszczek@bofc.pl>,
	"Heiko Thiery" <heiko.thiery@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/7] board/olimex/a20_olinuxino/genimage.cfg: fix build failure due to wrong offset value suffix
Date: Tue, 9 Nov 2021 10:16:59 +0100	[thread overview]
Message-ID: <b880f6ca-6a19-f7d7-dc31-4368e55160fa@benettiengineering.com> (raw)
In-Reply-To: <312c89ac-4ae6-97e6-2c77-cb1a5e5e441d@lucaceresoli.net>

Hi Luca,

On 11/9/21 10:01 AM, Luca Ceresoli wrote:
> Hi Giulio.
> 
> On 09/11/21 00:05, Giulio Benetti wrote:
>> With commit[1] I've introduced a bug:
>               ^^^
> Which commit? :)

I've forgotten, thank you for pointing, I've just reworded for v2 series.

This is the commit:
https://gitlab.com/buildroot.org/buildroot/-/commit/43bfa1cf1046b0e44e87a02bc5a358bf1de5bfdd

>> offset = 8KB(not valid for genimage)
>> and this prevents genimage to work, so let's substitute 8KB with 8K.
> 
> I wanted to test this patch, but the build succeeds on current master.
> How do you detect the wrong behaviour?

I've supposed genimage parser was stronger but I've just found as you've 
found that it builds even if it shouldn't. Genimage only checks the 
first letter of suffix, so if you try to modify that offset to:
offset = 8KDEADBEEF
it will build with offset at 8K.

So I reword by adding commit URL and changing from "fix build 
failure..." to "offset value must be...".

Thank you for checking!
Best regards
-- 
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot