From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1166C49EA5 for ; Thu, 24 Jun 2021 10:36:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FF5F613F0 for ; Thu, 24 Jun 2021 10:36:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232194AbhFXKid (ORCPT ); Thu, 24 Jun 2021 06:38:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232191AbhFXKic (ORCPT ); Thu, 24 Jun 2021 06:38:32 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B8ECC061574 for ; Thu, 24 Jun 2021 03:36:13 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwMiK-0007jE-Cs; Thu, 24 Jun 2021 12:36:04 +0200 Message-ID: Subject: Re: [EXT] regression due to soc_device_match not handling defer (Was: [PATCH v4 4/4] soc: imx8m: change to use platform driver) From: Lucas Stach To: Peng Fan , Dominique MARTINET , "Alice Guo (OSS)" Cc: Shawn Guo , Krzysztof Kozlowski , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Date: Thu, 24 Jun 2021 12:36:02 +0200 In-Reply-To: References: <20201120101112.31819-4-alice.guo@nxp.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.1 (3.40.1-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, Am Donnerstag, dem 15.04.2021 um 01:33 +0000 schrieb Peng Fan: > > (Was: [PATCH v4 4/4] soc: imx8m: change to use platform driver) > > > > Alice Guo (OSS) wrote on Tue, Mar 30, 2021 at 02:41:23AM +0000: > > > Thanks for reporting this issue, I'll check and add a fix to handle defer probe. > > > > I haven't seen any follow up on this, have you had a chance to take a look? > > We are trying to find a proper solution for this. > > The proper method might be make soc_device_match return probe defer, > and take early soc attr into consideration, but I am not sure this would win > maintainer's vote. > > > If this won't make it for 5.12 (in a couple of week probably?) would it make > > sense to revert 7d981405d0fd ("soc: imx8m: change to use platform > > driver") for now? > > Please no. We are targeting android GKI, make driver as modules. > And reverting to original method will also break kexec. > > I am on IRC #linux-imx, we could take more if you would like to. It seems this stalled. This regression totally breaks the kernel boot on all i.MX8M devices including the CAAM. 5.13 is about to be released, as the second upstream kernel release after 5.12 without a fix for this issue. What's the plan here? If there is no good solution small enough to be ported to the stable kernels in sight, I think the only sensible option here is to revert this change. Regards, Lucas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42156C48BDF for ; Thu, 24 Jun 2021 10:38:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 10F74613F0 for ; Thu, 24 Jun 2021 10:38:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10F74613F0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5To8fUrpu3Q/VegPs7Y8G2pL9ibEMh1q4SZozt8TdrE=; b=PYEbeAZ/jNbd6b hvW99MfSHXd15pXoxkFBXmvGwF5hcl7hHVyGy7jsG+6llx5YOC9OQVnLXTRzwUW6nQaj/vUFJHl0N 9fRYJa1EvzxHZGXZ3CVciN94tJxbeOcQKMhz32XSz4OrSwBtrt1rvVGk8kPDmcZA/mGAtGQTTFN1s 0AfdMBJ4Gi/Jrh/VKQEOa4LIxnB1m3mRgvuUv28oTslX+9EW6xJdlMjd9TM3U5jG7ASs+ZQ5XbtKn F7lhSACPlAeOXJ3Pm25qqdeECg5GBsuwrkvTyiCw4UdYq/odJnBJp8tYmrGccxnCeV7cPFdJzCXKZ 7XFEc/oEd+J6VJMzL28w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwMic-00EA2U-7V; Thu, 24 Jun 2021 10:36:22 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwMiU-00E9xV-5S for linux-arm-kernel@lists.infradead.org; Thu, 24 Jun 2021 10:36:15 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwMiK-0007jE-Cs; Thu, 24 Jun 2021 12:36:04 +0200 Message-ID: Subject: Re: [EXT] regression due to soc_device_match not handling defer (Was: [PATCH v4 4/4] soc: imx8m: change to use platform driver) From: Lucas Stach To: Peng Fan , Dominique MARTINET , "Alice Guo (OSS)" Cc: Shawn Guo , Krzysztof Kozlowski , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Date: Thu, 24 Jun 2021 12:36:02 +0200 In-Reply-To: References: <20201120101112.31819-4-alice.guo@nxp.com> User-Agent: Evolution 3.40.1 (3.40.1-1.fc34) MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_033614_327762_E4F71568 X-CRM114-Status: GOOD ( 19.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi all, Am Donnerstag, dem 15.04.2021 um 01:33 +0000 schrieb Peng Fan: > > (Was: [PATCH v4 4/4] soc: imx8m: change to use platform driver) > > > > Alice Guo (OSS) wrote on Tue, Mar 30, 2021 at 02:41:23AM +0000: > > > Thanks for reporting this issue, I'll check and add a fix to handle defer probe. > > > > I haven't seen any follow up on this, have you had a chance to take a look? > > We are trying to find a proper solution for this. > > The proper method might be make soc_device_match return probe defer, > and take early soc attr into consideration, but I am not sure this would win > maintainer's vote. > > > If this won't make it for 5.12 (in a couple of week probably?) would it make > > sense to revert 7d981405d0fd ("soc: imx8m: change to use platform > > driver") for now? > > Please no. We are targeting android GKI, make driver as modules. > And reverting to original method will also break kexec. > > I am on IRC #linux-imx, we could take more if you would like to. It seems this stalled. This regression totally breaks the kernel boot on all i.MX8M devices including the CAAM. 5.13 is about to be released, as the second upstream kernel release after 5.12 without a fix for this issue. What's the plan here? If there is no good solution small enough to be ported to the stable kernels in sight, I think the only sensible option here is to revert this change. Regards, Lucas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel