All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>
Cc: Hannes Reinecke <hare@suse.com>, Hannes Reinecke <hare@suse.de>,
	Jan Kara <jack@suse.com>,
	linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] block_dev: fix crash on chained bios with O_DIRECT
Date: Thu, 21 Mar 2019 09:28:34 +0100	[thread overview]
Message-ID: <bd4f6466-6dd1-4291-d09c-ba938b0d1bc0@suse.de> (raw)
In-Reply-To: <c5c3312f-9670-01f7-1303-e05414dc96f0@kernel.dk>

On 20/03/2019 20:57, Jens Axboe wrote:
> Yeah, you're going to overlap and crash... We really should have a build
> bug on for that.
> 
> We don't have any free ones. I've got a patch in io_uring-next that
> uses the last one.

Damn it, I have updated the patch to use 0 as well.

> That said, I do greatly prefer your approach to solving the issue.

Any ideas to proceed from here?

-- 
Johannes Thumshirn                            SUSE Labs Filesystems
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

      reply	other threads:[~2019-03-21  8:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20  8:12 [PATCH] block_dev: fix crash on chained bios with O_DIRECT Hannes Reinecke
2019-03-20  8:45 ` Johannes Thumshirn
2019-03-20  8:51   ` Hannes Reinecke
2019-03-20  8:53     ` Johannes Thumshirn
2019-03-20 11:47       ` Jan Kara
2019-03-20 13:19         ` Johannes Thumshirn
2019-03-20 19:57           ` Jens Axboe
2019-03-21  8:28             ` Johannes Thumshirn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd4f6466-6dd1-4291-d09c-ba938b0d1bc0@suse.de \
    --to=jthumshirn@suse.de \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.com \
    --cc=hare@suse.de \
    --cc=jack@suse.com \
    --cc=jack@suse.cz \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.