All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugzilla.kernel.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 204241] amdgpu fails to resume from suspend
Date: Sat, 05 Oct 2019 00:08:04 +0000	[thread overview]
Message-ID: <bug-204241-2300-esr5F7Avf0@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-204241-2300@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=204241

Ahzo@tutanota.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Ahzo@tutanota.com

--- Comment #14 from Ahzo@tutanota.com ---
Created attachment 285349
  --> https://bugzilla.kernel.org/attachment.cgi?id=285349&action=edit
Patch to prevent frequent resume failures

While this issue happens rather randomly, it can be quite reliably reproduced
on linux 5.2 and later by performing successive suspend-resume cycles.
Usually the error occurs after less than 10 cycles, but occasionally only after
more than 20. Thus one can use the following command to reproduce it almost
certainly:
$ for i in $(seq 30); do sudo rtcwake -m mem -s 5; sleep 15; done

A bisection using this method lead to:
commit 533aed278afeaa68bb5d0600856ab02268cfa3b8
Author: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Date:   Wed Mar 6 16:16:28 2019 -0500

    drm/amdgpu: Move IB pool init and fini v2

    Problem:
    Using SDMA for TLB invalidation in certain ASICs exposed a problem
    of IB pool not being ready while SDMA already up on Init and already
    shutt down while SDMA still running on Fini. This caused
    IB allocation failure. Temproary fix was commited into a
    bringup branch but this is the generic fix.

    Fix:
    Init IB pool rigth after GMC is ready but before SDMA is ready.
    Do th opposite for Fini.

    v2: Remove restriction on SDMA early init and move amdgpu_ib_pool_fini

    Reviewed-by: Christian König <christian.koenig@amd.com>
    Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>


Reverting this commit makes the problem unreproducible with above command.

Another way to prevent these frequent resume failures, while preserving the
intention of this commit, is to simply call amdgpu_ib_pool_init directly after
calling amdgpu_ucode_create_bo instead of directly before that. Attached is a
patch doing it that way.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-10-05  0:08 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-20  9:50 [Bug 204241] New: amdgpu fails to resume from suspend bugzilla-daemon
2019-07-20  9:50 ` [Bug 204241] " bugzilla-daemon
2019-08-08 20:13 ` bugzilla-daemon
2019-08-08 20:22 ` bugzilla-daemon
2019-08-08 21:02 ` bugzilla-daemon
2019-08-14 19:29 ` bugzilla-daemon
2019-08-14 19:38 ` bugzilla-daemon
2019-08-14 19:39 ` bugzilla-daemon
2019-08-14 19:39 ` bugzilla-daemon
2019-08-14 21:04 ` bugzilla-daemon
2019-08-15 20:55 ` bugzilla-daemon
2019-08-19 13:35 ` bugzilla-daemon
2019-09-03 18:56 ` bugzilla-daemon
2019-09-21 18:31 ` bugzilla-daemon
2019-10-05  0:08 ` bugzilla-daemon [this message]
2019-10-05 10:35 ` bugzilla-daemon
2019-10-07 10:13 ` bugzilla-daemon
2019-10-07 18:10 ` bugzilla-daemon
2019-10-08  7:56 ` bugzilla-daemon
2019-10-08  9:40 ` bugzilla-daemon
2019-10-11 18:33 ` bugzilla-daemon
2019-10-11 18:37 ` bugzilla-daemon
2019-10-11 20:47 ` bugzilla-daemon
2019-10-11 20:48 ` bugzilla-daemon
2019-10-12 10:37 ` bugzilla-daemon
2019-10-12 16:25 ` bugzilla-daemon
2019-10-12 18:35 ` bugzilla-daemon
2019-10-12 20:47 ` bugzilla-daemon
2019-10-13 10:47 ` bugzilla-daemon
2019-10-15 22:11 ` bugzilla-daemon
2019-10-15 22:12 ` bugzilla-daemon
2019-10-15 22:12 ` bugzilla-daemon
2019-10-16 14:27 ` bugzilla-daemon
2019-10-16 14:29 ` bugzilla-daemon
2019-10-16 17:29 ` bugzilla-daemon
2019-10-16 22:03 ` bugzilla-daemon
2019-10-20 20:06 ` bugzilla-daemon
2019-10-23 16:46 ` bugzilla-daemon
2019-10-28 20:16 ` bugzilla-daemon
2019-11-30 18:24 ` bugzilla-daemon
2019-12-07 10:28 ` bugzilla-daemon
2019-12-07 23:50 ` bugzilla-daemon
2019-12-07 23:55 ` bugzilla-daemon
2019-12-11  0:37 ` bugzilla-daemon
2019-12-11  0:39 ` bugzilla-daemon
2019-12-12  5:00 ` bugzilla-daemon
2019-12-12 14:37 ` bugzilla-daemon
2019-12-13 10:38 ` bugzilla-daemon
2019-12-16  4:40 ` bugzilla-daemon
2019-12-16 13:40 ` bugzilla-daemon
2019-12-20 22:17 ` bugzilla-daemon
2020-02-25  1:22 ` bugzilla-daemon
2020-02-25  2:00 ` bugzilla-daemon
2020-02-25  3:06 ` bugzilla-daemon
2020-02-25 17:26 ` bugzilla-daemon
2020-02-25 21:26 ` bugzilla-daemon
2020-02-26  9:54 ` bugzilla-daemon
2020-04-10 21:16 ` bugzilla-daemon
2020-04-15 19:43 ` bugzilla-daemon
2020-04-15 19:50 ` bugzilla-daemon
2020-05-13 20:45 ` bugzilla-daemon
2020-05-17 20:40 ` bugzilla-daemon
2020-06-24 19:15 ` bugzilla-daemon
2020-07-27 16:02 ` bugzilla-daemon
2020-07-27 16:03 ` bugzilla-daemon
2020-09-25  7:31 ` bugzilla-daemon
2020-09-25  7:34 ` bugzilla-daemon
2020-09-30  9:22 ` bugzilla-daemon
2020-09-30 16:31 ` bugzilla-daemon
2020-09-30 19:23 ` bugzilla-daemon
2020-09-30 20:03 ` bugzilla-daemon
2020-10-01 14:59 ` bugzilla-daemon
2020-10-01 17:21 ` bugzilla-daemon
2020-10-01 17:27 ` bugzilla-daemon
2020-10-01 17:55 ` bugzilla-daemon
2021-02-08 22:00 ` bugzilla-daemon
2021-02-08 22:13 ` bugzilla-daemon
2021-02-08 22:15 ` bugzilla-daemon
2023-04-13 20:11 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-204241-2300-esr5F7Avf0@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@bugzilla.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.