From: Anand Jain <anand.jain@oracle.com>
To: Josef Bacik <josef@toxicpanda.com>,
linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] btrfs: hold the uuid_mutex for all close_fs_devices calls
Date: Sat, 29 Aug 2020 22:46:03 +0800 [thread overview]
Message-ID: <c04069a9-67b9-e531-35f4-3d8199ef6c0d@oracle.com> (raw)
In-Reply-To: <e45e00c3d31286c86b76693262266e702ed7f1a3.1598624685.git.josef@toxicpanda.com>
On 28/8/20 10:24 pm, Josef Bacik wrote:
> My recent change to not take the device_list_mutex for closing devices
> added a lockdep_assert_held(&uuid_mutex) to close_fs_devices. I then
> went and verified all calls had that, except I overlooked
> btrfs_close_devices() where we close seed devices. Fix this by holding
> the uuid_mutex for this entire operation.
>
> 20cc6d129252 ("btrfs: do not hold device_list_mutex when closing devices")
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> ---
> fs/btrfs/volumes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index 6f489245eec6..3f8bd1af29eb 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -1183,13 +1183,13 @@ void btrfs_close_devices(struct btrfs_fs_devices *fs_devices)
> close_fs_devices(fs_devices);
> if (!fs_devices->opened)
> list_splice_init(&fs_devices->seed_list, &list);
> - mutex_unlock(&uuid_mutex);
>
> list_for_each_entry_safe(fs_devices, tmp, &list, seed_list) {
> close_fs_devices(fs_devices);
> list_del(&fs_devices->seed_list);
> free_fs_devices(fs_devices);
> }
> + mutex_unlock(&uuid_mutex);
> }
>
> static int open_fs_devices(struct btrfs_fs_devices *fs_devices,
>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Thanks, Anand
prev parent reply other threads:[~2020-08-29 14:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 14:24 [PATCH] btrfs: hold the uuid_mutex for all close_fs_devices calls Josef Bacik
2020-08-28 14:27 ` Nikolay Borisov
2020-08-28 15:08 ` David Sterba
2020-08-29 14:46 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c04069a9-67b9-e531-35f4-3d8199ef6c0d@oracle.com \
--to=anand.jain@oracle.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.