From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DC32C433EF for ; Mon, 27 Sep 2021 18:26:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EAC6E60F6C for ; Mon, 27 Sep 2021 18:26:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236054AbhI0S1m (ORCPT ); Mon, 27 Sep 2021 14:27:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236011AbhI0S1l (ORCPT ); Mon, 27 Sep 2021 14:27:41 -0400 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81B18C061575; Mon, 27 Sep 2021 11:26:03 -0700 (PDT) Received: by mail-pg1-x52b.google.com with SMTP id k24so18598431pgh.8; Mon, 27 Sep 2021 11:26:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Bf4xnM2QqgUxuhdJ2I+dKbta+av8Oq2vvSk2x8cDYEI=; b=Dm69+hqvEfmCFGZUnPqwLYGGIRXKkfBI68DHQFLyc5uIgGekdLt9/2tcBJXsjb5S9X cLJgqDkPPbtZgztN6t/SvVU/MofuRTTSEcvOqh1cKFoNQlGMsJB/llg7tquD+J3yh9DE SZE2N/QKMXvIoxqHUSIP9MumTRMouu3lve1Q23qHv2CS4syoRFyCTlnekbiIG8EdqbYm IcpXZUJfv17K+wXD2fQSM4pnuQImOobuOIcntWBEULuFdoiZagEBqzKlfrdgcRcoQ7lp mGQPdKjm5aS/39m0Qksw49xSslZIYRcLlTlvA7oLr3YwvAyKDKOnLQ63So+kGFii7n1H Q/zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Bf4xnM2QqgUxuhdJ2I+dKbta+av8Oq2vvSk2x8cDYEI=; b=eHPgLdXDeLEeTl0sHlsqJWS/hcJtk4ZbwC8IIapfydZvqUTjvzBuj8DaOxz0Mxmc2W bhi5W1xqsQKCX5kyrY3wEBJFoziubpsZepOMJKu/atzK+eGaHsi4KPpIKAI2Xjn+bzge hcGZfFRx6mEIcWO+TXenjEWRzk4loDYp7799xjo9Z20Yc6lopijWMnBdMNlfMBIe7aCq tLM6NbNIFrsuSB/QcFfwi9+TVZylQv9QbeUwRGtrm5a/H9YWMl7QVEG6ooYRQrK4J7Kq 84OIIoBvdZsupIXp4309CAd0eOGi07j5vzIibp0NKIEhca8iZpERBmHtNEYyV1eemMNG gNjQ== X-Gm-Message-State: AOAM532GS4cQQkkrm124iBLi78xOYhtcDUApXufRlMCpX1CcytnSuWh1 hOOFJBgTfxw90D3wsCko7u+LQoMX+RM= X-Google-Smtp-Source: ABdhPJy4JNQdxtxWBqpUhRjVFIqwwaqFn55WhunZCwCE7x+aKMn9ygX0ZoEpIy2IJ6cu40CgmBM31g== X-Received: by 2002:a63:b04c:: with SMTP id z12mr875400pgo.371.1632767162606; Mon, 27 Sep 2021 11:26:02 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id z65sm16337907pfc.30.2021.09.27.11.25.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Sep 2021 11:26:02 -0700 (PDT) Subject: Re: [PATCH 03/11] genirq: Export irq_set_affinity_locked() To: Thomas Gleixner , Florian Fainelli , Marc Zyngier Cc: linux-kernel@vger.kernel.org, Russell King , Ray Jui , Scott Branden , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , Catalin Marinas , Will Deacon , Yoshinori Sato , Rich Felker , Rob Herring , Frank Rowand , Ard Biesheuvel , Mike Rapoport , Linus Walleij , Andrew Morton , Geert Uytterhoeven , Arnd Bergmann , Guenter Roeck , Kefeng Wang , Mark Rutland , Andrey Konovalov , Anshuman Khandual , Valentin Schneider , Ingo Molnar , Peter Zijlstra , "moderated list:ARM PORT" , "open list:SUPERH" , "open list:BROADCOM BMIPS MIPS ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" References: <20210924170546.805663-1-f.fainelli@gmail.com> <20210924170546.805663-4-f.fainelli@gmail.com> <87tui8ub87.wl-maz@kernel.org> <87tui8cpwd.ffs@tglx> <87r1dccp5z.ffs@tglx> <3e73c85e-20d1-43ae-3c3a-04322ffa970e@gmail.com> <87tui5c26b.ffs@tglx> From: Florian Fainelli Message-ID: Date: Mon, 27 Sep 2021 11:25:58 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87tui5c26b.ffs@tglx> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org On 9/27/21 11:18 AM, Thomas Gleixner wrote: > On Mon, Sep 27 2021 at 10:47, Florian Fainelli wrote: >> On 9/25/21 2:37 PM, Thomas Gleixner wrote: >>>> I wanted to kill these callbacks years ago. Cavium has two variants of >>>> those offline/online callbacks: >>>> >>>> 1) octeon_irq_cpu_offline_ciu() which is doing the same as that BCM >>>> driver. These really can go away. Just remove the callback and >>>> everything just works. >>> >>> For BCM this works today when that chip is used on ARM[64] simply >>> because the only architecture which invokes irq_cpu_offline() is MIPS. >> >> That is correct. How would you recommend addressing that? In premise >> when this driver is used on ARM[64] it is used as a second level >> interrupt controller hanging off the ARM GIC (or another ARM CPU >> interrupt controller), so in that case I suppose I could make the >> irq_set_cpu_offline be dependent upon CONFIG_SMP and CONFIG_MIPS, would >> that be acceptable? > > Why? Just get rid of the callback in that driver and ensure that > irq_migrate_all_off_this_cpu() is invoked when the CPU dies. > > arch/mips/kernel/smp-cps.c already does that, but I don't know whether > your MIPS platform uses those SMP ops. If not you surely have a template > there. We use arch/mips/kernel/smp-bmips.c but I do see the path forward, thanks! -- -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A614EC433F5 for ; Mon, 27 Sep 2021 18:28:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6954460FBF for ; Mon, 27 Sep 2021 18:28:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6954460FBF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=jINQVAjtt1BKih/+JesinPVJVP/rf1N+pvah3/uRUek=; b=tHhUjszgp3fQZOH1mSInHKyRP5 9/Sh3XiBMTh6ltX9zyyF8ABcTcYTse7ZKije5fr9rxoBh6ZMU+WZtofJbiU3IpbLVvscqCZXo2Q/E LgkRsHttFWPYXfq8GIJZhMceSn8dkI9brwsh61pcG1TTj6Kagxq1mIX+xxyaGcB3CwvP1qk9fBNDP jsU1EnYseIEZSuNn52u+nG2WRF2LRDhD2Ogm3sISxtkYJp4/fJgYiq7yhdYAlJdY/ESIm472/2e05 10QmUzBeinEmyMMHeaqlLYftfm0JLCzSrPTKgm5dryoQAAe6hs11GYGgoa7sQbGPefzJtBjWyLdNa 9vVBRwnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUvKK-003mJT-Gs; Mon, 27 Sep 2021 18:26:08 +0000 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUvKG-003mI8-On for linux-arm-kernel@lists.infradead.org; Mon, 27 Sep 2021 18:26:06 +0000 Received: by mail-pf1-x42e.google.com with SMTP id 203so16602781pfy.13 for ; Mon, 27 Sep 2021 11:26:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Bf4xnM2QqgUxuhdJ2I+dKbta+av8Oq2vvSk2x8cDYEI=; b=Dm69+hqvEfmCFGZUnPqwLYGGIRXKkfBI68DHQFLyc5uIgGekdLt9/2tcBJXsjb5S9X cLJgqDkPPbtZgztN6t/SvVU/MofuRTTSEcvOqh1cKFoNQlGMsJB/llg7tquD+J3yh9DE SZE2N/QKMXvIoxqHUSIP9MumTRMouu3lve1Q23qHv2CS4syoRFyCTlnekbiIG8EdqbYm IcpXZUJfv17K+wXD2fQSM4pnuQImOobuOIcntWBEULuFdoiZagEBqzKlfrdgcRcoQ7lp mGQPdKjm5aS/39m0Qksw49xSslZIYRcLlTlvA7oLr3YwvAyKDKOnLQ63So+kGFii7n1H Q/zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Bf4xnM2QqgUxuhdJ2I+dKbta+av8Oq2vvSk2x8cDYEI=; b=gauJpIuAxEfxffAzsP04+qfwr1V5soHuQngFuHOSlMv7xa9zgv5CevN8xYAaR4OwRW X8NJ/Rt3A5juFBPeOEOIL0c3V85IUnrrar7AhjqZvAPhSiULJoBqxq8FJQMvPHR6bHuw FCb5Ly1jTmBGeplZNpzn55y3BI/o/G3QzW6YeSRB0WSNLGMrbZHcFIj2xivpmifJ+FFs JZnytFwbvLpF43JgcCcwpAcLuyx4h7Ol2Kt8ajQrQifDh3QByyXKHxtXIwvcCeiHZpZM +0iAVWSpbgszxVWJwYEXxjYR+XFdVolz2BrkjSRvNyLNJsp3CxR8g0ezXETGcEuFzH2x Nrag== X-Gm-Message-State: AOAM530Qn7buryE5Mun4uDAdrjU74nqr6tOJazZz7MYvZlYSxJ+g0yfx Gh7+yf7tJ0w1XIkxZeBrZag= X-Google-Smtp-Source: ABdhPJy4JNQdxtxWBqpUhRjVFIqwwaqFn55WhunZCwCE7x+aKMn9ygX0ZoEpIy2IJ6cu40CgmBM31g== X-Received: by 2002:a63:b04c:: with SMTP id z12mr875400pgo.371.1632767162606; Mon, 27 Sep 2021 11:26:02 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id z65sm16337907pfc.30.2021.09.27.11.25.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Sep 2021 11:26:02 -0700 (PDT) Subject: Re: [PATCH 03/11] genirq: Export irq_set_affinity_locked() To: Thomas Gleixner , Florian Fainelli , Marc Zyngier Cc: linux-kernel@vger.kernel.org, Russell King , Ray Jui , Scott Branden , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , Catalin Marinas , Will Deacon , Yoshinori Sato , Rich Felker , Rob Herring , Frank Rowand , Ard Biesheuvel , Mike Rapoport , Linus Walleij , Andrew Morton , Geert Uytterhoeven , Arnd Bergmann , Guenter Roeck , Kefeng Wang , Mark Rutland , Andrey Konovalov , Anshuman Khandual , Valentin Schneider , Ingo Molnar , Peter Zijlstra , "moderated list:ARM PORT" , "open list:SUPERH" , "open list:BROADCOM BMIPS MIPS ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" References: <20210924170546.805663-1-f.fainelli@gmail.com> <20210924170546.805663-4-f.fainelli@gmail.com> <87tui8ub87.wl-maz@kernel.org> <87tui8cpwd.ffs@tglx> <87r1dccp5z.ffs@tglx> <3e73c85e-20d1-43ae-3c3a-04322ffa970e@gmail.com> <87tui5c26b.ffs@tglx> From: Florian Fainelli Message-ID: Date: Mon, 27 Sep 2021 11:25:58 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87tui5c26b.ffs@tglx> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210927_112604_844701_6AC449DA X-CRM114-Status: GOOD ( 24.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/27/21 11:18 AM, Thomas Gleixner wrote: > On Mon, Sep 27 2021 at 10:47, Florian Fainelli wrote: >> On 9/25/21 2:37 PM, Thomas Gleixner wrote: >>>> I wanted to kill these callbacks years ago. Cavium has two variants of >>>> those offline/online callbacks: >>>> >>>> 1) octeon_irq_cpu_offline_ciu() which is doing the same as that BCM >>>> driver. These really can go away. Just remove the callback and >>>> everything just works. >>> >>> For BCM this works today when that chip is used on ARM[64] simply >>> because the only architecture which invokes irq_cpu_offline() is MIPS. >> >> That is correct. How would you recommend addressing that? In premise >> when this driver is used on ARM[64] it is used as a second level >> interrupt controller hanging off the ARM GIC (or another ARM CPU >> interrupt controller), so in that case I suppose I could make the >> irq_set_cpu_offline be dependent upon CONFIG_SMP and CONFIG_MIPS, would >> that be acceptable? > > Why? Just get rid of the callback in that driver and ensure that > irq_migrate_all_off_this_cpu() is invoked when the CPU dies. > > arch/mips/kernel/smp-cps.c already does that, but I don't know whether > your MIPS platform uses those SMP ops. If not you surely have a template > there. We use arch/mips/kernel/smp-bmips.c but I do see the path forward, thanks! -- -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel