All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Igor Druzhinin <igor.druzhinin@citrix.com>,
	osstest-admin@xenproject.org,
	xen-devel <xen-devel@lists.xenproject.org>,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [xen-unstable test] 112855: regressions - trouble: blocked/broken/fail/pass
Date: Mon, 28 Aug 2017 11:36:29 -0400	[thread overview]
Message-ID: <c1c9b38b-ef32-e605-ed1f-73ca514fc3b6@oracle.com> (raw)
In-Reply-To: <59A44A330200007800174983@prv-mh.provo.novell.com>

On 08/28/2017 10:52 AM, Jan Beulich wrote:
>>>> On 28.08.17 at 16:24, <boris.ostrovsky@oracle.com> wrote:
>>>> As for periodically testing process_pending_softirqs() we may still want
>>>> to do this in alloc_heap_pages(), even without CONFIG_SCRUB_DEBUG.
>>> For my taste, alloc_heap_pages() is the wrong place for such
>>> calls.
>> But the loop is in alloc_heap_pages() --- where else would you be testing?
> It can only reasonably be the callers of alloc_heap_pages() imo.
> A single call to it should never trigger the watchdog, 

check_one_page() is rather slow so for a large order allocation even
with clean heap the 'for' loop may take quite some time. Whether it
could trip the watchdog -- I don't know.

-boris

> only calls
> themselves sitting in a loop should be potential candidates for
> causing such.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-08-28 15:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-25  3:15 [xen-unstable test] 112855: regressions - trouble: blocked/broken/fail/pass osstest service owner
2017-08-25 13:40 ` Jan Beulich
2017-08-25 17:14   ` Boris Ostrovsky
2017-08-28  7:25     ` Jan Beulich
2017-08-28 13:57       ` Boris Ostrovsky
2017-08-28 14:02         ` Jan Beulich
2017-08-28 14:24           ` Boris Ostrovsky
2017-08-28 14:52             ` Jan Beulich
2017-08-28 15:36               ` Boris Ostrovsky [this message]
2017-08-29  8:07                 ` Jan Beulich
2017-08-29 12:45                   ` Boris Ostrovsky
2017-08-29 13:12                     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1c9b38b-ef32-e605-ed1f-73ca514fc3b6@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=JBeulich@suse.com \
    --cc=igor.druzhinin@citrix.com \
    --cc=osstest-admin@xenproject.org \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.