On 1/10/19 9:53 AM, Peter Maydell wrote: >> Note that my miniinfo email account no longer exists, but I >> can still be reached at mmogilvi+qemu@zoho.com if desired. >> >> Regarding the patch, I haven't kept up with changes to qemu >> well enough to really have a useful opinion, although superficially >> it looks good. Perhaps it would make sense to include both >> my old and new email addresses in the sign-off section, to both >> tie it to the old threads and make it easier to reach me >> if someone wants to contact me? (But I'm not sure of a "clean" >> way to do so, and it is probably low priority. Perhaps this >> current email is good enough?) > > Thanks for the followup. Unfortunately the commit is already > in master so we can't tweak the commit message at this point. > That shouldn't matter much, people don't often fish emails out > of old commit message logs to email anyway :-) We can't change the commit message body, but if you are worried about people still being able to reach you based about a patch they found while browsing git history, we DO have .mailmap where you can list a new preferred email address to use in place of any commits you made under an old address. Patching .mailmap is a nice (but optional) way to let people know how to reach you, if you still expect to be reached. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org