From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: tim@xen.org, sstabellini@kernel.org, wei.liu2@citrix.com,
George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v2 5/9] mm: Do not discard already-scrubbed pages softirqs are pending
Date: Thu, 13 Apr 2017 12:46:58 -0400 [thread overview]
Message-ID: <c299b8e1-0342-cad6-b16e-2898fb7a0db5@oracle.com> (raw)
In-Reply-To: <58EFB8390200007800150DC4@prv-mh.provo.novell.com>
On 04/13/2017 11:41 AM, Jan Beulich wrote:
>>>> On 03.04.17 at 18:50, <boris.ostrovsky@oracle.com> wrote:
>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> To be honest, without a proper description and with an apparently
> not really well formed title I don't want to start guessing what the
> patch intends, and whether the changes done match that intention.
> I guess this should really have been an RFC ...
There was an RFC for this
(https://lists.xenproject.org/archives/html/xen-devel/2017-02/msg03237.html)
but your point is well taken.
Commit message should have been something like:
To avoid delaying softirq processing while scrubbing check
for softirqs every 256 pages. If softirq is pending, stop scrubbing
and merge the partially-scrubbed buddy by breaking the clean
portion into smaller power-of-2 chunks. Then repeat the same
process for the dirty part.
I was about to post the new version of this series, with dirty bit per
page. I'll make updates based on your comments today (and yesterday) and
if you review this patch in this version I'll include your comment into
that version as well.
-boris
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-04-13 16:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 16:50 [PATCH v2 0/9] Memory scrubbing from idle loop Boris Ostrovsky
2017-04-03 16:50 ` [PATCH v2 1/9] mm: Separate free page chunk merging into its own routine Boris Ostrovsky
2017-04-04 11:16 ` Jan Beulich
2017-04-04 13:48 ` Boris Ostrovsky
2017-04-04 14:01 ` Jan Beulich
2017-04-04 14:23 ` Boris Ostrovsky
2017-04-03 16:50 ` [PATCH v2 2/9] mm: Place unscrubbed pages at the end of pagelist Boris Ostrovsky
2017-04-04 14:46 ` Jan Beulich
2017-04-04 15:14 ` Boris Ostrovsky
2017-04-04 15:29 ` Jan Beulich
2017-04-04 15:39 ` Boris Ostrovsky
2017-04-04 15:50 ` Jan Beulich
2017-04-04 16:22 ` Boris Ostrovsky
2017-04-03 16:50 ` [PATCH v2 3/9] mm: Scrub pages in alloc_heap_pages() if needed Boris Ostrovsky
2017-04-03 16:50 ` [PATCH v2 4/9] mm: Scrub memory from idle loop Boris Ostrovsky
2017-04-12 16:11 ` Jan Beulich
2017-04-03 16:50 ` [PATCH v2 5/9] mm: Do not discard already-scrubbed pages softirqs are pending Boris Ostrovsky
2017-04-13 15:41 ` Jan Beulich
2017-04-13 16:46 ` Boris Ostrovsky [this message]
2017-04-03 16:50 ` [PATCH v2 6/9] spinlock: Introduce spin_lock_cb() Boris Ostrovsky
2017-04-13 15:46 ` Jan Beulich
2017-04-13 16:55 ` Boris Ostrovsky
2017-04-18 6:49 ` Jan Beulich
2017-04-18 12:32 ` Boris Ostrovsky
2017-04-18 12:43 ` Jan Beulich
2017-04-18 13:14 ` Boris Ostrovsky
2017-04-03 16:50 ` [PATCH v2 7/9] mm: Keep pages available for allocation while scrubbing Boris Ostrovsky
2017-04-13 15:59 ` Jan Beulich
2017-04-03 16:50 ` [PATCH v2 8/9] mm: Print number of unscrubbed pages in 'H' debug handler Boris Ostrovsky
2017-04-03 16:50 ` [PATCH v2 9/9] mm: Make sure pages are scrubbed Boris Ostrovsky
2017-04-04 15:21 ` [PATCH v2 0/9] Memory scrubbing from idle loop George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c299b8e1-0342-cad6-b16e-2898fb7a0db5@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.