From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Cleber Rosa <crosa@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [PATCH] decodetree: Open files with encoding='utf-8'
Date: Fri, 8 Jan 2021 19:02:20 +0100 [thread overview]
Message-ID: <c321eb16-5bff-ebb0-0a9f-1a6637d1c36c@amsat.org> (raw)
In-Reply-To: <CAFEAcA87yvTykxUGkPZaDcD0i8LN2-6Yhh_HpSrZc_ZD3dbMqw@mail.gmail.com>
On 1/8/21 6:14 PM, Peter Maydell wrote:
> On Fri, 8 Jan 2021 at 16:44, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>
>> On 1/8/21 4:38 PM, Peter Maydell wrote:
>>> Should we also be opening the output file explicitly as
>>> utf-8 ? (How do we say "write to sys.stdout as utf-8" for
>>> the case where we're doing that?)
>>
>> I have been wondering about it, but the content written
>> in the output file is plain C code using only ASCII,
>> which any locale is able to process. But indeed maybe
>> we prefer ignore the user locale... I'm not sure.
>
> I'm not a python expert so I don't know what the usual thing
> is here, but it seems to me better to insulate our build
> process from what the user's locale happens to be set to,
> even if it happens that we currently only output ASCII.
OK, I'll respin.
next prev parent reply other threads:[~2021-01-08 18:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 15:16 [PATCH] decodetree: Open files with encoding='utf-8' Philippe Mathieu-Daudé
2021-01-08 15:25 ` 罗勇刚(Yonggang Luo)
2021-01-08 15:38 ` Peter Maydell
2021-01-08 16:13 ` 罗勇刚(Yonggang Luo)
2021-01-08 16:43 ` Eduardo Habkost
2021-01-08 16:44 ` Philippe Mathieu-Daudé
2021-01-08 17:14 ` Peter Maydell
2021-01-08 18:02 ` Philippe Mathieu-Daudé [this message]
2021-01-08 22:51 ` Daniele Buono
2021-01-12 21:11 ` Eduardo Habkost
2021-01-12 23:35 ` John Snow
2021-01-12 23:44 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c321eb16-5bff-ebb0-0a9f-1a6637d1c36c@amsat.org \
--to=f4bug@amsat.org \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.