From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: marcandre.lureau@gmail.com, mdroth@linux.vnet.ibm.com
Subject: Re: [PATCH v6 08/10] qapi: Implement deprecated-input=reject for QMP commands
Date: Mon, 15 Mar 2021 11:16:30 -0500 [thread overview]
Message-ID: <c4a70e1f-b6ff-c514-9618-514666db7f59@redhat.com> (raw)
In-Reply-To: <20210312153210.2810514-9-armbru@redhat.com>
On 3/12/21 9:32 AM, Markus Armbruster wrote:
> This policy rejects deprecated input, and thus permits "testing the
> future". Implement it for QMP commands: make deprecated ones fail.
> Example: when QEMU is run with -compat deprecated-input=reject, then
>
> {"execute": "query-cpus"}
>
> fails like this
>
> {"error": {"class": "CommandNotFound", "desc": "Deprecated command query-cpus disabled by policy"}}
>
> When the deprecated command is removed, the error will change to
>
> {"error": {"class": "CommandNotFound", "desc": "The command query-cpus has not been found"}}
Again, Dan's patch changes this permanently:
https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg07566.html
Up to you if you want to tweak the example, but the concept of the patch
is still fine, so my R-b still stands.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2021-03-15 16:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 15:32 [PATCH v6 00/10] Configurable policy for handling deprecated interfaces Markus Armbruster
2021-03-12 15:32 ` [PATCH v6 01/10] qemu-options: New -compat to set policy for " Markus Armbruster
2021-03-15 15:41 ` Eric Blake
2021-03-15 16:29 ` Markus Armbruster
2021-03-12 15:32 ` [PATCH v6 02/10] qapi: Implement deprecated-output=hide for QMP command results Markus Armbruster
2021-03-15 15:45 ` Eric Blake
2021-03-15 16:33 ` Markus Armbruster
2021-03-18 13:36 ` Markus Armbruster
2021-03-12 15:32 ` [PATCH v6 03/10] qapi: Implement deprecated-output=hide for QMP events Markus Armbruster
2021-03-12 15:32 ` [PATCH v6 04/10] qapi: Implement deprecated-output=hide for QMP event data Markus Armbruster
2021-03-12 15:32 ` [PATCH v6 05/10] monitor: Drop query-qmp-schema 'gen': false hack Markus Armbruster
2021-03-15 16:10 ` Eric Blake
2021-03-15 16:34 ` Markus Armbruster
2021-03-12 15:32 ` [PATCH v6 06/10] qapi: Implement deprecated-output=hide for QMP introspection Markus Armbruster
2021-03-15 16:13 ` Eric Blake
2021-03-12 15:32 ` [PATCH v6 07/10] test-util-sockets: Add stub for monitor_set_cur() Markus Armbruster
2021-03-15 16:14 ` Eric Blake
2021-03-12 15:32 ` [PATCH v6 08/10] qapi: Implement deprecated-input=reject for QMP commands Markus Armbruster
2021-03-15 16:16 ` Eric Blake [this message]
2021-03-12 15:32 ` [PATCH v6 09/10] qapi: Implement deprecated-input=reject for QMP command arguments Markus Armbruster
2021-03-12 15:32 ` [PATCH v6 10/10] qapi: New -compat deprecated-input=crash Markus Armbruster
2021-03-15 16:19 ` Eric Blake
2021-03-18 15:08 ` [PATCH v6 00/10] Configurable policy for handling deprecated interfaces Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4a70e1f-b6ff-c514-9618-514666db7f59@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.