All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: pannengyuan@huawei.com, peter.maydell@linaro.org
Cc: xuding42@huawei.com, Euler Robot <euler.robot@huawei.com>,
	qemu-arm@nongnu.org, zhang.zhanghailiang@huawei.com,
	qemu-devel@nongnu.org
Subject: Re: [PATCH] pl031: add finalize function to avoid memleaks
Date: Mon, 3 Feb 2020 07:59:41 +0000	[thread overview]
Message-ID: <c4fdea63-0d7e-1f0a-b0f9-68bce365dc5e@linaro.org> (raw)
In-Reply-To: <20200203074718.37252-1-pannengyuan@huawei.com>

On 2/3/20 7:47 AM, pannengyuan@huawei.com wrote:
> +static void pl031_finalize(Object *obj)
> +{
> +    PL031State *s = PL031(obj);
> +    if (s->timer) {

As far as I can see, s->timer can never be null.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~


  reply	other threads:[~2020-02-03  8:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-03  7:47 [PATCH] pl031: add finalize function to avoid memleaks pannengyuan
2020-02-03  7:59 ` Richard Henderson [this message]
2020-02-03  8:13   ` Pan Nengyuan
2020-02-03  9:58 ` Peter Maydell
2020-02-04  0:49   ` Pan Nengyuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4fdea63-0d7e-1f0a-b0f9-68bce365dc5e@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=euler.robot@huawei.com \
    --cc=pannengyuan@huawei.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=xuding42@huawei.com \
    --cc=zhang.zhanghailiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.