From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 1/6] block: change the blk_queue_split calling convention
Date: Thu, 28 Jul 2022 09:55:52 +0200 [thread overview]
Message-ID: <c55c272c-0bb2-d651-5bb1-5e9b5b052788@suse.de> (raw)
In-Reply-To: <20220727162300.3089193-2-hch@lst.de>
On 7/27/22 18:22, Christoph Hellwig wrote:
> The double indirect bio leads to somewhat suboptimal code generation.
> Instead return the (original or split) bio, and make sure the
> request_queue arguments to the lower level helpers is passed after the
> bio to avoid constant reshuffling of the argument passing registers.
>
> Also give it and the helpers used to implement it more descriptive names.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> block/blk-merge.c | 98 +++++++++++++++++------------------
> block/blk-mq.c | 4 +-
> block/blk.h | 6 +--
> drivers/block/drbd/drbd_req.c | 2 +-
> drivers/block/pktcdvd.c | 2 +-
> drivers/block/ps3vram.c | 2 +-
> drivers/md/dm.c | 6 +--
> drivers/md/md.c | 2 +-
> drivers/nvme/host/multipath.c | 2 +-
> drivers/s390/block/dcssblk.c | 2 +-
> include/linux/blkdev.h | 2 +-
> 11 files changed, 63 insertions(+), 65 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
next prev parent reply other threads:[~2022-07-28 7:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 16:22 bio splitting cleanups v4 Christoph Hellwig
2022-07-27 16:22 ` [PATCH 1/6] block: change the blk_queue_split calling convention Christoph Hellwig
2022-07-27 16:29 ` Jens Axboe
2022-07-28 1:53 ` Damien Le Moal
2022-07-28 7:55 ` Hannes Reinecke [this message]
2022-07-27 16:22 ` [PATCH 2/6] block: change the blk_queue_bounce " Christoph Hellwig
2022-07-28 7:56 ` Hannes Reinecke
2022-07-27 16:22 ` [PATCH 3/6] block: move ->bio_split to the gendisk Christoph Hellwig
2022-07-28 8:07 ` Hannes Reinecke
2022-07-28 14:32 ` Christoph Hellwig
2022-07-28 15:35 ` Ming Lei
2022-07-27 16:22 ` [PATCH 4/6] block: move the call to get_max_io_size out of blk_bio_segment_split Christoph Hellwig
2022-07-28 8:08 ` Hannes Reinecke
2022-07-27 16:22 ` [PATCH 5/6] block: move bio_allowed_max_sectors to blk-merge.c Christoph Hellwig
2022-07-27 16:23 ` [PATCH 6/6] block: pass struct queue_limits to the bio splitting helpers Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2022-07-26 18:30 bio splitting cleanups v3 Christoph Hellwig
2022-07-26 18:30 ` [PATCH 1/6] block: change the blk_queue_split calling convention Christoph Hellwig
2022-07-26 23:26 ` Damien Le Moal
2022-07-27 15:52 ` Christoph Hellwig
2022-07-27 16:03 ` Jens Axboe
2022-07-27 15:01 ` Jens Axboe
2022-07-23 6:28 bio splitting cleanups v2 Christoph Hellwig
2022-07-23 6:28 ` [PATCH 1/6] block: change the blk_queue_split calling convention Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c55c272c-0bb2-d651-5bb1-5e9b5b052788@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.