From: hare@suse.de (Hannes Reinecke)
Subject: [PATCHv2] nvme/fc: add 'discovery' sysfs attribute to fc transport device
Date: Mon, 4 Dec 2017 08:18:19 +0100 [thread overview]
Message-ID: <c6214e48-9e26-f2fc-f8f0-9e0b5dac17be@suse.de> (raw)
In-Reply-To: <aa2b156b-7fa0-dc0d-4885-7ac4b4dd9842@broadcom.com>
On 12/01/2017 05:21 PM, James Smart wrote:
> On 12/1/2017 1:27 AM, Hannes Reinecke wrote:
>> +??? spin_lock_irqsave(&nvme_fc_lock, flags);
>> +??? list_for_each_entry(lport, &nvme_fc_lport_list, port_list) {
>> +??????? list_for_each_entry(rport, &lport->endp_list, endp_list) {
>> +??????????? if (!nvme_fc_lport_get(lport))
>> +??????????????? continue;
>> +??????????? if (!nvme_fc_rport_get(rport))
>> +??????????????? continue;
>
> ref counting messed up if rport_get fails - need to back out the lport get.
>
Bah. Correct.
Will be sending a new version.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare at suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG N?rnberg)
prev parent reply other threads:[~2017-12-04 7:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 9:27 [PATCHv2] nvme/fc: add 'discovery' sysfs attribute to fc transport device Hannes Reinecke
2017-12-01 16:21 ` James Smart
2017-12-04 7:18 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6214e48-9e26-f2fc-f8f0-9e0b5dac17be@suse.de \
--to=hare@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.