From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 192B9C43331 for ; Mon, 11 Nov 2019 08:11:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2CBF20818 for ; Mon, 11 Nov 2019 08:11:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=web.de header.i=@web.de header.b="Up+hoPUA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727001AbfKKIL2 (ORCPT ); Mon, 11 Nov 2019 03:11:28 -0500 Received: from mout.web.de ([212.227.15.14]:52665 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726768AbfKKIL2 (ORCPT ); Mon, 11 Nov 2019 03:11:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1573459874; bh=yLeMLMfEOOmRdYGLi72Oh+GomTas8U7P2yb54eV5zIE=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Up+hoPUAJDhsVkdhiTrnfBwMcgFNBzZfhRImfJl7jeI3cyRVHxoPJa7uRMxE+vwlE AA0Jn+iOcibvwfLJFzImykZX3+LeMocRtqcarUOZSZMh52TyUBnYcntCV/5WW4A1I5 oDPuRt4g0gzN7u2a1Y3gMgOqKpnLceNfD30eu/Kc= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([78.48.123.26]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LpwMZ-1i0lWP1Jkl-00fjpe; Mon, 11 Nov 2019 09:11:14 +0100 Subject: Re: [v3] s390/pkey: Use memdup_user() rather than duplicating its implementation To: =?UTF-8?Q?Christian_Borntr=c3=a4ger?= , linux-s390@vger.kernel.org, Harald Freudenberger , Heiko Carstens , Ingo Franzki , Vasily Gorbik , Joe Perches Cc: LKML , kernel-janitors@vger.kernel.org, Kangjie Lu , Navid Emamdoost , Stephen McCamant References: <08422b7e-2071-ee52-049e-c3ac55bc67a9@web.de> <6137855bb4170c438c7436cbdb7dfd21639a8855.camel@perches.com> <833d7d5e-6ede-6bdd-a2cc-2da7f0b03908@de.ibm.com> <1b65bc81-f47a-eefa-f1f4-d5af6a1809c0@web.de> <733b29df-207e-a165-ee80-46be8720c0c4@de.ibm.com> <8f98f9fc-57df-5993-44b5-5ea4c0de7ef9@web.de> <61244676-8ac1-20af-ed94-99e19c1f95d5@web.de> <040f3e18-d97a-fc32-b237-20e7553e1733@de.ibm.com> From: Markus Elfring Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: Date: Mon, 11 Nov 2019 09:11:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <040f3e18-d97a-fc32-b237-20e7553e1733@de.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:vH4aX6LXNvdHTc+K1DuZ8FwCr07s13jof9BYG9/BhG4eGujVsPH raoUQMGWsBCFkYFCgYpLWsrzBzBp7huXdzbh/cdjmmS5P/fyhdEoV45lXQmLJafTzT2o7xl zLnltSntqBno1bPrJvpCSPtvYCUHPGER7lqc+s65pvmcP6wZs2Vb2TTMwEjDu+xhu1qzcdW 4jYZY4edz4tzu34nhPPqA== X-UI-Out-Filterresults: notjunk:1;V03:K0:yFkd6y7QlR4=:deNoql56lhMJcReKqwH7Ev MDdMYHuVQyhpuiCsl+BskCGf1kIig9PqikmP1jG2gRfURd3vedaM/A0c1bMPZB6iOLaoUNtKc i5+T/an9E/RsnxBH9E0t1ik9gHmIhUyvpnvi7pN8n1AAh1iSCiVNUWEs+enOfmhloqXYdtogd x2hZSHa4Lvi8ks6umwZN2UEbwSw1aodcMo14eWCRtS2nsweMdGjX2UQMJd5WNCQEhkrANR/IS KtXCIuOfsVLifNS0lJCd5pMhdmjrCBQ+bJh57E4Us3OwzzHcdyYtMjabvmwv+x4tYohU6+n1o kdro6gQPdtXA7GCJazaOZNKO/sVSkpOAdgHy1uf/xVzS1qEQh7Cn1QEP3ynMRBZpT0VK8JNPU Hl7WBQTikZR+YSKUl7ytakE/D4YZkX8PFwY1sG/mvGsWamgEhtOxvAFd84q2Oje3BYEJ7Ee28 JwMumYKMpfrxblI6r5Xe7mZoRhvXxrX4TVGZqVwS6yzA9AyhsS7pvj5HIqouhBrupbwy0kQ7y VwwsgFSEoqhZZDJk62cUO6SgzA81ISoxatUcY8FRrM0EuxFdyLcNCRX2639isKZFAYvTK5krj +k1yYSNMfM+oqsLpspEVA4l5IUcJdRUpjpzcz4q8/F0qfDtBk3tTDdWadvExjJ75ajRyps31i zrxnDjIRveIsFxDpPHRSduWcO19Gfg+I6emZmjl12uQQznMBO6UJ9gd67E/ottCH8vsneDEn0 aIPD+S2b/shNHLk766eMD5dy7rD8TRXMiflUznIYV7NoTNCM5FVRsPwbO2EST4b1z2VLqCKVL IFuw2cXIqqovho0CcvgRMAhgIfpJRxXlD8aSNetGoaMflDoYWLxikrfE808r5AkFs8oIQyIVz rROUCbcZ8dQWA3qHTcwl0ceWC7oxFWre3eJ/2ZGS2JKcqDUPCsvJPh+XWB01fhbvbXmClbUBz 2RCLuALUG+nwSPYBG5H7uSKO96GOmTyM82DpFW3IsYhUGq1+oGF1xfDM3ZhLY3xtyOssZc5O4 CMOLSGdE+g2Uev/WiNi/eozBso61bIMUk3l/JM9TWYw2XD1F90h5N0Suw0fcDNcFuZdsgCIKe Rc3f7Kh4P+j+jzvGa+kKToWkDLZqe8/DWOnf/UtTMS5bNCo7kioX/e9Os5K7Zj8a5wfDmdUJG eislFRa5Z6ntiyI6AcK7x7lxtPz5nSEaExoSBF67V9lHGIYLv4W12+frxw2K/O/QFeFuHRXqI dWdAaZ56whX4t6K/AKFEcCWILeajOf8OTJkwoCxdQ+3cDVfzmG0AFI8C6xRc= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> From: Markus Elfring >> Date: Fri, 8 Nov 2019 17:50:22 +0100 =E2=80=A6 >> Fixes: f2bbc96e7cfad3891b7bf9bd3e566b9b7ab4553d ("s390/pkey: add CCA AE= S cipher key support") >> Signed-off-by: Markus Elfring > > You were sending this from a different email address. Yes. > Can you use the same for the sender and the signoff? I would prefer to use the other email address (for a while). > Can you also change the subject to indicate the "fix". e.g. something li= ke > > s390/pkey: fix memory leak in error case by using memdup_user() rather t= han open coding Does this change request indicate also a need to split the software update between the discussed two function implementations? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Elfring Date: Mon, 11 Nov 2019 08:11:04 +0000 Subject: Re: [v3] s390/pkey: Use memdup_user() rather than duplicating its implementation Message-Id: List-Id: References: <08422b7e-2071-ee52-049e-c3ac55bc67a9@web.de> <6137855bb4170c438c7436cbdb7dfd21639a8855.camel@perches.com> <833d7d5e-6ede-6bdd-a2cc-2da7f0b03908@de.ibm.com> <1b65bc81-f47a-eefa-f1f4-d5af6a1809c0@web.de> <733b29df-207e-a165-ee80-46be8720c0c4@de.ibm.com> <8f98f9fc-57df-5993-44b5-5ea4c0de7ef9@web.de> <61244676-8ac1-20af-ed94-99e19c1f95d5@web.de> <040f3e18-d97a-fc32-b237-20e7553e1733@de.ibm.com> In-Reply-To: <040f3e18-d97a-fc32-b237-20e7553e1733@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: =?UTF-8?Q?Christian_Borntr=c3=a4ger?= , linux-s390@vger.kernel.org, Harald Freudenberger , Heiko Carstens , Ingo Franzki , Vasily Gorbik , Joe Perches Cc: LKML , kernel-janitors@vger.kernel.org, Kangjie Lu , Navid Emamdoost , Stephen McCamant >> From: Markus Elfring >> Date: Fri, 8 Nov 2019 17:50:22 +0100 =E2=80=A6 >> Fixes: f2bbc96e7cfad3891b7bf9bd3e566b9b7ab4553d ("s390/pkey: add CCA AES= cipher key support") >> Signed-off-by: Markus Elfring > > You were sending this from a different email address. Yes. > Can you use the same for the sender and the signoff? I would prefer to use the other email address (for a while). > Can you also change the subject to indicate the "fix". e.g. something like > > s390/pkey: fix memory leak in error case by using memdup_user() rather th= an open coding Does this change request indicate also a need to split the software update between the discussed two function implementations? Regards, Markus