From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AB8JxZp01QfK21bsVI2BQ4NHIzt7KPdjfOA0tOVdgxKTkKgOgA0t17/OqJeoqK6MvYF5cCe/xiX3 ARC-Seal: i=1; a=rsa-sha256; t=1524734744; cv=none; d=google.com; s=arc-20160816; b=viIjNsUcskeZnTpz5r63aiehRiU1ycRLD/sEzLNy4/h8k16XUmRr7pz9S57gkP+pFI 1wUaCMEUHLW2I54kG5YQvMgHrxZd5eAT1ruAifcRXtkjnDtu7ivHaq3v/UcVTNTcgipP JVTpNjgpbCkWFTEZnRZVD9S11KHTyHRKKsVBic9YkT80dPSKaOznkwXJ58J6KZQEsykG LnWLrn8nluTD7gHq6VRPNY7qJTXZNCsCatc8wP+TsjdsApvdefwmTFRBXyXP+5p/TmtQ QbY5M0M89mvzz5lfwPT9XOr3i5pdtV7CMqR3J7YYOBBc0dUXWGAOZ4fFxiD3WSljkFJd S4nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:content-transfer-encoding:content-language:in-reply-to :mime-version:user-agent:date:from:references:cc:to:subject :arc-authentication-results; bh=vrw6D8BPUqNI5lfd4P5C7cE28+Cm01JyH1e0x5xNKNE=; b=Irngd00R8ojrl34Z9DMKpfVkRw16ZUmF1xFLqjtG3aI5vCeEPT8K3ytU0JABb9KYZ6 7mcZE2D91/a7Feh775ovXln1CMItiAbg68jN/niXkrKhNMrtpCOAC60HYRwAokgfNlCh Hb1mBE9nNccK5QS8FD9atzsQ7LvCHhsyW4jyxx4543MHMJnmXhLDOeTGeT4DKN2lT3WM bGAv/pVFwafVW8iqU9QxxMxYpxzzOj8/YRLCIzHaUVY85kvZ80hYe8i8HAnKiIwJN5IP T8KLL6Xmt47453eeASLl+4IEj9m/gnxOiGzxV5LAjxl1s3pzIVg4KUovGqvLr7f9jjd8 3IaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of andrew.donnellan@au1.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=andrew.donnellan@au1.ibm.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of andrew.donnellan@au1.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=andrew.donnellan@au1.ibm.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Subject: Re: [PATCH v2 3/7] powerpc: use task_pid_nr() for TID allocation To: Sukadev Bhattiprolu Cc: "Alastair D'Silva" , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, mikey@neuling.org, vaibhav@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, malat@debian.org, felix@linux.vnet.ibm.com, pombredanne@nexb.com, sukadev@linux.vnet.ibm.com, npiggin@gmail.com, gregkh@linuxfoundation.org, arnd@arndb.de, fbarrat@linux.vnet.ibm.com, corbet@lwn.net, "Alastair D'Silva" , Christophe Lombard References: <20180417020950.21446-1-alastair@au1.ibm.com> <20180418010810.30937-1-alastair@au1.ibm.com> <20180418010810.30937-4-alastair@au1.ibm.com> <20180424211231.GA25392@us.ibm.com> From: Andrew Donnellan Date: Thu, 26 Apr 2018 19:25:22 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180424211231.GA25392@us.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-AU Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18042609-0012-0000-0000-000005CF43B3 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18042609-0013-0000-0000-0000194C4850 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-26_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1804260091 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1597957550726280592?= X-GMAIL-MSGID: =?utf-8?q?1598800259985755515?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 25/04/18 07:12, Sukadev Bhattiprolu wrote: > Yes. Like with PIDR, was trying to assign TIDR initially to all threads. > But since only a subset of threads need/use TIDR, we can assign the > value later (when set_thread_tidr() is called). So we should be able to > use task_pid_nr() then. OK. Alastair has also confirmed with me that truncating the pid to a u16 should be safe, so therefore: Reviewed-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnellan@au1.ibm.com IBM Australia Limited From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 78DAE7DD32 for ; Thu, 26 Apr 2018 09:25:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754797AbeDZJZs (ORCPT ); Thu, 26 Apr 2018 05:25:48 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:53250 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754765AbeDZJZd (ORCPT ); Thu, 26 Apr 2018 05:25:33 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3Q9PWdB076393 for ; Thu, 26 Apr 2018 05:25:33 -0400 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0a-001b2d01.pphosted.com with ESMTP id 2hkbv18qrg-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 26 Apr 2018 05:25:32 -0400 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 26 Apr 2018 10:25:30 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 26 Apr 2018 10:25:26 +0100 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w3Q9PPuW131490; Thu, 26 Apr 2018 09:25:25 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F3FFCA404D; Thu, 26 Apr 2018 10:17:22 +0100 (BST) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A0D18A4053; Thu, 26 Apr 2018 10:17:22 +0100 (BST) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 26 Apr 2018 10:17:22 +0100 (BST) Received: from [10.61.2.125] (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id D9B4AA00D7; Thu, 26 Apr 2018 19:25:22 +1000 (AEST) Subject: Re: [PATCH v2 3/7] powerpc: use task_pid_nr() for TID allocation To: Sukadev Bhattiprolu Cc: "Alastair D'Silva" , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, mikey@neuling.org, vaibhav@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, malat@debian.org, felix@linux.vnet.ibm.com, pombredanne@nexb.com, sukadev@linux.vnet.ibm.com, npiggin@gmail.com, gregkh@linuxfoundation.org, arnd@arndb.de, fbarrat@linux.vnet.ibm.com, corbet@lwn.net, "Alastair D'Silva" , Christophe Lombard References: <20180417020950.21446-1-alastair@au1.ibm.com> <20180418010810.30937-1-alastair@au1.ibm.com> <20180418010810.30937-4-alastair@au1.ibm.com> <20180424211231.GA25392@us.ibm.com> From: Andrew Donnellan Date: Thu, 26 Apr 2018 19:25:22 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180424211231.GA25392@us.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-AU Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18042609-0012-0000-0000-000005CF43B3 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18042609-0013-0000-0000-0000194C4850 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-26_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1804260091 Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 25/04/18 07:12, Sukadev Bhattiprolu wrote: > Yes. Like with PIDR, was trying to assign TIDR initially to all threads. > But since only a subset of threads need/use TIDR, we can assign the > value later (when set_thread_tidr() is called). So we should be able to > use task_pid_nr() then. OK. Alastair has also confirmed with me that truncating the pid to a u16 should be safe, so therefore: Reviewed-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnellan@au1.ibm.com IBM Australia Limited -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html