From: Hannes Reinecke <hare@suse.de>
To: John Garry <john.garry@huawei.com>,
mdr@sgi.com, jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
bvanassche@acm.org
Subject: Re: [PATCH v2 1/2] scsi: qla1280: Stop using scsi_cmnd.tag
Date: Thu, 19 Aug 2021 12:38:35 +0200 [thread overview]
Message-ID: <c94d7311-f127-d8c0-6f4d-ba1b14f7e0bf@suse.de> (raw)
In-Reply-To: <1629365549-190391-2-git-send-email-john.garry@huawei.com>
On 8/19/21 11:32 AM, John Garry wrote:
> Use scsi_cmd_to_rq(cmd)->tag instead of scsi_cmnd.tag as preference.
>
> Signed-off-by: John Garry <john.garry@huawei.com>
> ---
> drivers/scsi/qla1280.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
> index aec92471c5f2..b4f7d8d7a01c 100644
> --- a/drivers/scsi/qla1280.c
> +++ b/drivers/scsi/qla1280.c
> @@ -3980,7 +3980,7 @@ __qla1280_print_scsi_cmd(struct scsi_cmnd *cmd)
> qla1280_dump_buffer(1, (char *)sg, (cmd->use_sg*sizeof(struct scatterlist)));
> } */
> printk(" tag=%d, transfersize=0x%x \n",
> - cmd->tag, cmd->transfersize);
> + scsi_cmd_to_rq(cmd)->tag, cmd->transfersize);
> printk(" SP=0x%p\n", CMD_SP(cmd));
> printk(" underflow size = 0x%x, direction=0x%x\n",
> cmd->underflow, cmd->sc_data_direction);
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2021-08-19 10:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 9:32 [PATCH v2 0/2] scsi: qla1280: Resolve some compilation issues John Garry
2021-08-19 9:32 ` [PATCH v2 1/2] scsi: qla1280: Stop using scsi_cmnd.tag John Garry
2021-08-19 10:38 ` Hannes Reinecke [this message]
2021-08-19 9:32 ` [PATCH v2 2/2] scsi: qla1280: Fix DEBUG_QLA1280 compilation issues John Garry
2021-08-19 10:39 ` Hannes Reinecke
2021-08-19 18:07 ` Bart Van Assche
2021-08-19 19:24 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c94d7311-f127-d8c0-6f4d-ba1b14f7e0bf@suse.de \
--to=hare@suse.de \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mdr@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.