From: Kever Yang <kever.yang@rock-chips.com>
To: Anand Moon <linux.amoon@gmail.com>, u-boot@lists.denx.de
Cc: Neil Armstrong <narmstrong@baylibre.com>, Bin Meng <bmeng.cn@gmail.com>
Subject: Re: [PATCH 3/3] pci: pcie_dw_rockchip: Use udelay instead of msleep
Date: Fri, 21 May 2021 21:20:51 +0800 [thread overview]
Message-ID: <ca70a66a-e104-2e18-effc-4c168c15abee@rock-chips.com> (raw)
In-Reply-To: <20210426132632.10221-3-linux.amoon@gmail.com>
Hi Anand,
It's OK to update the API, but please keep the delay duration.
Thanks,
- Kever
On 2021/4/26 下午9:26, Anand Moon wrote:
> Use udelay instead of msleep fix the below warning.
>
> drivers/pci/pcie_dw_rockchip.c:254:3: warning: implicit
> declaration of function 'msleep' [-Wimplicit-function-declaration]
>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Kever Yang <kever.yang@rock-chips.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> drivers/pci/pcie_dw_rockchip.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci/pcie_dw_rockchip.c
> index e7f42604ab..6c87ee1ea0 100644
> --- a/drivers/pci/pcie_dw_rockchip.c
> +++ b/drivers/pci/pcie_dw_rockchip.c
> @@ -249,7 +249,7 @@ static int rk_pcie_link_up(struct rk_pcie *priv, u32 cap_speed)
> * some wired devices need much more, such as 600ms.
> * Add a enough delay to cover all cases.
> */
> - msleep(PERST_WAIT_MS);
> + udelay(PERST_WAIT_MS);
> dm_gpio_set_value(&priv->rst_gpio, 1);
> }
>
> @@ -271,12 +271,12 @@ static int rk_pcie_link_up(struct rk_pcie *priv, u32 cap_speed)
> dev_info(priv->dw.dev, "PCIe Linking... LTSSM is 0x%x\n",
> rk_pcie_readl_apb(priv, PCIE_CLIENT_LTSSM_STATUS));
> rk_pcie_debug_dump(priv);
> - msleep(1000);
> + udelay(1000);
> }
>
> dev_err(priv->dw.dev, "PCIe-%d Link Fail\n", dev_seq(priv->dw.dev));
> /* Link maybe in Gen switch recovery but we need to wait more 1s */
> - msleep(1000);
> + udelay(1000);
> return -EIO;
> }
>
> @@ -296,7 +296,7 @@ static int rockchip_pcie_init_port(struct udevice *dev)
> }
> }
>
> - msleep(1000);
> + udelay(1000);
>
> ret = generic_phy_init(&priv->phy);
> if (ret) {
next prev parent reply other threads:[~2021-05-21 13:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 13:26 [PATCH 1/3] pci: pcie_dw_rockchip: Fixed the below compilation error Anand Moon
2021-04-26 13:26 ` [PATCH 2/3] pci: pcie_dw_rockchip: Drop the unused variable warning Anand Moon
2021-05-21 13:21 ` Kever Yang
2021-04-26 13:26 ` [PATCH 3/3] pci: pcie_dw_rockchip: Use udelay instead of msleep Anand Moon
2021-04-26 20:08 ` Patrick Wildt
2021-04-27 5:41 ` Anand Moon
2021-04-27 19:27 ` Patrick Wildt
2021-05-06 18:40 ` Anand Moon
2021-05-21 13:20 ` Kever Yang [this message]
2021-04-26 20:10 ` [PATCH 1/3] pci: pcie_dw_rockchip: Fixed the below compilation error Patrick Wildt
2021-04-27 5:40 ` Anand Moon
2021-05-21 13:21 ` Kever Yang
2021-05-21 16:58 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca70a66a-e104-2e18-effc-4c168c15abee@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=bmeng.cn@gmail.com \
--cc=linux.amoon@gmail.com \
--cc=narmstrong@baylibre.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.