From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>
Subject: Re: [PATCH 05/10] x86/HVM: use unambiguous register names
Date: Tue, 20 Dec 2016 17:39:00 +0000 [thread overview]
Message-ID: <ca737cc0-9aca-2996-6d3f-069cf3e1cd65@citrix.com> (raw)
In-Reply-To: <5859188C020000780012ADC7@prv-mh.provo.novell.com>
On 20/12/2016 10:39, Jan Beulich wrote:
> @@ -3032,16 +3032,16 @@ void hvm_task_switch(
> if ( hvm_set_cr3(tss.cr3, 1) )
> goto out;
>
> - regs->eip = tss.eip;
> - regs->eflags = tss.eflags | 2;
> - regs->eax = tss.eax;
> - regs->ecx = tss.ecx;
> - regs->edx = tss.edx;
> - regs->ebx = tss.ebx;
> - regs->esp = tss.esp;
> - regs->ebp = tss.ebp;
> - regs->esi = tss.esi;
> - regs->edi = tss.edi;
> + regs->rip = tss.eip;
> + regs->rflags = tss.eflags | 2;
As you are modifying this anyway, mind avoiding this opencoding?
~Andrew
> + regs->rax = tss.eax;
> + regs->rcx = tss.ecx;
> + regs->rdx = tss.edx;
> + regs->rbx = tss.ebx;
> + regs->rsp = tss.esp;
> + regs->rbp = tss.ebp;
> + regs->rsi = tss.esi;
> + regs->rdi = tss.edi;
>
> exn_raised = 0;
> if ( hvm_load_segment_selector(x86_seg_es, tss.es, tss.eflags) ||
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-12-20 17:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-20 9:55 [PATCH 00/10] x86: register renaming (part I) Jan Beulich
2016-12-20 10:36 ` [PATCH 01/10] x86/MSR: introduce MSR access split/fold helpers Jan Beulich
2016-12-23 6:17 ` Tian, Kevin
2016-12-26 4:54 ` Suravee Suthikulpanit
2016-12-20 10:36 ` [PATCH 02/10] x86/guest-walk: use unambiguous register names Jan Beulich
2016-12-28 11:18 ` George Dunlap
2016-12-28 13:53 ` Jan Beulich
2016-12-20 10:38 ` [PATCH 03/10] x86/shadow: " Jan Beulich
2016-12-20 11:04 ` Tim Deegan
2016-12-20 10:39 ` [PATCH 04/10] x86/oprofile: " Jan Beulich
2016-12-20 10:39 ` [PATCH 05/10] x86/HVM: " Jan Beulich
2016-12-20 17:39 ` Andrew Cooper [this message]
2016-12-21 15:31 ` Jan Beulich
2016-12-20 10:40 ` [PATCH 06/10] x86/HVMemul: " Jan Beulich
2016-12-20 10:41 ` [PATCH 07/10] x86/SVM: " Jan Beulich
2016-12-26 5:46 ` Suravee Suthikulpanit
2016-12-20 10:42 ` [PATCH 08/10] x86/vm-event: " Jan Beulich
2016-12-20 17:30 ` Tamas K Lengyel
2016-12-22 16:08 ` Razvan Cojocaru
2016-12-20 10:42 ` [PATCH 09/10] x86/traps: " Jan Beulich
2016-12-20 10:43 ` [PATCH 10/10] x86/misc: " Jan Beulich
2016-12-20 17:34 ` [PATCH 00/10] x86: register renaming (part I) Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca737cc0-9aca-2996-6d3f-069cf3e1cd65@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.