From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmJb1-0004VJ-Ub for qemu-devel@nongnu.org; Mon, 28 Aug 2017 08:56:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmJay-0000vQ-2v for qemu-devel@nongnu.org; Mon, 28 Aug 2017 08:56:52 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:44901) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dmJax-0000vA-Qc for qemu-devel@nongnu.org; Mon, 28 Aug 2017 08:56:48 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v7SCsb18081923 for ; Mon, 28 Aug 2017 08:56:46 -0400 Received: from e14.ny.us.ibm.com (e14.ny.us.ibm.com [129.33.205.204]) by mx0a-001b2d01.pphosted.com with ESMTP id 2cmjm7utq8-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 28 Aug 2017 08:56:45 -0400 Received: from localhost by e14.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 28 Aug 2017 08:56:44 -0400 References: <3ed8b810b6592daee6a775037ce21f850e40647d.1503667215.git.alifm@linux.vnet.ibm.com> <20170825160408.2775c8b5.cohuck@redhat.com> <00d41b2b-cf22-c9e2-8d9f-de947f4d3f18@linux.vnet.ibm.com> <20170828102214.7aad9112.cohuck@redhat.com> From: Farhan Ali Date: Mon, 28 Aug 2017 08:56:42 -0400 MIME-Version: 1.0 In-Reply-To: <20170828102214.7aad9112.cohuck@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Message-Id: Subject: Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: qemu-devel@nongnu.org, borntraeger@de.ibm.com, pasic@linux.vnet.ibm.com, farman@linux.vnet.ibm.com, walling@linux.vnet.ibm.com On 08/28/2017 04:22 AM, Cornelia Huck wrote: > On Fri, 25 Aug 2017 11:05:30 -0400 > Farhan Ali wrote: > >> On 08/25/2017 10:04 AM, Cornelia Huck wrote: >>> On Fri, 25 Aug 2017 09:24:46 -0400 >>> Farhan Ali wrote: >>> >>>> The commit 198c0d1f9df8c4 s390x/css: check ccw address validity >>>> exposes an alignment issue in ccw bios. >>>> >>>> According to PoP the CCW must be doubleword aligned. Let's fix >>>> this in the bios. >>>> >>>> Cc: qemu-stable@nongnu.org >>>> Signed-off-by: Farhan Ali >>>> Reviewed-by: Halil Pasic >>>> Reviewed-by: Eric Farman >>>> Acked-by: Christian Borntraeger >>>> --- >>>> pc-bios/s390-ccw/cio.h | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/pc-bios/s390-ccw/cio.h b/pc-bios/s390-ccw/cio.h >>>> index f5b4549..55eaeee 100644 >>>> --- a/pc-bios/s390-ccw/cio.h >>>> +++ b/pc-bios/s390-ccw/cio.h >>>> @@ -133,7 +133,7 @@ struct ccw1 { >>>> __u8 flags; >>>> __u16 count; >>>> __u32 cda; >>>> -} __attribute__ ((packed)); >>>> +} __attribute__ ((packed, aligned(8))); >>>> >>>> #define CCW_FLAG_DC 0x80 >>>> #define CCW_FLAG_CC 0x40 >>> >>> Currently testing. >>> >>> This looks obviously right, but did you figure out what the (probably >>> unrelated) other failure was? >>> >> >> That is still under investigation, for some reason it only fails for an >> LDL DASD and it works for SCSIs and CDL DASD. > > Which are the symptoms of the failure? I'd like to understand this > before I update the (currently working by accident) bios with an > updated version. > > I'll just apply the patch for now. > Well it's seems like the failure for LDL DASD could be a disk setup failure. We tried the test on a different environment with LDL disks and everything worked fine with the patch applied.