From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=9ZhH=DJ=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,
	SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 2BE57C46466
	for <linux-kernel@archiver.kernel.org>; Fri,  2 Oct 2020 22:39:23 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id DFD8720719
	for <linux-kernel@archiver.kernel.org>; Fri,  2 Oct 2020 22:39:22 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="CkmG7p3e"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1725854AbgJBWjW (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Fri, 2 Oct 2020 18:39:22 -0400
Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:10697 "EHLO
        hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725446AbgJBWjV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 2 Oct 2020 18:39:21 -0400
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
        id <B5f77ac0c0001>; Fri, 02 Oct 2020 15:39:08 -0700
Received: from [10.2.58.214] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 2 Oct
 2020 22:39:19 +0000
Subject: Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM
To:     Daniel Vetter <daniel.vetter@ffwll.ch>,
        DRI Development <dri-devel@lists.freedesktop.org>
CC:     LKML <linux-kernel@vger.kernel.org>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= <jglisse@redhat.com>,
        Jan Kara <jack@suse.cz>,
        Dan Williams <dan.j.williams@intel.com>, <linux-mm@kvack.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-samsung-soc@vger.kernel.org>, <linux-media@vger.kernel.org>
References: <20201002175303.390363-1-daniel.vetter@ffwll.ch>
 <20201002175303.390363-2-daniel.vetter@ffwll.ch>
From:   John Hubbard <jhubbard@nvidia.com>
Message-ID: <cb56763e-4fda-a783-03ae-7f749ec55981@nvidia.com>
Date:   Fri, 2 Oct 2020 15:39:18 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20201002175303.390363-2-daniel.vetter@ffwll.ch>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1601678348; bh=qTcrCkJDzdT8SfyK7qNOOJqSlCcdoBOSPBld3HipaxE=;
        h=Subject:To:CC:References:From:Message-ID:Date:User-Agent:
         MIME-Version:In-Reply-To:Content-Type:Content-Language:
         Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy;
        b=CkmG7p3e1gAyMtXXHaHX1wOW1NQeTx5EUso+tbSgFhrSp+8QrJgqKgpGph1U/WlJ9
         qjs7wfNjzCdFazLpm35kI8ryUb4HAhQGO1YhRDZHuawuF1n/XklWptr0Oh+AMQAUjy
         jneLP0a9LWrTfebX3/q5vKRWI7xVqEgLJba7x3/ynwdacCPjlPBn92WcwSu6Cw0YiT
         eKgU9+6RSW0XQZenBoBjewsXMxc+aP2u4J0XqZOj1Y5gz6t/S5sXbW56buv0moU6ab
         JNDEx6uK4fFAQ92xLXRbzenGuHOo4jN8MNmfnLJi/k09pKguinMXh3euJYAOLgkYOa
         zfT3EJXtIkeRQ==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/2/20 10:53 AM, Daniel Vetter wrote:
> For $reasons I've stumbled over this code and I'm not sure the change
> to the new gup functions in 55a650c35fea ("mm/gup: frame_vector:
> convert get_user_pages() --> pin_user_pages()") was entirely correct.
>=20
> This here is used for long term buffers (not just quick I/O) like
> RDMA, and John notes this in his patch. But I thought the rule for
> these is that they need to add FOLL_LONGTERM, which John's patch
> didn't do.

Yep. The earlier gup --> pup conversion patches were intended to not
have any noticeable behavior changes, and FOLL_LONGTERM, with it's
special cases and such, added some risk that I wasn't ready to take
on yet. Also, FOLL_LONGTERM rules are only *recently* getting firmed
up. So there was some doubt at least in my mind, about which sites
should have it.

But now that we're here, I think it's really good that you've brought
this up. It's definitely time to add FOLL_LONGTERM wherever it's missing.

thanks,
--=20
John Hubbard
NVIDIA

>=20
> There is already a dax specific check (added in b7f0554a56f2 ("mm:
> fail get_vaddr_frames() for filesystem-dax mappings")), so this seems
> like the prudent thing to do.
>=20
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: John Hubbard <jhubbard@nvidia.com>
> Cc: J=C3=A9r=C3=B4me Glisse <jglisse@redhat.com>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: linux-mm@kvack.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-samsung-soc@vger.kernel.org
> Cc: linux-media@vger.kernel.org
> ---
> Hi all,
>=20
> I stumbled over this and figured typing this patch can't hurt. Really
> just to maybe learn a few things about how gup/pup is supposed to be
> used (we have a bit of that in drivers/gpu), this here isn't really
> ralated to anything I'm doing.
>=20
> I'm also wondering whether the explicit dax check should be removed,
> since FOLL_LONGTERM should take care of that already.
> -Daniel
> ---
>   mm/frame_vector.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/mm/frame_vector.c b/mm/frame_vector.c
> index 5d34c9047e9c..3507e09cb3ff 100644
> --- a/mm/frame_vector.c
> +++ b/mm/frame_vector.c
> @@ -35,7 +35,7 @@ int get_vaddr_frames(unsigned long start, unsigned int =
nr_frames,
>   {
>   	struct mm_struct *mm =3D current->mm;
>   	struct vm_area_struct *vma;
> -	unsigned int gup_flags =3D FOLL_WRITE | FOLL_FORCE;
> +	unsigned int gup_flags =3D FOLL_WRITE | FOLL_FORCE | FOLL_LONGTERM;
>   	int ret =3D 0;
>   	int err;
>   	int locked;
>=20


From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=k5HD=DJ=lists.infradead.org=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,
	MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 4CEC4C35257
	for <linux-arm-kernel@archiver.kernel.org>; Fri,  2 Oct 2020 22:41:18 +0000 (UTC)
Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPS id D3BC4206C9
	for <linux-arm-kernel@archiver.kernel.org>; Fri,  2 Oct 2020 22:41:17 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SlGWwvnr";
	dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="CkmG7p3e"
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3BC4206C9
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:
	Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive:
	List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:
	References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date:
	Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;
	 bh=mtlEeTRDADKypoqd1Wbfj8rfDK1yYpcW7LeoXRCvH4c=; b=SlGWwvnruf+HV3/i3fwrJvvjP
	qyDbZNhEQBJzYp3U0nVS6D7JERrKC+pqsBARXbrpqbWZs1h5fcXOaRv0KHY/ppHomdP+pPFXmfVga
	osI+RimeOFKyh/NMsezXu6SS0IOsk6WCRfaYVJPIWTqHB69nNNsFqexDNbe1hxqPS2w/0JkZO74RW
	DOxT5/4zmVHntSK6CxXY6iptMg1lTTrfU1LxdPEATiKEtI3kT3FvF8sShBb0+KKCgT/ssRc4ymYrN
	sKzmJDVFR99HqmGA/aPyvWVWhm6jlSQUHXGj5iZKVmkllpJrk45xPQkNorAY1qUU/otMhscfI83Ix
	fgOmvsT6Q==;
Received: from localhost ([::1] helo=merlin.infradead.org)
	by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux))
	id 1kOTi4-00004s-IF; Fri, 02 Oct 2020 22:39:28 +0000
Received: from hqnvemgate26.nvidia.com ([216.228.121.65])
 by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux))
 id 1kOTi1-0008VZ-VS
 for linux-arm-kernel@lists.infradead.org; Fri, 02 Oct 2020 22:39:27 +0000
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by
 hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
 id <B5f77ac0c0001>; Fri, 02 Oct 2020 15:39:08 -0700
Received: from [10.2.58.214] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 2 Oct
 2020 22:39:19 +0000
Subject: Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM
To: Daniel Vetter <daniel.vetter@ffwll.ch>, DRI Development
 <dri-devel@lists.freedesktop.org>
References: <20201002175303.390363-1-daniel.vetter@ffwll.ch>
 <20201002175303.390363-2-daniel.vetter@ffwll.ch>
From: John Hubbard <jhubbard@nvidia.com>
Message-ID: <cb56763e-4fda-a783-03ae-7f749ec55981@nvidia.com>
Date: Fri, 2 Oct 2020 15:39:18 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20201002175303.390363-2-daniel.vetter@ffwll.ch>
Content-Language: en-US
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
 t=1601678348; bh=qTcrCkJDzdT8SfyK7qNOOJqSlCcdoBOSPBld3HipaxE=;
 h=Subject:To:CC:References:From:Message-ID:Date:User-Agent:
 MIME-Version:In-Reply-To:Content-Type:Content-Language:
 Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy;
 b=CkmG7p3e1gAyMtXXHaHX1wOW1NQeTx5EUso+tbSgFhrSp+8QrJgqKgpGph1U/WlJ9
 qjs7wfNjzCdFazLpm35kI8ryUb4HAhQGO1YhRDZHuawuF1n/XklWptr0Oh+AMQAUjy
 jneLP0a9LWrTfebX3/q5vKRWI7xVqEgLJba7x3/ynwdacCPjlPBn92WcwSu6Cw0YiT
 eKgU9+6RSW0XQZenBoBjewsXMxc+aP2u4J0XqZOj1Y5gz6t/S5sXbW56buv0moU6ab
 JNDEx6uK4fFAQ92xLXRbzenGuHOo4jN8MNmfnLJi/k09pKguinMXh3euJYAOLgkYOa
 zfT3EJXtIkeRQ==
X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 
X-CRM114-CacheID: sfid-20201002_183926_108230_B931736F 
X-CRM114-Status: GOOD (  27.99  )
X-BeenThere: linux-arm-kernel@lists.infradead.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <linux-arm-kernel.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, 
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/>
List-Post: <mailto:linux-arm-kernel@lists.infradead.org>
List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, 
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>
Cc: linux-samsung-soc@vger.kernel.org, Jan Kara <jack@suse.cz>,
 LKML <linux-kernel@vger.kernel.org>, linux-mm@kvack.org,
 =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= <jglisse@redhat.com>,
 Daniel Vetter <daniel.vetter@intel.com>,
 Andrew Morton <akpm@linux-foundation.org>,
 Dan Williams <dan.j.williams@intel.com>, linux-arm-kernel@lists.infradead.org,
 linux-media@vger.kernel.org
Content-Transfer-Encoding: base64
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org>
Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org

T24gMTAvMi8yMCAxMDo1MyBBTSwgRGFuaWVsIFZldHRlciB3cm90ZToKPiBGb3IgJHJlYXNvbnMg
SSd2ZSBzdHVtYmxlZCBvdmVyIHRoaXMgY29kZSBhbmQgSSdtIG5vdCBzdXJlIHRoZSBjaGFuZ2UK
PiB0byB0aGUgbmV3IGd1cCBmdW5jdGlvbnMgaW4gNTVhNjUwYzM1ZmVhICgibW0vZ3VwOiBmcmFt
ZV92ZWN0b3I6Cj4gY29udmVydCBnZXRfdXNlcl9wYWdlcygpIC0tPiBwaW5fdXNlcl9wYWdlcygp
Iikgd2FzIGVudGlyZWx5IGNvcnJlY3QuCj4gCj4gVGhpcyBoZXJlIGlzIHVzZWQgZm9yIGxvbmcg
dGVybSBidWZmZXJzIChub3QganVzdCBxdWljayBJL08pIGxpa2UKPiBSRE1BLCBhbmQgSm9obiBu
b3RlcyB0aGlzIGluIGhpcyBwYXRjaC4gQnV0IEkgdGhvdWdodCB0aGUgcnVsZSBmb3IKPiB0aGVz
ZSBpcyB0aGF0IHRoZXkgbmVlZCB0byBhZGQgRk9MTF9MT05HVEVSTSwgd2hpY2ggSm9obidzIHBh
dGNoCj4gZGlkbid0IGRvLgoKWWVwLiBUaGUgZWFybGllciBndXAgLS0+IHB1cCBjb252ZXJzaW9u
IHBhdGNoZXMgd2VyZSBpbnRlbmRlZCB0byBub3QKaGF2ZSBhbnkgbm90aWNlYWJsZSBiZWhhdmlv
ciBjaGFuZ2VzLCBhbmQgRk9MTF9MT05HVEVSTSwgd2l0aCBpdCdzCnNwZWNpYWwgY2FzZXMgYW5k
IHN1Y2gsIGFkZGVkIHNvbWUgcmlzayB0aGF0IEkgd2Fzbid0IHJlYWR5IHRvIHRha2UKb24geWV0
LiBBbHNvLCBGT0xMX0xPTkdURVJNIHJ1bGVzIGFyZSBvbmx5ICpyZWNlbnRseSogZ2V0dGluZyBm
aXJtZWQKdXAuIFNvIHRoZXJlIHdhcyBzb21lIGRvdWJ0IGF0IGxlYXN0IGluIG15IG1pbmQsIGFi
b3V0IHdoaWNoIHNpdGVzCnNob3VsZCBoYXZlIGl0LgoKQnV0IG5vdyB0aGF0IHdlJ3JlIGhlcmUs
IEkgdGhpbmsgaXQncyByZWFsbHkgZ29vZCB0aGF0IHlvdSd2ZSBicm91Z2h0CnRoaXMgdXAuIEl0
J3MgZGVmaW5pdGVseSB0aW1lIHRvIGFkZCBGT0xMX0xPTkdURVJNIHdoZXJldmVyIGl0J3MgbWlz
c2luZy4KCnRoYW5rcywKLS0gCkpvaG4gSHViYmFyZApOVklESUEKCj4gCj4gVGhlcmUgaXMgYWxy
ZWFkeSBhIGRheCBzcGVjaWZpYyBjaGVjayAoYWRkZWQgaW4gYjdmMDU1NGE1NmYyICgibW06Cj4g
ZmFpbCBnZXRfdmFkZHJfZnJhbWVzKCkgZm9yIGZpbGVzeXN0ZW0tZGF4IG1hcHBpbmdzIikpLCBz
byB0aGlzIHNlZW1zCj4gbGlrZSB0aGUgcHJ1ZGVudCB0aGluZyB0byBkby4KPiAKPiBTaWduZWQt
b2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KPiBDYzogQW5k
cmV3IE1vcnRvbiA8YWtwbUBsaW51eC1mb3VuZGF0aW9uLm9yZz4KPiBDYzogSm9obiBIdWJiYXJk
IDxqaHViYmFyZEBudmlkaWEuY29tPgo+IENjOiBKw6lyw7RtZSBHbGlzc2UgPGpnbGlzc2VAcmVk
aGF0LmNvbT4KPiBDYzogSmFuIEthcmEgPGphY2tAc3VzZS5jej4KPiBDYzogRGFuIFdpbGxpYW1z
IDxkYW4uai53aWxsaWFtc0BpbnRlbC5jb20+Cj4gQ2M6IGxpbnV4LW1tQGt2YWNrLm9yZwo+IENj
OiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKPiBDYzogbGludXgtc2Ftc3Vu
Zy1zb2NAdmdlci5rZXJuZWwub3JnCj4gQ2M6IGxpbnV4LW1lZGlhQHZnZXIua2VybmVsLm9yZwo+
IC0tLQo+IEhpIGFsbCwKPiAKPiBJIHN0dW1ibGVkIG92ZXIgdGhpcyBhbmQgZmlndXJlZCB0eXBp
bmcgdGhpcyBwYXRjaCBjYW4ndCBodXJ0LiBSZWFsbHkKPiBqdXN0IHRvIG1heWJlIGxlYXJuIGEg
ZmV3IHRoaW5ncyBhYm91dCBob3cgZ3VwL3B1cCBpcyBzdXBwb3NlZCB0byBiZQo+IHVzZWQgKHdl
IGhhdmUgYSBiaXQgb2YgdGhhdCBpbiBkcml2ZXJzL2dwdSksIHRoaXMgaGVyZSBpc24ndCByZWFs
bHkKPiByYWxhdGVkIHRvIGFueXRoaW5nIEknbSBkb2luZy4KPiAKPiBJJ20gYWxzbyB3b25kZXJp
bmcgd2hldGhlciB0aGUgZXhwbGljaXQgZGF4IGNoZWNrIHNob3VsZCBiZSByZW1vdmVkLAo+IHNp
bmNlIEZPTExfTE9OR1RFUk0gc2hvdWxkIHRha2UgY2FyZSBvZiB0aGF0IGFscmVhZHkuCj4gLURh
bmllbAo+IC0tLQo+ICAgbW0vZnJhbWVfdmVjdG9yLmMgfCAyICstCj4gICAxIGZpbGUgY2hhbmdl
ZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvbW0vZnJh
bWVfdmVjdG9yLmMgYi9tbS9mcmFtZV92ZWN0b3IuYwo+IGluZGV4IDVkMzRjOTA0N2U5Yy4uMzUw
N2UwOWNiM2ZmIDEwMDY0NAo+IC0tLSBhL21tL2ZyYW1lX3ZlY3Rvci5jCj4gKysrIGIvbW0vZnJh
bWVfdmVjdG9yLmMKPiBAQCAtMzUsNyArMzUsNyBAQCBpbnQgZ2V0X3ZhZGRyX2ZyYW1lcyh1bnNp
Z25lZCBsb25nIHN0YXJ0LCB1bnNpZ25lZCBpbnQgbnJfZnJhbWVzLAo+ICAgewo+ICAgCXN0cnVj
dCBtbV9zdHJ1Y3QgKm1tID0gY3VycmVudC0+bW07Cj4gICAJc3RydWN0IHZtX2FyZWFfc3RydWN0
ICp2bWE7Cj4gLQl1bnNpZ25lZCBpbnQgZ3VwX2ZsYWdzID0gRk9MTF9XUklURSB8IEZPTExfRk9S
Q0U7Cj4gKwl1bnNpZ25lZCBpbnQgZ3VwX2ZsYWdzID0gRk9MTF9XUklURSB8IEZPTExfRk9SQ0Ug
fCBGT0xMX0xPTkdURVJNOwo+ICAgCWludCByZXQgPSAwOwo+ICAgCWludCBlcnI7Cj4gICAJaW50
IGxvY2tlZDsKPiAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3Rz
LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m
by9saW51eC1hcm0ta2VybmVsCg==

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=HfnW=DJ=lists.freedesktop.org=dri-devel-bounces@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_INVALID,
	DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,
	NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,
	USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A915BC35257
	for <dri-devel@archiver.kernel.org>; Fri,  2 Oct 2020 22:39:24 +0000 (UTC)
Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPS id 376B6206C9
	for <dri-devel@archiver.kernel.org>; Fri,  2 Oct 2020 22:39:24 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="CkmG7p3e"
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 376B6206C9
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org
Received: from gabe.freedesktop.org (localhost [127.0.0.1])
	by gabe.freedesktop.org (Postfix) with ESMTP id 82DE16E03D;
	Fri,  2 Oct 2020 22:39:23 +0000 (UTC)
Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com
 [216.228.121.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id CC2406E03D
 for <dri-devel@lists.freedesktop.org>; Fri,  2 Oct 2020 22:39:22 +0000 (UTC)
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by
 hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
 id <B5f77ac0c0001>; Fri, 02 Oct 2020 15:39:08 -0700
Received: from [10.2.58.214] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 2 Oct
 2020 22:39:19 +0000
Subject: Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM
To: Daniel Vetter <daniel.vetter@ffwll.ch>, DRI Development
 <dri-devel@lists.freedesktop.org>
References: <20201002175303.390363-1-daniel.vetter@ffwll.ch>
 <20201002175303.390363-2-daniel.vetter@ffwll.ch>
From: John Hubbard <jhubbard@nvidia.com>
Message-ID: <cb56763e-4fda-a783-03ae-7f749ec55981@nvidia.com>
Date: Fri, 2 Oct 2020 15:39:18 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20201002175303.390363-2-daniel.vetter@ffwll.ch>
Content-Language: en-US
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
 t=1601678348; bh=qTcrCkJDzdT8SfyK7qNOOJqSlCcdoBOSPBld3HipaxE=;
 h=Subject:To:CC:References:From:Message-ID:Date:User-Agent:
 MIME-Version:In-Reply-To:Content-Type:Content-Language:
 Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy;
 b=CkmG7p3e1gAyMtXXHaHX1wOW1NQeTx5EUso+tbSgFhrSp+8QrJgqKgpGph1U/WlJ9
 qjs7wfNjzCdFazLpm35kI8ryUb4HAhQGO1YhRDZHuawuF1n/XklWptr0Oh+AMQAUjy
 jneLP0a9LWrTfebX3/q5vKRWI7xVqEgLJba7x3/ynwdacCPjlPBn92WcwSu6Cw0YiT
 eKgU9+6RSW0XQZenBoBjewsXMxc+aP2u4J0XqZOj1Y5gz6t/S5sXbW56buv0moU6ab
 JNDEx6uK4fFAQ92xLXRbzenGuHOo4jN8MNmfnLJi/k09pKguinMXh3euJYAOLgkYOa
 zfT3EJXtIkeRQ==
X-BeenThere: dri-devel@lists.freedesktop.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Direct Rendering Infrastructure - Development
 <dri-devel.lists.freedesktop.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Cc: linux-samsung-soc@vger.kernel.org, Jan Kara <jack@suse.cz>,
 LKML <linux-kernel@vger.kernel.org>, linux-mm@kvack.org,
 =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= <jglisse@redhat.com>,
 Daniel Vetter <daniel.vetter@intel.com>,
 Andrew Morton <akpm@linux-foundation.org>,
 Dan Williams <dan.j.williams@intel.com>, linux-arm-kernel@lists.infradead.org,
 linux-media@vger.kernel.org
Content-Transfer-Encoding: base64
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>

T24gMTAvMi8yMCAxMDo1MyBBTSwgRGFuaWVsIFZldHRlciB3cm90ZToKPiBGb3IgJHJlYXNvbnMg
SSd2ZSBzdHVtYmxlZCBvdmVyIHRoaXMgY29kZSBhbmQgSSdtIG5vdCBzdXJlIHRoZSBjaGFuZ2UK
PiB0byB0aGUgbmV3IGd1cCBmdW5jdGlvbnMgaW4gNTVhNjUwYzM1ZmVhICgibW0vZ3VwOiBmcmFt
ZV92ZWN0b3I6Cj4gY29udmVydCBnZXRfdXNlcl9wYWdlcygpIC0tPiBwaW5fdXNlcl9wYWdlcygp
Iikgd2FzIGVudGlyZWx5IGNvcnJlY3QuCj4gCj4gVGhpcyBoZXJlIGlzIHVzZWQgZm9yIGxvbmcg
dGVybSBidWZmZXJzIChub3QganVzdCBxdWljayBJL08pIGxpa2UKPiBSRE1BLCBhbmQgSm9obiBu
b3RlcyB0aGlzIGluIGhpcyBwYXRjaC4gQnV0IEkgdGhvdWdodCB0aGUgcnVsZSBmb3IKPiB0aGVz
ZSBpcyB0aGF0IHRoZXkgbmVlZCB0byBhZGQgRk9MTF9MT05HVEVSTSwgd2hpY2ggSm9obidzIHBh
dGNoCj4gZGlkbid0IGRvLgoKWWVwLiBUaGUgZWFybGllciBndXAgLS0+IHB1cCBjb252ZXJzaW9u
IHBhdGNoZXMgd2VyZSBpbnRlbmRlZCB0byBub3QKaGF2ZSBhbnkgbm90aWNlYWJsZSBiZWhhdmlv
ciBjaGFuZ2VzLCBhbmQgRk9MTF9MT05HVEVSTSwgd2l0aCBpdCdzCnNwZWNpYWwgY2FzZXMgYW5k
IHN1Y2gsIGFkZGVkIHNvbWUgcmlzayB0aGF0IEkgd2Fzbid0IHJlYWR5IHRvIHRha2UKb24geWV0
LiBBbHNvLCBGT0xMX0xPTkdURVJNIHJ1bGVzIGFyZSBvbmx5ICpyZWNlbnRseSogZ2V0dGluZyBm
aXJtZWQKdXAuIFNvIHRoZXJlIHdhcyBzb21lIGRvdWJ0IGF0IGxlYXN0IGluIG15IG1pbmQsIGFi
b3V0IHdoaWNoIHNpdGVzCnNob3VsZCBoYXZlIGl0LgoKQnV0IG5vdyB0aGF0IHdlJ3JlIGhlcmUs
IEkgdGhpbmsgaXQncyByZWFsbHkgZ29vZCB0aGF0IHlvdSd2ZSBicm91Z2h0CnRoaXMgdXAuIEl0
J3MgZGVmaW5pdGVseSB0aW1lIHRvIGFkZCBGT0xMX0xPTkdURVJNIHdoZXJldmVyIGl0J3MgbWlz
c2luZy4KCnRoYW5rcywKLS0gCkpvaG4gSHViYmFyZApOVklESUEKCj4gCj4gVGhlcmUgaXMgYWxy
ZWFkeSBhIGRheCBzcGVjaWZpYyBjaGVjayAoYWRkZWQgaW4gYjdmMDU1NGE1NmYyICgibW06Cj4g
ZmFpbCBnZXRfdmFkZHJfZnJhbWVzKCkgZm9yIGZpbGVzeXN0ZW0tZGF4IG1hcHBpbmdzIikpLCBz
byB0aGlzIHNlZW1zCj4gbGlrZSB0aGUgcHJ1ZGVudCB0aGluZyB0byBkby4KPiAKPiBTaWduZWQt
b2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KPiBDYzogQW5k
cmV3IE1vcnRvbiA8YWtwbUBsaW51eC1mb3VuZGF0aW9uLm9yZz4KPiBDYzogSm9obiBIdWJiYXJk
IDxqaHViYmFyZEBudmlkaWEuY29tPgo+IENjOiBKw6lyw7RtZSBHbGlzc2UgPGpnbGlzc2VAcmVk
aGF0LmNvbT4KPiBDYzogSmFuIEthcmEgPGphY2tAc3VzZS5jej4KPiBDYzogRGFuIFdpbGxpYW1z
IDxkYW4uai53aWxsaWFtc0BpbnRlbC5jb20+Cj4gQ2M6IGxpbnV4LW1tQGt2YWNrLm9yZwo+IENj
OiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKPiBDYzogbGludXgtc2Ftc3Vu
Zy1zb2NAdmdlci5rZXJuZWwub3JnCj4gQ2M6IGxpbnV4LW1lZGlhQHZnZXIua2VybmVsLm9yZwo+
IC0tLQo+IEhpIGFsbCwKPiAKPiBJIHN0dW1ibGVkIG92ZXIgdGhpcyBhbmQgZmlndXJlZCB0eXBp
bmcgdGhpcyBwYXRjaCBjYW4ndCBodXJ0LiBSZWFsbHkKPiBqdXN0IHRvIG1heWJlIGxlYXJuIGEg
ZmV3IHRoaW5ncyBhYm91dCBob3cgZ3VwL3B1cCBpcyBzdXBwb3NlZCB0byBiZQo+IHVzZWQgKHdl
IGhhdmUgYSBiaXQgb2YgdGhhdCBpbiBkcml2ZXJzL2dwdSksIHRoaXMgaGVyZSBpc24ndCByZWFs
bHkKPiByYWxhdGVkIHRvIGFueXRoaW5nIEknbSBkb2luZy4KPiAKPiBJJ20gYWxzbyB3b25kZXJp
bmcgd2hldGhlciB0aGUgZXhwbGljaXQgZGF4IGNoZWNrIHNob3VsZCBiZSByZW1vdmVkLAo+IHNp
bmNlIEZPTExfTE9OR1RFUk0gc2hvdWxkIHRha2UgY2FyZSBvZiB0aGF0IGFscmVhZHkuCj4gLURh
bmllbAo+IC0tLQo+ICAgbW0vZnJhbWVfdmVjdG9yLmMgfCAyICstCj4gICAxIGZpbGUgY2hhbmdl
ZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvbW0vZnJh
bWVfdmVjdG9yLmMgYi9tbS9mcmFtZV92ZWN0b3IuYwo+IGluZGV4IDVkMzRjOTA0N2U5Yy4uMzUw
N2UwOWNiM2ZmIDEwMDY0NAo+IC0tLSBhL21tL2ZyYW1lX3ZlY3Rvci5jCj4gKysrIGIvbW0vZnJh
bWVfdmVjdG9yLmMKPiBAQCAtMzUsNyArMzUsNyBAQCBpbnQgZ2V0X3ZhZGRyX2ZyYW1lcyh1bnNp
Z25lZCBsb25nIHN0YXJ0LCB1bnNpZ25lZCBpbnQgbnJfZnJhbWVzLAo+ICAgewo+ICAgCXN0cnVj
dCBtbV9zdHJ1Y3QgKm1tID0gY3VycmVudC0+bW07Cj4gICAJc3RydWN0IHZtX2FyZWFfc3RydWN0
ICp2bWE7Cj4gLQl1bnNpZ25lZCBpbnQgZ3VwX2ZsYWdzID0gRk9MTF9XUklURSB8IEZPTExfRk9S
Q0U7Cj4gKwl1bnNpZ25lZCBpbnQgZ3VwX2ZsYWdzID0gRk9MTF9XUklURSB8IEZPTExfRk9SQ0Ug
fCBGT0xMX0xPTkdURVJNOwo+ICAgCWludCByZXQgPSAwOwo+ICAgCWludCBlcnI7Cj4gICAJaW50
IGxvY2tlZDsKPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y
ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl
bAo=