From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58F78C4361B for ; Thu, 3 Dec 2020 17:15:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 043AC207B0 for ; Thu, 3 Dec 2020 17:15:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731494AbgLCRPp (ORCPT ); Thu, 3 Dec 2020 12:15:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726299AbgLCRPo (ORCPT ); Thu, 3 Dec 2020 12:15:44 -0500 Received: from mail-oo1-xc41.google.com (mail-oo1-xc41.google.com [IPv6:2607:f8b0:4864:20::c41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94CE3C061A52 for ; Thu, 3 Dec 2020 09:15:04 -0800 (PST) Received: by mail-oo1-xc41.google.com with SMTP id z13so685338ooa.5 for ; Thu, 03 Dec 2020 09:15:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hXx5nPk6f0nIshK1/z7rNnx3MUbK/8ladJ1lmi1aEHE=; b=U6PJxWj1QGUbxZIRp0BlZ7R0McGRuurWqKShKO8ibIfNSD8nSK0+w3VRezFy/OfnU7 zKyk3OCiYOe+vt9EO1pKDqY5QiAGHIqDXD3mrhGMEnrleD/BqFLmDYlIFQr2fv3erDlj I05ccOWAptQtfwITxUKChl3jnLkz1ihUysfQ6ExQXVkjfnL1JSqoAMJKgU8AlvrKCEcb NrUrGDGTGvSq4a+cHD4C6sZDG4p8Fbi7qCbbLYqW3vC7U44pvk7+s6EbdHlyFUnWgyjL NAOqJiuv8BivNU6BSF7UPXBpyTwNeA6dPSk0rD54Q2o3uQaN4MvHfSjung67cQUKNR5v JWBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hXx5nPk6f0nIshK1/z7rNnx3MUbK/8ladJ1lmi1aEHE=; b=fHLgyy+d+qy6Sn/uEH8L8u7kSdx/jk3BA5DRVbgslDaokIAN5Woq/hB5pnp5nsrIGL 3XMhdOzO9goUcZoQsqAtEmKCxBrSZPNdpUanafPzcyNKn6+/9SWjqk/LEXDe2Y3HJXIa cBI8dH6QCDwO0Wp+v1F1uf6GExAG+R/Uc8IjCO33uUAoXOeSvEh8+e0ewEGxFurHBGLu Ekfbk51ahkkax4vmUOzZ5YK39CmyKyMYdUns/WqJa8zlrclp25YKRbD3vpMmZxX5wNrE zpSwOhbtkYyPcV/A4kw+WoSDM5kkIfH7au8HMy9i003oyj8fTGH9PD8MrTfvjQ1+Y3+u MIfg== X-Gm-Message-State: AOAM532vpPzDteFJP0cPTemrw59Tq5JsgB3ol3QNy6gyi/DI8dMcohGf 6ITkd2IrsdroECCkGqM+Ztdk1MmyqqagWA1N X-Google-Smtp-Source: ABdhPJxnksoLRBZqWW7iNXzEWsoO52JG7O8CRmGa4cunrxEjx1v1+7B4wVXBxhIZLdsCmJYfuvzqjA== X-Received: by 2002:a4a:cf08:: with SMTP id l8mr34254oos.29.1607015703995; Thu, 03 Dec 2020 09:15:03 -0800 (PST) Received: from [172.24.51.127] (168.189-204-159.bestelclientes.com.mx. [189.204.159.168]) by smtp.gmail.com with ESMTPSA id 11sm352188oty.65.2020.12.03.09.15.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Dec 2020 09:15:03 -0800 (PST) Subject: Re: [PATCH 4/9] target/mips: Simplify MSA TCG logic To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Jiaxun Yang , Huacai Chen , kvm@vger.kernel.org, Aleksandar Rikalo , Paolo Bonzini , Aurelien Jarno References: <20201202184415.1434484-1-f4bug@amsat.org> <20201202184415.1434484-5-f4bug@amsat.org> From: Richard Henderson Message-ID: Date: Thu, 3 Dec 2020 11:14:59 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201202184415.1434484-5-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 12/2/20 12:44 PM, Philippe Mathieu-Daudé wrote: > Only decode MSA opcodes if MSA is present (implemented). > > Now than check_msa_access() will only be called if MSA is > present, the only way to have MIPS_HFLAG_MSA unset is if > MSA is disabled (bit CP0C5_MSAEn cleared, see previous > commit). Therefore we can remove the 'reserved instruction' > exception. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.c | 22 ++++++++++------------ > 1 file changed, 10 insertions(+), 12 deletions(-) Reviewed-by: Richard Henderson r~ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87E63C433FE for ; Thu, 3 Dec 2020 17:22:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7AAA207B0 for ; Thu, 3 Dec 2020 17:22:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7AAA207B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kksJJ-0005CH-Oj for qemu-devel@archiver.kernel.org; Thu, 03 Dec 2020 12:22:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kksCC-00072J-Ue for qemu-devel@nongnu.org; Thu, 03 Dec 2020 12:15:09 -0500 Received: from mail-oo1-xc42.google.com ([2607:f8b0:4864:20::c42]:36569) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kksC9-0000pb-9x for qemu-devel@nongnu.org; Thu, 03 Dec 2020 12:15:07 -0500 Received: by mail-oo1-xc42.google.com with SMTP id l20so689283oot.3 for ; Thu, 03 Dec 2020 09:15:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hXx5nPk6f0nIshK1/z7rNnx3MUbK/8ladJ1lmi1aEHE=; b=U6PJxWj1QGUbxZIRp0BlZ7R0McGRuurWqKShKO8ibIfNSD8nSK0+w3VRezFy/OfnU7 zKyk3OCiYOe+vt9EO1pKDqY5QiAGHIqDXD3mrhGMEnrleD/BqFLmDYlIFQr2fv3erDlj I05ccOWAptQtfwITxUKChl3jnLkz1ihUysfQ6ExQXVkjfnL1JSqoAMJKgU8AlvrKCEcb NrUrGDGTGvSq4a+cHD4C6sZDG4p8Fbi7qCbbLYqW3vC7U44pvk7+s6EbdHlyFUnWgyjL NAOqJiuv8BivNU6BSF7UPXBpyTwNeA6dPSk0rD54Q2o3uQaN4MvHfSjung67cQUKNR5v JWBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hXx5nPk6f0nIshK1/z7rNnx3MUbK/8ladJ1lmi1aEHE=; b=Y/7FzpwsnviI6+YiyC1wBobfSmkpdFLvJF94wREjinlqUViRsjmyZdpTS6z5Y4P1oj BHl/l7rmkwcasQjcGjQpgNDqj2zawr4P8sVyrQaNgQDcgRRDtRxkR4u0R7qBFDllpbAJ UB9cqIo1yEaZ8XPBwBqajkpc2xAhOZ9YYUAm3Ironm/rVYxfwW2gXd60a/D4VC9M3B5P 8buZ/uN5gLvh5uNcXuTciQXme6WW+7bv34R4NTJP0xAsoWppmjYsTrk60HpfySr+3GrY mstf49ojFatevy4QUupTxq6lGuP5pnMDmaIA7iJfkGE98qplidR5R1wO2rKO6cI1JKjp 7paQ== X-Gm-Message-State: AOAM533VzgOyHMZ2aVifrt4JJGlZ5QAYSP3S1Dt/Nuq6RtZ5B/0RNNZc hJobLTGNHcdptgBBI1dyvSpZuA== X-Google-Smtp-Source: ABdhPJxnksoLRBZqWW7iNXzEWsoO52JG7O8CRmGa4cunrxEjx1v1+7B4wVXBxhIZLdsCmJYfuvzqjA== X-Received: by 2002:a4a:cf08:: with SMTP id l8mr34254oos.29.1607015703995; Thu, 03 Dec 2020 09:15:03 -0800 (PST) Received: from [172.24.51.127] (168.189-204-159.bestelclientes.com.mx. [189.204.159.168]) by smtp.gmail.com with ESMTPSA id 11sm352188oty.65.2020.12.03.09.15.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Dec 2020 09:15:03 -0800 (PST) Subject: Re: [PATCH 4/9] target/mips: Simplify MSA TCG logic To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20201202184415.1434484-1-f4bug@amsat.org> <20201202184415.1434484-5-f4bug@amsat.org> From: Richard Henderson Message-ID: Date: Thu, 3 Dec 2020 11:14:59 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201202184415.1434484-5-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::c42; envelope-from=richard.henderson@linaro.org; helo=mail-oo1-xc42.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , kvm@vger.kernel.org, Paolo Bonzini , Huacai Chen , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/2/20 12:44 PM, Philippe Mathieu-Daudé wrote: > Only decode MSA opcodes if MSA is present (implemented). > > Now than check_msa_access() will only be called if MSA is > present, the only way to have MIPS_HFLAG_MSA unset is if > MSA is disabled (bit CP0C5_MSAEn cleared, see previous > commit). Therefore we can remove the 'reserved instruction' > exception. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.c | 22 ++++++++++------------ > 1 file changed, 10 insertions(+), 12 deletions(-) Reviewed-by: Richard Henderson r~