From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Pavel Dovgalyuk" <dovgaluk@ispras.ru>
Subject: Re: [PATCH-for-5.1 v2 0/2] stubs: Fix notify-event stub linkage error on MinGW
Date: Tue, 18 Aug 2020 08:37:05 +0200 [thread overview]
Message-ID: <ce101d90-910a-5906-4034-7d3aacbb3dc2@redhat.com> (raw)
In-Reply-To: <20200805085526.9787-1-philmd@redhat.com>
On 05/08/20 10:55, Philippe Mathieu-Daudé wrote:
> 2 trivial patches to fix the link error reported by Thomas:
>
> LINK tests/test-timed-average.exe
> libqemuutil.a(main-loop.o): In function `qemu_notify_event':
> util/main-loop.c:139: multiple definition of `qemu_notify_event'
> tests/test-timed-average.o:/builds/huth/qemu/tests/../stubs/notify-event.c:5: first defined here
> collect2: error: ld returned 1 exit status
> rules.mak:124: recipe for target 'tests/test-timed-average.exe' failed
>
> Philippe Mathieu-Daudé (2):
> exec: Restrict icount to softmmu
> stubs: Remove qemu_notify_event()
>
> include/sysemu/cpus.h | 4 ++++
> exec.c | 4 ----
> softmmu/cpus.c | 7 +++++++
> stubs/cpu-get-icount.c | 2 +-
> stubs/notify-event.c | 6 ------
> stubs/Makefile.objs | 1 -
> 6 files changed, 12 insertions(+), 12 deletions(-)
> delete mode 100644 stubs/notify-event.c
>
Patch 1 will be superseded by Claudio's refactoring. For patch 2 please
respin according to the review.
Paolo
next prev parent reply other threads:[~2020-08-18 6:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 8:55 [PATCH-for-5.1 v2 0/2] stubs: Fix notify-event stub linkage error on MinGW Philippe Mathieu-Daudé
2020-08-05 8:55 ` [PATCH-for-5.1 v2 1/2] exec: Restrict icount to softmmu Philippe Mathieu-Daudé
2020-08-05 8:55 ` [PATCH-for-5.1 v2 2/2] stubs: Remove qemu_notify_event() Philippe Mathieu-Daudé
2020-08-05 9:42 ` Philippe Mathieu-Daudé
2020-08-05 9:59 ` Philippe Mathieu-Daudé
2020-08-05 11:49 ` Thomas Huth
2020-08-18 6:34 ` Paolo Bonzini
2020-08-18 6:37 ` Paolo Bonzini [this message]
2020-08-18 7:09 ` [PATCH-for-5.1 v2 0/2] stubs: Fix notify-event stub linkage error on MinGW Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce101d90-910a-5906-4034-7d3aacbb3dc2@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=dovgaluk@ispras.ru \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.