All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Doug Berger <opendmb@gmail.com>, "David S. Miller" <davem@davemloft.net>
Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 2/3] Revert "net: bcmgenet: soft reset 40nm EPHYs before MAC init"
Date: Tue, 5 Nov 2019 19:45:21 -0800	[thread overview]
Message-ID: <ce7a7c07-dffa-5717-206e-8d6da97b2861@gmail.com> (raw)
In-Reply-To: <1572980846-37707-3-git-send-email-opendmb@gmail.com>



On 11/5/2019 11:07 AM, Doug Berger wrote:
> This reverts commit 1f515486275a08a17a2c806b844cca18f7de5b34.
> 
> This commit improved the chances of the umac resetting cleanly by
> ensuring that the PHY was restored to its normal operation prior
> to resetting the umac. However, there were still cases when the
> PHY might not be driving a Tx clock to the umac during this window
> (e.g. when the PHY detects no link).
> 
> The previous commit now ensures that the unimac receives clocks
> from the MAC during its reset window so this commit is no longer
> needed. This commit also has an unintended negative impact on the
> MDIO performance of the UniMAC MDIO interface because it is used
> before the MDIO interrupts are reenabled, so it should be removed.
> 
> Signed-off-by: Doug Berger <opendmb@gmail.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

  reply	other threads:[~2019-11-06  3:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05 19:07 [PATCH net 0/3] net: bcmgenet: restore internal EPHY support (part 2) Doug Berger
2019-11-05 19:07 ` [PATCH net 1/3] net: bcmgenet: use RGMII loopback for MAC reset Doug Berger
2019-11-05 19:14   ` Scott Branden
2019-11-05 19:27     ` Doug Berger
2019-11-05 19:48       ` Scott Branden
2019-11-06  3:45   ` Florian Fainelli
2019-11-05 19:07 ` [PATCH net 2/3] Revert "net: bcmgenet: soft reset 40nm EPHYs before MAC init" Doug Berger
2019-11-06  3:45   ` Florian Fainelli [this message]
2019-11-05 19:07 ` [PATCH net 3/3] net: bcmgenet: reapply manual settings to the PHY Doug Berger
2019-11-06  3:45   ` Florian Fainelli
2019-11-06 19:05 ` [PATCH net 0/3] net: bcmgenet: restore internal EPHY support (part 2) David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce7a7c07-dffa-5717-206e-8d6da97b2861@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=opendmb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.