Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init

From: Juergen Gross <jgross@suse.com>
To: Borislav Petkov <bp@alien8.de>
Cc: xen-devel@lists.xenproject.org, x86@kernel.org,
	linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init
Date: Tue, 27 Sep 2022 10:57:37 +0200	[thread overview]
Message-ID: <ce8cb1d3-a7d2-7484-26eb-60d3e29fa369@suse.com> (raw)
In-Reply-To: <YzIVfj/lvzQrK15Y@zn.tnic>

[-- Attachment #1.1.1: Type: text/plain, Size: 997 bytes --]

On 26.09.22 23:11, Borislav Petkov wrote:
> On Thu, Sep 08, 2022 at 10:49:12AM +0200, Juergen Gross wrote:
>> -void set_mtrr_aps_delayed_init(void)
>> -{
>> -	if (!cache_generic)
>> -		return;
>> -
>> -	mtrr_aps_delayed_init = true;
>> -}
>> -
> 
> Except that you've removed the accessors and made that bool global.
> Which is less pretty than it was before...
> 

The accessor would now only need to set the bool, while it had at least
some logic before.

TBH I don't see the point of having an accessor which is just setting a
variable to "true". But if you like it better, I can keep it.

Another possibility would be to move the arch_thaw_secondary_cpus_begin()
and arch_thaw_secondary_cpus_end() functions to cacheinfo.c, resulting
in only a single place outside of cacheinfo.c setting the variable (in
theory the arch_thaw_secondary_cpus_*() functions could just be redefined
to the accessor and cache_aps_init(), but this would be rather hacky IMO).

Juergen

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]