From: "Khem Raj" <raj.khem@gmail.com>
To: Alexander Kanavin <alex.kanavin@gmail.com>,
Richard Purdie <richard.purdie@linuxfoundation.org>,
Mark Hatle <mark.hatle@kernel.crashing.org>
Cc: poky@lists.yoctoproject.org,
Yocto-mailing-list <yocto@lists.yoctoproject.org>
Subject: Re: [yocto] [poky] [PATCH] local.conf.sample: disable prelink
Date: Tue, 15 Jun 2021 10:38:10 -0700 [thread overview]
Message-ID: <cf64ed11-ff36-d3db-ff0b-5bda144bd782@gmail.com> (raw)
In-Reply-To: <CANNYZj8S7V5owiS0p3B1fD7n_JpF-OPLApO=e9d+SiPuyFWHZw@mail.gmail.com>
On 6/15/21 8:21 AM, Alexander Kanavin wrote:
>
>
> On Tue, 15 Jun 2021 at 10:55, Alexander Kanavin <alex.kanavin@gmail.com
> <mailto:alex.kanavin@gmail.com>> wrote:
>
> On Tue, 15 Jun 2021 at 10:48, Richard Purdie
> <richard.purdie@linuxfoundation.org
> <mailto:richard.purdie@linuxfoundation.org>> wrote:
>
> I appreciate the desire simply to delete/disable anything that
> causes issues
> but in this case I draw the line and my answer is no. It works
> fine in the
> vast majority of usage.
>
>
> But where are the benchmarks that show it's actually beneficial? And
> commitment from someone to maintain it and address open issues
> (there are more than just this one)?
>
>
> I went ahead and ran some quick benchmarks myself. Specifically:
>
> 1. Running 'free' after things have settled down at boot:
>
> a) without prelink
> core-image-sato-sdk
> total used free shared buff/cache
> available
> Mem: 489352 152104 236284 472 100964
> 323824
> core-image-ptest-fast
> total used free shared buff/cache
> available
> Mem: 1004680 43456 927688 256 33536
> 941156
>
> b) with prelink
> core-image-sato-sdk
> total used free shared buff/cache
> available
> Mem: 489352 153048 235544 468 100760
> 322900
> core-image-ptest-fast
> total used free shared buff/cache
> available
> Mem: 1004680 44444 928128 256 32108
> 940168
>
> 2. Running -c testimage
>
> a) without prelink
> core-image-sato-sdk () - Ran 66 tests in 96.693s
> core-image-sato-sdk () - Ran 66 tests in 96.469s
> core-image-sato-sdk () - Ran 66 tests in 94.994s
> core-image-ptest-fast () - Ran 66 tests in 583.767s
> core-image-ptest-fast () - Ran 66 tests in 576.564s
> core-image-ptest-fast () - Ran 66 tests in 576.797s
>
> b) with prelink
> core-image-sato-sdk () - Ran 66 tests in 96.390s
> core-image-sato-sdk () - Ran 66 tests in 96.615s
> core-image-sato-sdk () - Ran 66 tests in 95.596s
> core-image-ptest-fast () - Ran 66 tests in 576.248s
> core-image-ptest-fast () - Ran 66 tests in 574.618s
> core-image-ptest-fast () - Ran 66 tests in 576.760s
>
I think the advantage is not on high end CPUs but more on less powerful
ones, so perhaps trying it on something like rpi0 or lower would be good
> So the memory usage is actually *better* without prelink. And any timing
> benefits are lost in statistical noise, in these tests at least.
>
> So I do not think it is wrong to question the usefulness of this
> feature. I'd like to hear Mark's take on this, as prelink-cross is
> primarily his work, he's put a lot of effort into it, and I would want
> to know where the benefits are. Note that Red Hat abandoned prelink in
> 2013, and prelink-cross likewise hasn't seen any commits for two years.
>
> Alex
>
>
>
>
next prev parent reply other threads:[~2021-06-15 17:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 8:12 [PATCH] local.conf.sample: disable prelink Alexander Kanavin
2021-06-15 8:48 ` [poky] " Richard Purdie
2021-06-15 8:55 ` Alexander Kanavin
2021-06-15 9:04 ` Richard Purdie
2021-06-15 15:21 ` Alexander Kanavin
2021-06-15 17:38 ` Khem Raj [this message]
2021-06-16 9:11 ` Richard Purdie
2021-06-16 9:45 ` Alexander Kanavin
2021-07-19 20:58 ` [yocto] " Robert Berger
2021-07-22 19:05 ` Alexander Kanavin
2021-07-23 12:51 ` Robert Berger
2021-06-15 17:21 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf64ed11-ff36-d3db-ff0b-5bda144bd782@gmail.com \
--to=raj.khem@gmail.com \
--cc=alex.kanavin@gmail.com \
--cc=mark.hatle@kernel.crashing.org \
--cc=poky@lists.yoctoproject.org \
--cc=richard.purdie@linuxfoundation.org \
--cc=yocto@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.