From: Jonathan Tan <jonathantanmy@google.com>
To: git@vger.kernel.org
Cc: Jonathan Tan <jonathantanmy@google.com>
Subject: [PATCH 0/2] Safer GIT_CURL_VERBOSE
Date: Mon, 11 May 2020 10:43:08 -0700 [thread overview]
Message-ID: <cover.1589218693.git.jonathantanmy@google.com> (raw)
These are patches that unify GIT_CURL_VERBOSE and GIT_TRACE_CURL. This
helps avoid GIT_CURL_VERBOSE being a source of confusion, especially
with the presence of GIT_REDACT_COOKIES. The motivation is further
explained in the commit message of patch 2.
I noticed some commits that refer to GIT_CURL_VERBOSE as deprecated
(see what 930b67ebd7 ("Merge branch 'ep/use-git-trace-curl-in-tests'",
2016-09-12) merged in), although it seems that they are just referring
to the fact that GIT_TRACE_CURL has more features than GIT_CURL_VERBOSE
and should be preferred (74c682d3c6 ("http.c: implement the
GIT_TRACE_CURL environment variable", 2016-05-24)). I haven't made any
references to deprecating anything in any of the commit messages, but
deprecating GIT_CURL_VERBOSE (so that we have only one way of doing
things) seems good to me - but this is a matter for another patch, I
think.
Jonathan Tan (2):
t5551: test that GIT_TRACE_CURL redacts password
http, imap-send: stop using CURLOPT_VERBOSE
Documentation/git.txt | 2 --
http.c | 8 +++++++-
http.h | 7 +++++++
imap-send.c | 2 +-
t/t5551-http-fetch-smart.sh | 36 ++++++++++++++++++++++++++++++++++++
t/t5581-http-curl-verbose.sh | 2 +-
trace.c | 20 ++++++++++++++++----
trace.h | 6 ++++++
8 files changed, 74 insertions(+), 9 deletions(-)
--
2.26.2.645.ge9eca65c58-goog
next reply other threads:[~2020-05-11 17:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 17:43 Jonathan Tan [this message]
2020-05-11 17:43 ` [PATCH 1/2] t5551: test that GIT_TRACE_CURL redacts password Jonathan Tan
2020-05-12 19:08 ` Jeff King
2020-05-11 17:43 ` [PATCH 2/2] http, imap-send: stop using CURLOPT_VERBOSE Jonathan Tan
2020-05-12 19:16 ` Jeff King
2020-05-12 19:23 ` Jonathan Tan
2020-05-12 19:27 ` Jeff King
2020-05-12 23:13 ` brian m. carlson
2020-05-13 0:10 ` Junio C Hamano
2020-05-13 4:50 ` Jeff King
2020-05-13 5:05 ` Junio C Hamano
2020-05-13 6:16 ` Daniel Stenberg
2020-05-13 14:45 ` Jeff King
2020-05-13 19:12 ` [PATCH v2 0/3] Safer GIT_CURL_VERBOSE Jonathan Tan
2020-05-13 19:12 ` [PATCH v2 1/3] t5551: test that GIT_TRACE_CURL redacts password Jonathan Tan
2020-05-13 19:12 ` [PATCH v2 2/3] http: make GIT_TRACE_CURL auth redaction optional Jonathan Tan
2020-05-13 19:29 ` Junio C Hamano
2020-05-13 19:12 ` [PATCH v2 3/3] http, imap-send: stop using CURLOPT_VERBOSE Jonathan Tan
2020-05-13 19:27 ` [PATCH v2 0/3] Safer GIT_CURL_VERBOSE Junio C Hamano
2020-05-13 19:33 ` Junio C Hamano
2020-05-15 20:47 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1589218693.git.jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.