From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A7172F80; Wed, 5 May 2021 09:42:20 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0602D61401; Wed, 5 May 2021 09:42:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620207739; bh=yt06NNHz8DnYKToINWX+kvUyHzX2tR5CxsEbiivgk9Q=; h=From:To:Cc:Subject:Date:From; b=aqDRmaF3drwaIh64M6SmLAXcURg7md3/lxLq6hY7zb9NqADehFDhLwTfZdBs7O+Ua PrWk1xzp0TuIUKCqW49WlvukyoTfR5zgDGz7Uu2PZqSgv1pEGUUxNbyoLUBf8HZnu5 qRdm6t31xE9TWLgGFmfaTYQA8hMkY0ziRes30XuBsRHwKIVlQv7wfSkyxIpDYtEO+h OCd1Y0Rg6YCyxJf0fUjbsEoL8cTStyP6CBORWLMbL183NygQ2Jt0qsW8FwH+QN9AJO UNaAIvqUS7AS4O6rIj0PTrvaAvgGwleAAphalHt9KMZmiBAzijNKMWxdBLmzF/O1Jj VRSlJc4wK+6AA== Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1leE2q-00AHvp-Hf; Wed, 05 May 2021 11:42:16 +0200 From: Mauro Carvalho Chehab To: Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , "Lad, Prabhakar" , "Paul J. Murphy" , Andrzej Pietrasiewicz , Andy Gross , Bjorn Andersson , Chen-Yu Tsai , Daniele Alessandrelli , Ezequiel Garcia , Fabio Estevam , Jacek Anaszewski , Jernej Skrabec , Krzysztof Kozlowski , Marek Szyprowski , Matthias Brugger , Mauro Carvalho Chehab , Maxime Ripard , NXP Linux Team , Pengutronix Kernel Team , Philipp Zabel , Rui Miguel Silva , Sakari Ailus , Sascha Hauer , Shawn Guo , Stanimir Varbanov , Steve Longerbeam , Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev Subject: [PATCH 00/25] Fix some PM runtime issues at the media subsystem Date: Wed, 5 May 2021 11:41:50 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Mauro Carvalho Chehab As part of an effort to cleanup pm_runtime*get* calls, I detected a number of issues at the media subsystem. Most of the patches here were submitted previously at: https://lore.kernel.org/linux-media/cover.1619621413.git.mchehab+huawei@kernel.org/ This series contain just the bug fixes and other related issues that are present with the current code on media. It address the points from the existing reviews. I also did my own set of reviews, in order to avoid regressions. Changes from v4 of the previous changeset: - reworked i2c/css RPM get logic; - dropped two patches that could cause regressions; - am437x: keep using pm_runtime_get_sync on suspend/resume; - atmel: fix the returned code and add a print on failures at start streaming; - simplify some checks for return code > 0; - mdk-vcodec: properly handle RPM errors at device on logic; - venus: rework venus_sys_error_handler() logic; - sti/delta: fix an issue at the error checking logic. Mauro Carvalho Chehab (25): staging: media: rkvdec: fix pm_runtime_get_sync() usage count staging: media: imx7-mipi-csis: fix pm_runtime_get_sync() usage count media: venus: Rework error fail recover logic media: s5p_cec: decrement usage count if disabled media: i2c: ccs-core: return the right error code at suspend media: i2c: imx334: fix the pm runtime get logic media: exynos-gsc: don't resume at remove time media: atmel: properly get pm_runtime media: hantro: do a PM resume earlier media: marvel-ccic: fix some issues when getting pm_runtime media: mdk-mdp: fix pm_runtime_get_sync() usage count media: rcar_fdp1: simplify error check logic at fdp_open() media: rcar_fdp1: fix pm_runtime_get_sync() usage count media: renesas-ceu: Properly check for PM errors media: s5p: fix pm_runtime_get_sync() usage count media: am437x: fix pm_runtime_get_sync() usage count media: sh_vou: fix pm_runtime_get_sync() usage count media: mtk-vcodec: fix PM runtime get logic media: s5p-jpeg: fix pm_runtime_get_sync() usage count media: sti/delta: use pm_runtime_resume_and_get() media: sunxi: fix pm_runtime_get_sync() usage count media: sti/bdisp: fix pm_runtime_get_sync() usage count media: exynos4-is: fix pm_runtime_get_sync() usage count media: exynos-gsc: fix pm_runtime_get_sync() usage count media: i2c: ccs-core: fix pm_runtime_get_sync() usage count drivers/media/cec/platform/s5p/s5p_cec.c | 7 ++- drivers/media/i2c/ccs/ccs-core.c | 41 ++++++++----- drivers/media/i2c/imx334.c | 7 ++- drivers/media/platform/am437x/am437x-vpfe.c | 15 ++++- drivers/media/platform/atmel/atmel-isc-base.c | 30 +++++++--- drivers/media/platform/atmel/atmel-isi.c | 19 ++++-- drivers/media/platform/exynos-gsc/gsc-core.c | 11 ++-- drivers/media/platform/exynos-gsc/gsc-m2m.c | 4 +- .../media/platform/exynos4-is/fimc-capture.c | 6 +- drivers/media/platform/exynos4-is/fimc-is.c | 4 +- .../platform/exynos4-is/fimc-isp-video.c | 3 +- drivers/media/platform/exynos4-is/fimc-isp.c | 7 +-- drivers/media/platform/exynos4-is/fimc-lite.c | 5 +- drivers/media/platform/exynos4-is/fimc-m2m.c | 5 +- drivers/media/platform/exynos4-is/media-dev.c | 9 +-- drivers/media/platform/exynos4-is/mipi-csis.c | 10 ++-- .../media/platform/marvell-ccic/mcam-core.c | 9 ++- drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c | 6 +- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 4 +- .../platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 8 ++- .../platform/mtk-vcodec/mtk_vcodec_dec_pm.h | 2 +- drivers/media/platform/qcom/venus/core.c | 59 +++++++++++++++---- drivers/media/platform/rcar_fdp1.c | 28 ++++++--- drivers/media/platform/renesas-ceu.c | 4 +- drivers/media/platform/s5p-jpeg/jpeg-core.c | 5 +- drivers/media/platform/sh_vou.c | 6 +- drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 7 ++- drivers/media/platform/sti/delta/delta-v4l2.c | 8 +-- .../sunxi/sun8i-rotate/sun8i_rotate.c | 2 +- drivers/staging/media/hantro/hantro_drv.c | 7 ++- drivers/staging/media/imx/imx7-mipi-csis.c | 7 +-- drivers/staging/media/rkvdec/rkvdec.c | 2 +- 32 files changed, 220 insertions(+), 127 deletions(-) -- 2.30.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30DC2C43462 for ; Wed, 5 May 2021 09:42:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02502613FB for ; Wed, 5 May 2021 09:42:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232490AbhEEJnR (ORCPT ); Wed, 5 May 2021 05:43:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:48572 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232242AbhEEJnQ (ORCPT ); Wed, 5 May 2021 05:43:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0602D61401; Wed, 5 May 2021 09:42:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620207739; bh=yt06NNHz8DnYKToINWX+kvUyHzX2tR5CxsEbiivgk9Q=; h=From:To:Cc:Subject:Date:From; b=aqDRmaF3drwaIh64M6SmLAXcURg7md3/lxLq6hY7zb9NqADehFDhLwTfZdBs7O+Ua PrWk1xzp0TuIUKCqW49WlvukyoTfR5zgDGz7Uu2PZqSgv1pEGUUxNbyoLUBf8HZnu5 qRdm6t31xE9TWLgGFmfaTYQA8hMkY0ziRes30XuBsRHwKIVlQv7wfSkyxIpDYtEO+h OCd1Y0Rg6YCyxJf0fUjbsEoL8cTStyP6CBORWLMbL183NygQ2Jt0qsW8FwH+QN9AJO UNaAIvqUS7AS4O6rIj0PTrvaAvgGwleAAphalHt9KMZmiBAzijNKMWxdBLmzF/O1Jj VRSlJc4wK+6AA== Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1leE2q-00AHvp-Hf; Wed, 05 May 2021 11:42:16 +0200 From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , "Lad, Prabhakar" , "Paul J. Murphy" , Andrzej Pietrasiewicz , Andy Gross , Bjorn Andersson , Chen-Yu Tsai , Daniele Alessandrelli , Ezequiel Garcia , Fabio Estevam , Jacek Anaszewski , Jernej Skrabec , Krzysztof Kozlowski , Marek Szyprowski , Matthias Brugger , Mauro Carvalho Chehab , Maxime Ripard , NXP Linux Team , Pengutronix Kernel Team , Philipp Zabel , Rui Miguel Silva , Sakari Ailus , Sascha Hauer , Shawn Guo , Stanimir Varbanov , Steve Longerbeam , Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev Subject: [PATCH 00/25] Fix some PM runtime issues at the media subsystem Date: Wed, 5 May 2021 11:41:50 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org As part of an effort to cleanup pm_runtime*get* calls, I detected a number of issues at the media subsystem. Most of the patches here were submitted previously at: https://lore.kernel.org/linux-media/cover.1619621413.git.mchehab+huawei@kernel.org/ This series contain just the bug fixes and other related issues that are present with the current code on media. It address the points from the existing reviews. I also did my own set of reviews, in order to avoid regressions. Changes from v4 of the previous changeset: - reworked i2c/css RPM get logic; - dropped two patches that could cause regressions; - am437x: keep using pm_runtime_get_sync on suspend/resume; - atmel: fix the returned code and add a print on failures at start streaming; - simplify some checks for return code > 0; - mdk-vcodec: properly handle RPM errors at device on logic; - venus: rework venus_sys_error_handler() logic; - sti/delta: fix an issue at the error checking logic. Mauro Carvalho Chehab (25): staging: media: rkvdec: fix pm_runtime_get_sync() usage count staging: media: imx7-mipi-csis: fix pm_runtime_get_sync() usage count media: venus: Rework error fail recover logic media: s5p_cec: decrement usage count if disabled media: i2c: ccs-core: return the right error code at suspend media: i2c: imx334: fix the pm runtime get logic media: exynos-gsc: don't resume at remove time media: atmel: properly get pm_runtime media: hantro: do a PM resume earlier media: marvel-ccic: fix some issues when getting pm_runtime media: mdk-mdp: fix pm_runtime_get_sync() usage count media: rcar_fdp1: simplify error check logic at fdp_open() media: rcar_fdp1: fix pm_runtime_get_sync() usage count media: renesas-ceu: Properly check for PM errors media: s5p: fix pm_runtime_get_sync() usage count media: am437x: fix pm_runtime_get_sync() usage count media: sh_vou: fix pm_runtime_get_sync() usage count media: mtk-vcodec: fix PM runtime get logic media: s5p-jpeg: fix pm_runtime_get_sync() usage count media: sti/delta: use pm_runtime_resume_and_get() media: sunxi: fix pm_runtime_get_sync() usage count media: sti/bdisp: fix pm_runtime_get_sync() usage count media: exynos4-is: fix pm_runtime_get_sync() usage count media: exynos-gsc: fix pm_runtime_get_sync() usage count media: i2c: ccs-core: fix pm_runtime_get_sync() usage count drivers/media/cec/platform/s5p/s5p_cec.c | 7 ++- drivers/media/i2c/ccs/ccs-core.c | 41 ++++++++----- drivers/media/i2c/imx334.c | 7 ++- drivers/media/platform/am437x/am437x-vpfe.c | 15 ++++- drivers/media/platform/atmel/atmel-isc-base.c | 30 +++++++--- drivers/media/platform/atmel/atmel-isi.c | 19 ++++-- drivers/media/platform/exynos-gsc/gsc-core.c | 11 ++-- drivers/media/platform/exynos-gsc/gsc-m2m.c | 4 +- .../media/platform/exynos4-is/fimc-capture.c | 6 +- drivers/media/platform/exynos4-is/fimc-is.c | 4 +- .../platform/exynos4-is/fimc-isp-video.c | 3 +- drivers/media/platform/exynos4-is/fimc-isp.c | 7 +-- drivers/media/platform/exynos4-is/fimc-lite.c | 5 +- drivers/media/platform/exynos4-is/fimc-m2m.c | 5 +- drivers/media/platform/exynos4-is/media-dev.c | 9 +-- drivers/media/platform/exynos4-is/mipi-csis.c | 10 ++-- .../media/platform/marvell-ccic/mcam-core.c | 9 ++- drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c | 6 +- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 4 +- .../platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 8 ++- .../platform/mtk-vcodec/mtk_vcodec_dec_pm.h | 2 +- drivers/media/platform/qcom/venus/core.c | 59 +++++++++++++++---- drivers/media/platform/rcar_fdp1.c | 28 ++++++--- drivers/media/platform/renesas-ceu.c | 4 +- drivers/media/platform/s5p-jpeg/jpeg-core.c | 5 +- drivers/media/platform/sh_vou.c | 6 +- drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 7 ++- drivers/media/platform/sti/delta/delta-v4l2.c | 8 +-- .../sunxi/sun8i-rotate/sun8i_rotate.c | 2 +- drivers/staging/media/hantro/hantro_drv.c | 7 ++- drivers/staging/media/imx/imx7-mipi-csis.c | 7 +-- drivers/staging/media/rkvdec/rkvdec.c | 2 +- 32 files changed, 220 insertions(+), 127 deletions(-) -- 2.30.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7875C433B4 for ; Wed, 5 May 2021 09:45:47 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31BFB61106 for ; Wed, 5 May 2021 09:45:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31BFB61106 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=hZcXEcxbEI8ONcaTvLikjhdZQpVccoj0IBEfZn32BQU=; b=Sw/Q46onMgEpimLHMpDl5155bT uufttQQpwTMsJclvuC5vOVRHDKbCJTFx1Zsdw8CUD4bzsNsc/RTlbqJOf0591HViuvLS9Qsep6+CW CqDPQjNTToVOYsG7vp0YZG5ytYe1Gi4jjKi2g3UkmywaJIwkCX9LV2cjHNK9tXykcP89I2WW7nIPU vK/yGNfHUlcVRh/nw2J5D/8aG2fMEx1IgkQcH+AHm7qZE5L/5wGnOUVbSvUPw2pkq4QbMs8iXgfB0 O0JWjWx6QbK5VkJgXjszoYlbreAq+oFcvsBvWE3n2h1vdCJEE68NfKQFLvHZIJAFqtjv0TJVsYPSJ yhiMiTJA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leE67-000mLF-A6; Wed, 05 May 2021 09:45:40 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leE2z-000l5o-Es; Wed, 05 May 2021 09:42:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=rszBJj9aV+Fgnfu5GSJRaCm2qYnVL6C1ZOvh5PSg1Z4=; b=q9HNzfdQMGfbpyf5IKXSWVcbkC aipYl57y6gCSYzDFG06VywtdHII1KFDTBPL1gsGuF0NwFOvVTZVpEu9x1lSShb81WyZGdwSDFQp49 KGVm1Gpk/iHg0J97K5kyB3g9IXoditRP0/5QLRZAhtiZMLpYsjSQnfeyqyaVwNafPmsBZu5no8UYh Gy2rR3DyCFGQXu670kGRNHg2SuZFh+wF9GnuBfHrtBu33F8hfgtt95eOShNGzJazhSkrHFJIUxv5K IHYitlPTGE21djgQkGCx9h0WxakLIyWQQ3DVKzRxERd7ehq8YArVRzWcBTGdNrFfLswzAupq/s42+ wnNvieHg==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leE2u-004cd1-ML; Wed, 05 May 2021 09:42:24 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0602D61401; Wed, 5 May 2021 09:42:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620207739; bh=yt06NNHz8DnYKToINWX+kvUyHzX2tR5CxsEbiivgk9Q=; h=From:To:Cc:Subject:Date:From; b=aqDRmaF3drwaIh64M6SmLAXcURg7md3/lxLq6hY7zb9NqADehFDhLwTfZdBs7O+Ua PrWk1xzp0TuIUKCqW49WlvukyoTfR5zgDGz7Uu2PZqSgv1pEGUUxNbyoLUBf8HZnu5 qRdm6t31xE9TWLgGFmfaTYQA8hMkY0ziRes30XuBsRHwKIVlQv7wfSkyxIpDYtEO+h OCd1Y0Rg6YCyxJf0fUjbsEoL8cTStyP6CBORWLMbL183NygQ2Jt0qsW8FwH+QN9AJO UNaAIvqUS7AS4O6rIj0PTrvaAvgGwleAAphalHt9KMZmiBAzijNKMWxdBLmzF/O1Jj VRSlJc4wK+6AA== Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1leE2q-00AHvp-Hf; Wed, 05 May 2021 11:42:16 +0200 From: Mauro Carvalho Chehab To: Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , "Lad, Prabhakar" , "Paul J. Murphy" , Andrzej Pietrasiewicz , Andy Gross , Bjorn Andersson , Chen-Yu Tsai , Daniele Alessandrelli , Ezequiel Garcia , Fabio Estevam , Jacek Anaszewski , Jernej Skrabec , Krzysztof Kozlowski , Marek Szyprowski , Matthias Brugger , Mauro Carvalho Chehab , Maxime Ripard , NXP Linux Team , Pengutronix Kernel Team , Philipp Zabel , Rui Miguel Silva , Sakari Ailus , Sascha Hauer , Shawn Guo , Stanimir Varbanov , Steve Longerbeam , Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev Subject: [PATCH 00/25] Fix some PM runtime issues at the media subsystem Date: Wed, 5 May 2021 11:41:50 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_024220_810770_84B06BD4 X-CRM114-Status: GOOD ( 13.31 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org As part of an effort to cleanup pm_runtime*get* calls, I detected a number of issues at the media subsystem. Most of the patches here were submitted previously at: https://lore.kernel.org/linux-media/cover.1619621413.git.mchehab+huawei@kernel.org/ This series contain just the bug fixes and other related issues that are present with the current code on media. It address the points from the existing reviews. I also did my own set of reviews, in order to avoid regressions. Changes from v4 of the previous changeset: - reworked i2c/css RPM get logic; - dropped two patches that could cause regressions; - am437x: keep using pm_runtime_get_sync on suspend/resume; - atmel: fix the returned code and add a print on failures at start streaming; - simplify some checks for return code > 0; - mdk-vcodec: properly handle RPM errors at device on logic; - venus: rework venus_sys_error_handler() logic; - sti/delta: fix an issue at the error checking logic. Mauro Carvalho Chehab (25): staging: media: rkvdec: fix pm_runtime_get_sync() usage count staging: media: imx7-mipi-csis: fix pm_runtime_get_sync() usage count media: venus: Rework error fail recover logic media: s5p_cec: decrement usage count if disabled media: i2c: ccs-core: return the right error code at suspend media: i2c: imx334: fix the pm runtime get logic media: exynos-gsc: don't resume at remove time media: atmel: properly get pm_runtime media: hantro: do a PM resume earlier media: marvel-ccic: fix some issues when getting pm_runtime media: mdk-mdp: fix pm_runtime_get_sync() usage count media: rcar_fdp1: simplify error check logic at fdp_open() media: rcar_fdp1: fix pm_runtime_get_sync() usage count media: renesas-ceu: Properly check for PM errors media: s5p: fix pm_runtime_get_sync() usage count media: am437x: fix pm_runtime_get_sync() usage count media: sh_vou: fix pm_runtime_get_sync() usage count media: mtk-vcodec: fix PM runtime get logic media: s5p-jpeg: fix pm_runtime_get_sync() usage count media: sti/delta: use pm_runtime_resume_and_get() media: sunxi: fix pm_runtime_get_sync() usage count media: sti/bdisp: fix pm_runtime_get_sync() usage count media: exynos4-is: fix pm_runtime_get_sync() usage count media: exynos-gsc: fix pm_runtime_get_sync() usage count media: i2c: ccs-core: fix pm_runtime_get_sync() usage count drivers/media/cec/platform/s5p/s5p_cec.c | 7 ++- drivers/media/i2c/ccs/ccs-core.c | 41 ++++++++----- drivers/media/i2c/imx334.c | 7 ++- drivers/media/platform/am437x/am437x-vpfe.c | 15 ++++- drivers/media/platform/atmel/atmel-isc-base.c | 30 +++++++--- drivers/media/platform/atmel/atmel-isi.c | 19 ++++-- drivers/media/platform/exynos-gsc/gsc-core.c | 11 ++-- drivers/media/platform/exynos-gsc/gsc-m2m.c | 4 +- .../media/platform/exynos4-is/fimc-capture.c | 6 +- drivers/media/platform/exynos4-is/fimc-is.c | 4 +- .../platform/exynos4-is/fimc-isp-video.c | 3 +- drivers/media/platform/exynos4-is/fimc-isp.c | 7 +-- drivers/media/platform/exynos4-is/fimc-lite.c | 5 +- drivers/media/platform/exynos4-is/fimc-m2m.c | 5 +- drivers/media/platform/exynos4-is/media-dev.c | 9 +-- drivers/media/platform/exynos4-is/mipi-csis.c | 10 ++-- .../media/platform/marvell-ccic/mcam-core.c | 9 ++- drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c | 6 +- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 4 +- .../platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 8 ++- .../platform/mtk-vcodec/mtk_vcodec_dec_pm.h | 2 +- drivers/media/platform/qcom/venus/core.c | 59 +++++++++++++++---- drivers/media/platform/rcar_fdp1.c | 28 ++++++--- drivers/media/platform/renesas-ceu.c | 4 +- drivers/media/platform/s5p-jpeg/jpeg-core.c | 5 +- drivers/media/platform/sh_vou.c | 6 +- drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 7 ++- drivers/media/platform/sti/delta/delta-v4l2.c | 8 +-- .../sunxi/sun8i-rotate/sun8i_rotate.c | 2 +- drivers/staging/media/hantro/hantro_drv.c | 7 ++- drivers/staging/media/imx/imx7-mipi-csis.c | 7 +-- drivers/staging/media/rkvdec/rkvdec.c | 2 +- 32 files changed, 220 insertions(+), 127 deletions(-) -- 2.30.2 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A341DC43460 for ; Wed, 5 May 2021 09:45:48 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 079AE613D6 for ; Wed, 5 May 2021 09:45:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 079AE613D6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=5Hg+LpkGg07hwO4d+cBFs9nnm3o1+go/eQ+xKqmQEmI=; b=mwHWqag+fBxZ/VYyFX1H3+g7gL CETFAqIu5FNJoSaneguhVUKO5X8vwbLdP2IfYd/+BZu4q/RPih2eLR8jJxmlNM5n4lUcnE5+hJoxA AE9UI1K/N416h7cMPog7rwmDdIonpMjvfUEGP9oJOuosve6uvXyoRVTXDyi8Y7l4OTyyukEFhOQzl nSMhLVpRIkNZR0pyF9nVFQaZzqi8y4LOQzqNMNZ6idHmqBs0Xv3PpKxvkgKjJWPUJuEiaX0MOYePC vcf6uY6K/pduyPudyvQxtTjRHzqliluNYEQB+47Cwd9BSPLu/pAEbDR/kD2cYLat6gmLG3ZAR9PCE Bbh+fSsg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leE5x-000mFw-C1; Wed, 05 May 2021 09:45:29 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leE2z-000l5o-Es; Wed, 05 May 2021 09:42:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=rszBJj9aV+Fgnfu5GSJRaCm2qYnVL6C1ZOvh5PSg1Z4=; b=q9HNzfdQMGfbpyf5IKXSWVcbkC aipYl57y6gCSYzDFG06VywtdHII1KFDTBPL1gsGuF0NwFOvVTZVpEu9x1lSShb81WyZGdwSDFQp49 KGVm1Gpk/iHg0J97K5kyB3g9IXoditRP0/5QLRZAhtiZMLpYsjSQnfeyqyaVwNafPmsBZu5no8UYh Gy2rR3DyCFGQXu670kGRNHg2SuZFh+wF9GnuBfHrtBu33F8hfgtt95eOShNGzJazhSkrHFJIUxv5K IHYitlPTGE21djgQkGCx9h0WxakLIyWQQ3DVKzRxERd7ehq8YArVRzWcBTGdNrFfLswzAupq/s42+ wnNvieHg==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leE2u-004cd1-ML; Wed, 05 May 2021 09:42:24 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0602D61401; Wed, 5 May 2021 09:42:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620207739; bh=yt06NNHz8DnYKToINWX+kvUyHzX2tR5CxsEbiivgk9Q=; h=From:To:Cc:Subject:Date:From; b=aqDRmaF3drwaIh64M6SmLAXcURg7md3/lxLq6hY7zb9NqADehFDhLwTfZdBs7O+Ua PrWk1xzp0TuIUKCqW49WlvukyoTfR5zgDGz7Uu2PZqSgv1pEGUUxNbyoLUBf8HZnu5 qRdm6t31xE9TWLgGFmfaTYQA8hMkY0ziRes30XuBsRHwKIVlQv7wfSkyxIpDYtEO+h OCd1Y0Rg6YCyxJf0fUjbsEoL8cTStyP6CBORWLMbL183NygQ2Jt0qsW8FwH+QN9AJO UNaAIvqUS7AS4O6rIj0PTrvaAvgGwleAAphalHt9KMZmiBAzijNKMWxdBLmzF/O1Jj VRSlJc4wK+6AA== Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1leE2q-00AHvp-Hf; Wed, 05 May 2021 11:42:16 +0200 From: Mauro Carvalho Chehab To: Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , "Lad, Prabhakar" , "Paul J. Murphy" , Andrzej Pietrasiewicz , Andy Gross , Bjorn Andersson , Chen-Yu Tsai , Daniele Alessandrelli , Ezequiel Garcia , Fabio Estevam , Jacek Anaszewski , Jernej Skrabec , Krzysztof Kozlowski , Marek Szyprowski , Matthias Brugger , Mauro Carvalho Chehab , Maxime Ripard , NXP Linux Team , Pengutronix Kernel Team , Philipp Zabel , Rui Miguel Silva , Sakari Ailus , Sascha Hauer , Shawn Guo , Stanimir Varbanov , Steve Longerbeam , Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev Subject: [PATCH 00/25] Fix some PM runtime issues at the media subsystem Date: Wed, 5 May 2021 11:41:50 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_024220_810770_84B06BD4 X-CRM114-Status: GOOD ( 13.31 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org As part of an effort to cleanup pm_runtime*get* calls, I detected a number of issues at the media subsystem. Most of the patches here were submitted previously at: https://lore.kernel.org/linux-media/cover.1619621413.git.mchehab+huawei@kernel.org/ This series contain just the bug fixes and other related issues that are present with the current code on media. It address the points from the existing reviews. I also did my own set of reviews, in order to avoid regressions. Changes from v4 of the previous changeset: - reworked i2c/css RPM get logic; - dropped two patches that could cause regressions; - am437x: keep using pm_runtime_get_sync on suspend/resume; - atmel: fix the returned code and add a print on failures at start streaming; - simplify some checks for return code > 0; - mdk-vcodec: properly handle RPM errors at device on logic; - venus: rework venus_sys_error_handler() logic; - sti/delta: fix an issue at the error checking logic. Mauro Carvalho Chehab (25): staging: media: rkvdec: fix pm_runtime_get_sync() usage count staging: media: imx7-mipi-csis: fix pm_runtime_get_sync() usage count media: venus: Rework error fail recover logic media: s5p_cec: decrement usage count if disabled media: i2c: ccs-core: return the right error code at suspend media: i2c: imx334: fix the pm runtime get logic media: exynos-gsc: don't resume at remove time media: atmel: properly get pm_runtime media: hantro: do a PM resume earlier media: marvel-ccic: fix some issues when getting pm_runtime media: mdk-mdp: fix pm_runtime_get_sync() usage count media: rcar_fdp1: simplify error check logic at fdp_open() media: rcar_fdp1: fix pm_runtime_get_sync() usage count media: renesas-ceu: Properly check for PM errors media: s5p: fix pm_runtime_get_sync() usage count media: am437x: fix pm_runtime_get_sync() usage count media: sh_vou: fix pm_runtime_get_sync() usage count media: mtk-vcodec: fix PM runtime get logic media: s5p-jpeg: fix pm_runtime_get_sync() usage count media: sti/delta: use pm_runtime_resume_and_get() media: sunxi: fix pm_runtime_get_sync() usage count media: sti/bdisp: fix pm_runtime_get_sync() usage count media: exynos4-is: fix pm_runtime_get_sync() usage count media: exynos-gsc: fix pm_runtime_get_sync() usage count media: i2c: ccs-core: fix pm_runtime_get_sync() usage count drivers/media/cec/platform/s5p/s5p_cec.c | 7 ++- drivers/media/i2c/ccs/ccs-core.c | 41 ++++++++----- drivers/media/i2c/imx334.c | 7 ++- drivers/media/platform/am437x/am437x-vpfe.c | 15 ++++- drivers/media/platform/atmel/atmel-isc-base.c | 30 +++++++--- drivers/media/platform/atmel/atmel-isi.c | 19 ++++-- drivers/media/platform/exynos-gsc/gsc-core.c | 11 ++-- drivers/media/platform/exynos-gsc/gsc-m2m.c | 4 +- .../media/platform/exynos4-is/fimc-capture.c | 6 +- drivers/media/platform/exynos4-is/fimc-is.c | 4 +- .../platform/exynos4-is/fimc-isp-video.c | 3 +- drivers/media/platform/exynos4-is/fimc-isp.c | 7 +-- drivers/media/platform/exynos4-is/fimc-lite.c | 5 +- drivers/media/platform/exynos4-is/fimc-m2m.c | 5 +- drivers/media/platform/exynos4-is/media-dev.c | 9 +-- drivers/media/platform/exynos4-is/mipi-csis.c | 10 ++-- .../media/platform/marvell-ccic/mcam-core.c | 9 ++- drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c | 6 +- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 4 +- .../platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 8 ++- .../platform/mtk-vcodec/mtk_vcodec_dec_pm.h | 2 +- drivers/media/platform/qcom/venus/core.c | 59 +++++++++++++++---- drivers/media/platform/rcar_fdp1.c | 28 ++++++--- drivers/media/platform/renesas-ceu.c | 4 +- drivers/media/platform/s5p-jpeg/jpeg-core.c | 5 +- drivers/media/platform/sh_vou.c | 6 +- drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 7 ++- drivers/media/platform/sti/delta/delta-v4l2.c | 8 +-- .../sunxi/sun8i-rotate/sun8i_rotate.c | 2 +- drivers/staging/media/hantro/hantro_drv.c | 7 ++- drivers/staging/media/imx/imx7-mipi-csis.c | 7 +-- drivers/staging/media/rkvdec/rkvdec.c | 2 +- 32 files changed, 220 insertions(+), 127 deletions(-) -- 2.30.2 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AE78C433B4 for ; Wed, 5 May 2021 09:45:35 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00FF8613EC for ; Wed, 5 May 2021 09:45:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00FF8613EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=4x/4ca1qsR9YtSTVnplQfPdpoXzuHhrfuWWpRdxk79w=; b=IrpxT4E0Rrlb8HD8evbl/u7dX0 CRpVb814jJJVOztN7+6fVzUCXfdKSaVfnRvMX8lyJnxYh1bNcBL4MfI6Nhdim+1IEFuKKBL1DNJLx hvGcoWQ/Ciwk6Bxi7k81pSsrQAGQOFMwr7Py9pJdIxNgwQh2uvt0AMaCVH4XowgEThAweWau6uhn9 QZlXCpMHr8tpr7i/hTwcAzxGpxKW0MlXF0Q/yX2i00rz9WJIYdJvEhiG8Pi1VDftaD5YZ5TAtE/Nf o512udknLzK/3Wbcgq2u9WCC5waHRrrlanAvPXR5F6HFSGm+zcz0b21cTe0CSa5mpvKOy/WrIyhs+ 5YU9BRug==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leE4h-000ljf-Ou; Wed, 05 May 2021 09:44:12 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leE2z-000l5o-Es; Wed, 05 May 2021 09:42:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=rszBJj9aV+Fgnfu5GSJRaCm2qYnVL6C1ZOvh5PSg1Z4=; b=q9HNzfdQMGfbpyf5IKXSWVcbkC aipYl57y6gCSYzDFG06VywtdHII1KFDTBPL1gsGuF0NwFOvVTZVpEu9x1lSShb81WyZGdwSDFQp49 KGVm1Gpk/iHg0J97K5kyB3g9IXoditRP0/5QLRZAhtiZMLpYsjSQnfeyqyaVwNafPmsBZu5no8UYh Gy2rR3DyCFGQXu670kGRNHg2SuZFh+wF9GnuBfHrtBu33F8hfgtt95eOShNGzJazhSkrHFJIUxv5K IHYitlPTGE21djgQkGCx9h0WxakLIyWQQ3DVKzRxERd7ehq8YArVRzWcBTGdNrFfLswzAupq/s42+ wnNvieHg==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leE2u-004cd1-ML; Wed, 05 May 2021 09:42:24 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0602D61401; Wed, 5 May 2021 09:42:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620207739; bh=yt06NNHz8DnYKToINWX+kvUyHzX2tR5CxsEbiivgk9Q=; h=From:To:Cc:Subject:Date:From; b=aqDRmaF3drwaIh64M6SmLAXcURg7md3/lxLq6hY7zb9NqADehFDhLwTfZdBs7O+Ua PrWk1xzp0TuIUKCqW49WlvukyoTfR5zgDGz7Uu2PZqSgv1pEGUUxNbyoLUBf8HZnu5 qRdm6t31xE9TWLgGFmfaTYQA8hMkY0ziRes30XuBsRHwKIVlQv7wfSkyxIpDYtEO+h OCd1Y0Rg6YCyxJf0fUjbsEoL8cTStyP6CBORWLMbL183NygQ2Jt0qsW8FwH+QN9AJO UNaAIvqUS7AS4O6rIj0PTrvaAvgGwleAAphalHt9KMZmiBAzijNKMWxdBLmzF/O1Jj VRSlJc4wK+6AA== Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1leE2q-00AHvp-Hf; Wed, 05 May 2021 11:42:16 +0200 From: Mauro Carvalho Chehab To: Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , "Lad, Prabhakar" , "Paul J. Murphy" , Andrzej Pietrasiewicz , Andy Gross , Bjorn Andersson , Chen-Yu Tsai , Daniele Alessandrelli , Ezequiel Garcia , Fabio Estevam , Jacek Anaszewski , Jernej Skrabec , Krzysztof Kozlowski , Marek Szyprowski , Matthias Brugger , Mauro Carvalho Chehab , Maxime Ripard , NXP Linux Team , Pengutronix Kernel Team , Philipp Zabel , Rui Miguel Silva , Sakari Ailus , Sascha Hauer , Shawn Guo , Stanimir Varbanov , Steve Longerbeam , Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev Subject: [PATCH 00/25] Fix some PM runtime issues at the media subsystem Date: Wed, 5 May 2021 11:41:50 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_024220_810770_84B06BD4 X-CRM114-Status: GOOD ( 13.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org As part of an effort to cleanup pm_runtime*get* calls, I detected a number of issues at the media subsystem. Most of the patches here were submitted previously at: https://lore.kernel.org/linux-media/cover.1619621413.git.mchehab+huawei@kernel.org/ This series contain just the bug fixes and other related issues that are present with the current code on media. It address the points from the existing reviews. I also did my own set of reviews, in order to avoid regressions. Changes from v4 of the previous changeset: - reworked i2c/css RPM get logic; - dropped two patches that could cause regressions; - am437x: keep using pm_runtime_get_sync on suspend/resume; - atmel: fix the returned code and add a print on failures at start streaming; - simplify some checks for return code > 0; - mdk-vcodec: properly handle RPM errors at device on logic; - venus: rework venus_sys_error_handler() logic; - sti/delta: fix an issue at the error checking logic. Mauro Carvalho Chehab (25): staging: media: rkvdec: fix pm_runtime_get_sync() usage count staging: media: imx7-mipi-csis: fix pm_runtime_get_sync() usage count media: venus: Rework error fail recover logic media: s5p_cec: decrement usage count if disabled media: i2c: ccs-core: return the right error code at suspend media: i2c: imx334: fix the pm runtime get logic media: exynos-gsc: don't resume at remove time media: atmel: properly get pm_runtime media: hantro: do a PM resume earlier media: marvel-ccic: fix some issues when getting pm_runtime media: mdk-mdp: fix pm_runtime_get_sync() usage count media: rcar_fdp1: simplify error check logic at fdp_open() media: rcar_fdp1: fix pm_runtime_get_sync() usage count media: renesas-ceu: Properly check for PM errors media: s5p: fix pm_runtime_get_sync() usage count media: am437x: fix pm_runtime_get_sync() usage count media: sh_vou: fix pm_runtime_get_sync() usage count media: mtk-vcodec: fix PM runtime get logic media: s5p-jpeg: fix pm_runtime_get_sync() usage count media: sti/delta: use pm_runtime_resume_and_get() media: sunxi: fix pm_runtime_get_sync() usage count media: sti/bdisp: fix pm_runtime_get_sync() usage count media: exynos4-is: fix pm_runtime_get_sync() usage count media: exynos-gsc: fix pm_runtime_get_sync() usage count media: i2c: ccs-core: fix pm_runtime_get_sync() usage count drivers/media/cec/platform/s5p/s5p_cec.c | 7 ++- drivers/media/i2c/ccs/ccs-core.c | 41 ++++++++----- drivers/media/i2c/imx334.c | 7 ++- drivers/media/platform/am437x/am437x-vpfe.c | 15 ++++- drivers/media/platform/atmel/atmel-isc-base.c | 30 +++++++--- drivers/media/platform/atmel/atmel-isi.c | 19 ++++-- drivers/media/platform/exynos-gsc/gsc-core.c | 11 ++-- drivers/media/platform/exynos-gsc/gsc-m2m.c | 4 +- .../media/platform/exynos4-is/fimc-capture.c | 6 +- drivers/media/platform/exynos4-is/fimc-is.c | 4 +- .../platform/exynos4-is/fimc-isp-video.c | 3 +- drivers/media/platform/exynos4-is/fimc-isp.c | 7 +-- drivers/media/platform/exynos4-is/fimc-lite.c | 5 +- drivers/media/platform/exynos4-is/fimc-m2m.c | 5 +- drivers/media/platform/exynos4-is/media-dev.c | 9 +-- drivers/media/platform/exynos4-is/mipi-csis.c | 10 ++-- .../media/platform/marvell-ccic/mcam-core.c | 9 ++- drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c | 6 +- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 4 +- .../platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 8 ++- .../platform/mtk-vcodec/mtk_vcodec_dec_pm.h | 2 +- drivers/media/platform/qcom/venus/core.c | 59 +++++++++++++++---- drivers/media/platform/rcar_fdp1.c | 28 ++++++--- drivers/media/platform/renesas-ceu.c | 4 +- drivers/media/platform/s5p-jpeg/jpeg-core.c | 5 +- drivers/media/platform/sh_vou.c | 6 +- drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 7 ++- drivers/media/platform/sti/delta/delta-v4l2.c | 8 +-- .../sunxi/sun8i-rotate/sun8i_rotate.c | 2 +- drivers/staging/media/hantro/hantro_drv.c | 7 ++- drivers/staging/media/imx/imx7-mipi-csis.c | 7 +-- drivers/staging/media/rkvdec/rkvdec.c | 2 +- 32 files changed, 220 insertions(+), 127 deletions(-) -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel