From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FAKE_REPLY_A1,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21573C4743C for ; Wed, 23 Jun 2021 08:54:08 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A869611C1 for ; Wed, 23 Jun 2021 08:54:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A869611C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=weidmueller.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7F81C829DF; Wed, 23 Jun 2021 10:54:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=weidmueller.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=weidmueller.onmicrosoft.com header.i=@weidmueller.onmicrosoft.com header.b="FbzAaUzl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 13E1B829E7; Wed, 23 Jun 2021 10:54:03 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20607.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1a::607]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DCD62829DF for ; Wed, 23 Jun 2021 10:53:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=weidmueller.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=roland.gaudig-oss@weidmueller.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZvQEbh7cVkrWQPUTmxqKx7nMCJH/UQxlkJuO7gBR5TNj/ngggdTjZPZ94jX8CopLHaFjghcRomCXFmB9xFCXit5/CqRt8Vr3iOYRt0Z9JbsgmrxAkDc33Q6s8+MYzzKbc4F6ujrvaJLT8syaknzllg1s8rct9ABZHbpDuObvmY2FNQsz5NrDHXb/Jj04sJeuu9gnLkoMgZZi5w/czA1G9BoXZ3K6WTtnSwR3ZARRNHNp0kJSvnAeKuOMw0QgLizrdeMrc2VOQfXNFxiyVq7D5Y2qLaNdy+TQL8sRu/fUB62H20UleR/HSAKQlTDbwV3Fh/427A5rOxI/7uk54+/Qxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lq9GDcGF6W7NPom7+9s8lZhc0F6f6f0PkRn5sRWFnaA=; b=HJCc0aXdI/7KypfbjFgm0p0jRq1i34+ZDRJcBShQewSbv9pyiTvAqEV0OcchC1uensfuRcuJzq67yiq76/wQ2zkLL1EFQQ+EtsHBgu3rd5X9rf/WQj2BlHRz1AGx2nsofvcbncgI2tiL88OvYiQuD3WwLuBaXW3SXBghMHW84jDC5D2rs4p4fYJ9J/R2pHOVhnqRwFs3Z59VRirm83Klh80d2HwYn550Abne2AnVknz5Y+9THjNnfAzIU+7MD8uT4g8HsVPy3/7C06G0S7hpLWSzYx0g/81oAZfxAxnx2ZqmJhvrhOXZOkWGn7PwnU/ej2EOZAU+6BZFsN1Ob7mGUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.onmicrosoft.com; s=selector1-weidmueller-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lq9GDcGF6W7NPom7+9s8lZhc0F6f6f0PkRn5sRWFnaA=; b=FbzAaUzlp7db2RjgBXTVhKS/sfqCy1bIyEzo0CZYIWzgD7CDbKT0Gs0Axg/jWTAXkl+mlHIOvar9bYNRHjQKzBwiWpI/XwyGlc0A+8gGywOSV2eNzq+OG9cOaT6H9edA4z2ac2qusxdfeu53LoNtnCCpl2yZhSyMXnPmWArGuYo= Authentication-Results: chromium.org; dkim=none (message not signed) header.d=none;chromium.org; dmarc=none action=none header.from=weidmueller.com; Received: from AS8PR08MB6728.eurprd08.prod.outlook.com (2603:10a6:20b:396::19) by AM5PR0801MB1763.eurprd08.prod.outlook.com (2603:10a6:203:3b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.19; Wed, 23 Jun 2021 08:53:58 +0000 Received: from AS8PR08MB6728.eurprd08.prod.outlook.com ([fe80::8c4:6c9d:275f:5625]) by AS8PR08MB6728.eurprd08.prod.outlook.com ([fe80::8c4:6c9d:275f:5625%8]) with mapi id 15.20.4242.023; Wed, 23 Jun 2021 08:53:58 +0000 Subject: Re: [PATCH v1 1/1] cmd: setexpr: add dec operation for converting variable to decimal To: Wolfgang Denk Cc: u-boot@lists.denx.de, =?UTF-8?Q?Marek_Beh=c3=ban?= , Simon Glass From: "Roland Gaudig (OSS)" Message-ID: Date: Wed, 23 Jun 2021 08:53:56 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Originating-IP: [84.138.75.231] X-ClientProxiedBy: AM0PR10CA0054.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:150::34) To AS8PR08MB6728.eurprd08.prod.outlook.com (2603:10a6:20b:396::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from DE12086.weidmueller.com (84.138.75.231) by AM0PR10CA0054.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:150::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.19 via Frontend Transport; Wed, 23 Jun 2021 08:53:57 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: af4804b3-cdc2-4340-69d9-08d93624702b X-MS-TrafficTypeDiagnostic: AM5PR0801MB1763: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aPtv9DuO8EwFCTmQsynTuh9/euKqjs9VhJbd1/sTt1lU1eKRtQtbPH93+QLNPJkpMOqIOYinjvvtG8Y7X+jNy81zGf1WQ84o+2FWt10oBxSi5B41ZzccAtCoG6cJKZa0aBDUG0HHVX2kSt3sfwTvDzWiuwZ01PN86BqzU8yL9UdAvgCJxg3EEImR8wlDpH0WkS3nWuVNnoasooAIUvF86/m6OmA3IByY0H4r0Rkzoy2rldZlmXwHN6M85Mb9216viKq/yzE6L0iiWEmqN96u/09pWBmh5l+YdVilN9NmMKQ2Cc2wkP/oMmFmthUz9+XaBWMstuOI4L8Iqu1FVzDbUz6+P1LC+vwlwPSCwYUBMe13jM2PiILgbkxdfNM5kHMA8w+oIr9ORShzwiTVgV3ldt096EsZhr7idx6QMv/xrZ8tlRdSMVpraYF9UUpEOcOmJ+IZu2HDASRh5JUQMWrmdG5k//xicXk2JXt05Fms5MrcBNapAYV+aWatVTEElpR/gub/BFYn2Fo1zCo4fNICUVTVQj+J/YhlIskZ2whWIg2cj4utJKQZVb6awrOcrgiLJtKbmHtIM2bOFkwLwjGRo8PcEdaibx3vn088F8T2bL53XPq5Fo60dofkiKnPcHptn0xDM0qb2kqCH0tNKIP02HS98fPf1+F5BSZ0Vl8vXpibNr/CMpdDoq+Wq7rmvtjC8jEvw5JQyyohBOV7G/PcKIcYyb2jyt9EWMJO86zsiYA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB6728.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39850400004)(136003)(396003)(376002)(366004)(346002)(478600001)(6916009)(66476007)(4744005)(66946007)(66556008)(31686004)(54906003)(83380400001)(2616005)(316002)(36756003)(5660300002)(38100700002)(86362001)(956004)(31696002)(186003)(16526019)(8936002)(4326008)(2906002)(8676002)(26005)(7696005)(6486002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWl3cFdIdHZDK0xEUnl2Zi9BKzRzMlZkS215WFVoWDB6UkNiVUlDcGQxOVZX?= =?utf-8?B?d1VjcUtiWng3VTV2MEZ4UDBvR2lLVG0xWWFNTGRJQ3oveW9EaldmU2RnOEEy?= =?utf-8?B?OXE4L1pHUUxHS3F5VmRpQ0xQa2xnNElYeVZBdzVsMVNBMnVncUh0SGZFN1gr?= =?utf-8?B?Q1V2Mzhld1REbWtNUEZrU1RwMFVRMHhZdWQrTDhrV3BvNnkybW1LdVV5cDhN?= =?utf-8?B?Zk9vVndQZHVWTTdSNjhPT0J4MmtuTDBRYlFHSUUwVi9YQ3FmWkJIVFVWU3VM?= =?utf-8?B?ek55NHJJeHNVY2prMno4YzRkSmtkYjZjUHNMOWZXejhTd3ArZXR0Ymc5T2c5?= =?utf-8?B?WXN6elVaSUErZVVVd3NVN3ZkVTRSSnRxajlQZERQaW55aVlGT2pEbEZYTW42?= =?utf-8?B?K1JFMGI5c2NpLzZOc0V4MnNob2U1QXEydFY5UDl4ejdxUUNZTndlTStmN0dz?= =?utf-8?B?RWJmQ1B6TVVCYUlpbzQrbVZhQWtRS1FEd2lkUDdzTEpEUWEzblNuNEtyQVlF?= =?utf-8?B?ZHNhUmFNRlJvWVA4UmVhZUkyVU1ITjdnWWNkY0p3MVRZUTdyeWNHd0orNFlI?= =?utf-8?B?NTVGbEFiWEIrbDRrbXB3YkFSODU2QUprVzJQZ1h1TkZOOGJQYlczSjh5Y3Vu?= =?utf-8?B?TmI4OEpVMHF1Vm9XdFdyVGpTUndFOHdKYnFZNjZOQ2w4eHhrN2VBTnRNMnkr?= =?utf-8?B?Y3pITTF3RjVQZW41cC9ObUdOMS9KbnZHaUpXT2VsQ01KSjVySlhGVGUzS0tY?= =?utf-8?B?Mk1pOU9kdU4vZGk1OUxnNUlOV0FTRHcvUXlYdE5QMllBRG1XbXVhaHBpR0tO?= =?utf-8?B?V0NEVTNKdjBpSE42dWd4SDIzSVR3VHdsemVwbGFjR3ZQSHpOQTU5dGdGSzJH?= =?utf-8?B?L2YwdHBXL1JiMjZLSDAwcDFSMjJyS1Q4bHpnaS9xUzFoTXBlTngxYTJ1OVZv?= =?utf-8?B?cXRETnFGOTVUblErUTQvOGtHWm16UnluTHhybmJnZmJsUXpBbi8xQVFLSG5v?= =?utf-8?B?a1ljNjVVWHI2MlNjTzE0MFUwb1orQ2RnWTRqN2RhOUkrblZ3R3VCVFhlK29D?= =?utf-8?B?bjVaT1MyM3R3b1BueEpUTnpJcTZVYkxxQlBFdS9Hb1o5MzMzYjhjYnFOeEJp?= =?utf-8?B?ZGVZYUlkcE1aQXBSbU5jRFYrSWlaeGRBelRlNmNobllBT0lHaE9mQUtSWHgw?= =?utf-8?B?b2hGWUFNY3ZqTUwxbkhYR0pIL3NLbVo0MGdzM2ViOGd0Vkd3YkcwQ3FhaE9U?= =?utf-8?B?RnRodHducUlUZkk5VVpWaWk2RWN0bk5iUm9Pd05rSEUvekd5Q3RPSU9JV2hU?= =?utf-8?B?VCs2R2xTM0x5WHN2NGEzbEMzbXRac0QxU3FDNmdWdGMvYzhpZUZWcnVjUHVQ?= =?utf-8?B?VHZTdGdWeUdjK045V2YyUEowSyt4S0w4RVhuYTlCeElBeG5HWkFIUEZhSE91?= =?utf-8?B?NUlCaElRRE1WbmpCd00vWFlQRjR2bGM4R3VEaTV0RXo2M0tNUDN0TStsS1RS?= =?utf-8?B?Nm1HN1hMc1FCZXFZdDlWWjF3QWpMTEk5S0dPaTlpc3hoY1FPcE9MZGV3SlRh?= =?utf-8?B?R0VsNkJQbUQ2N0Y0N1B6dUlsNXpKUFVacCtaNmRnYkhYMUJMamlnWGFwRExR?= =?utf-8?B?bFAyaklIb1FRd2pzQWt5NUFJSGxVR0hBY3BJYkFPUlkyZjNYU2pYRlNuTU1I?= =?utf-8?B?WFRLTmVHTHhpcHJjb1l6QTFGNnJRVmkrYTZ3c0kzYnZuUkc0bEQxYll6MHkz?= =?utf-8?Q?kRyIFFJuh9YoxYMfh0hRyxTBxRYpIHCU/8/ZMEC?= X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: af4804b3-cdc2-4340-69d9-08d93624702b X-MS-Exchange-CrossTenant-AuthSource: AS8PR08MB6728.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2021 08:53:57.9053 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WSbgoqtAF/IDumvV2tFRdHIH0QOVp6NalzxOodlZsAVkANUPiuwu6FHyc75x8YIH3mjJPdi+LQWtQ7mimcxAqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1763 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Wolfgang, On Wed, 23. Jun 2021 08:03, Wolfgang Denk wrote: > > Dear Roland, > > In message <20210622135042.133904-2-roland.gaudig-oss@weidmueller.com> you > wrote: >> >> This patch extends the setexpr command with a dec operator to >> convert an input value to decimal. > ... >> + /* hexadecimal to decimal conversion: "setexpr name dec value" */ >> + if (argc == 4 && (strcmp(argv[2], "dec") == 0)) { >> + w = cmd_get_data_size(argv[3], 4); >> + a = get_arg(argv[3], w); >> + return env_set_ulong(argv[1], a); >> + } > > Should there not be a test for 4 arguments and the third _not_ being > "dec" ? Like "setexpr foo hex 42" ? Yes it's possible to add further conversion operations. But I didn't saw a need for hex in the first place, as hex is currently the default within U-Boot. But when adding a decimal prefix as Simon proposed, hex conversion becomes necessary. Best regards, Roland Gaudig