From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D9ADC12002 for ; Sat, 17 Jul 2021 00:57:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B74BA613DF for ; Sat, 17 Jul 2021 00:57:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B74BA613DF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ynMhenN+gbH6N4poerFBzljh27mhT0BPERzDLe02nvg=; b=lhYf2wbCLV0ETGnZeNGW2BDVva 6NcuqHL4iiveUVrmlCtFrEIWvP1ga0iP5wIYfM68vyNARmNMyvJs+CNpjZjWMYM9hBynNne5K732t aKWSgaYZn/ed2WERLFgEBuDBogcqbzAivYKQrQ9sXE+irkaM9awSAxYSUielC98pm6AW8MdHtX1Ad ZHLhkB3wJH8T0MxmfvrHXRHWsOAorzSX665ATkiXCnJpYOhO75QGzU+7uuX80FWt3MB8/nY5t7tHk iIiI5IK39ahLgN7Yzz6fJE47KYeQ+2v0wVTyOKvfYKdG/f7PHWqZjolDwAhfnIlHQPHguLNHxIIq8 iZ+sl8gw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4Ybp-005jHh-0d; Sat, 17 Jul 2021 00:55:13 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4Ybl-005jHE-LZ for linux-arm-kernel@lists.infradead.org; Sat, 17 Jul 2021 00:55:11 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id AA9D382A01; Sat, 17 Jul 2021 02:55:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1626483307; bh=e6JpnvbZQh2PCF9UkKcCjSewEYNEjNgQfRu+ir6tEAU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Wy6BapNRvk6S/q+fGUHwh94JrhgFB7GmNYERZZ7PV+9ea6lQHq+y0FZFipoh0zq+i BxxaJWx8an2lW1wvO+bdb4E4Z+bRF85g6D4y9xbQvkSz5a7JXsxWDxn/PVqoKS5aHi VDkIiWbLaD2H1dppPgjuqHSvF6yGPGlnu0cM9Lmmm4m+IS0In3pcvWAoEU36ieCn3w /SVrZOovmcWdK8PmhLmzMGILKNGSCws+tnls2ZwC4ZjdeJ3LVMJcwzX5y7VBpQNsN8 a3+GKIgGig/YjxmodmJHmUOSEhiNDk73XcjCXuwAArT40F/e9OYm7t4E5O3txDgnN/ ZmzHOaxXpU82Q== Subject: Re: [PATCH] soc: imx: gpcv2: Assert reset before ungating clock To: Lucas Stach , linux-arm-kernel@lists.infradead.org Cc: ch@denx.de, Fabio Estevam , Frieder Schrempf , NXP Linux Team , Peng Fan , Shawn Guo References: <20210630225902.237192-1-marex@denx.de> <7685e3da21367e66057592fc003392abb0674dda.camel@pengutronix.de> From: Marek Vasut Message-ID: Date: Sat, 17 Jul 2021 02:55:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <7685e3da21367e66057592fc003392abb0674dda.camel@pengutronix.de> Content-Language: en-US X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210716_175509_952535_C71DCB32 X-CRM114-Status: GOOD ( 12.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/17/21 1:32 AM, Lucas Stach wrote: > Hi Marek, Hi, > Am Donnerstag, dem 01.07.2021 um 00:59 +0200 schrieb Marek Vasut: >> In case the power domain clock are ungated before the reset is asserted, >> the system might freeze completely. However, the MX8MM GPUMIX and VPUMIX >> domains require different reset deassertion timing, and incorrect reset >> deassertion timing also leads to hang. >> >> Add per-domain reset_{,de}assert_early flags which allow fine-grained >> control of the reset assertion and deassertion sequence. Currently, on >> MX8MM, the behavior is as follows and aligned with NXP downstream ATF >> fork: >> - VPUMIX: reset assert, reset deassert, domain power up >> - GPUMIX: reset assert, domain power on, reset deassert >> > This patch should now be necessary, as my testing over the last few > days showed that the VPUMIX isn't actually different and copes just > fine with the reset being asserted early, just like the GPUMIX domain. Yes, this patch is absolutely essential, otherwise the system hangs at random, as explained in the commit message. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel