From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 848A6C636C9 for ; Sat, 17 Jul 2021 09:11:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4508561285 for ; Sat, 17 Jul 2021 09:11:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4508561285 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RbBUkirup/wVb7yukmvGGAVCgwbxWU6zoJUkVr+6ryo=; b=t6YRkMaf4L7LyC q1e2fWtugd6QBiqURyjFiHJpwcOVzopqCQQ94UYSD9qu/lp+AzsiaAZ+rh7BobLdIezTY0mNpKe9V Y4IeOSVm32NlSIx0qtqnz+dCex4U3vz5Su1SA9JzCwiYLUkrQAGK0mmHGxPurevn4L/tXtBJs7XAZ XqLAKGzhOV7NmdOIdPsJOwmjz8/obO9Wqcy2R+HNAtQ32SpTu5eZFt1EkGrY+XhLml2PA716t1UvD K3WEx+Ztobfhjw+FJRUVZn+aXfxHcCP9AiuhnuNFpqodjCdX/pQbKQS4KcooE6NRIXqeEO03TkIHj hhjYd5El7/vJNGC9JPxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4gK4-006J6J-NT; Sat, 17 Jul 2021 09:09:25 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4gIS-006ICz-0X for linux-arm-kernel@lists.infradead.org; Sat, 17 Jul 2021 09:07:45 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m4gIP-0000uv-HH; Sat, 17 Jul 2021 11:07:41 +0200 Message-ID: Subject: Re: [PATCH] soc: imx: gpcv2: Assert reset before ungating clock From: Lucas Stach To: Marek Vasut , linux-arm-kernel@lists.infradead.org Cc: ch@denx.de, Fabio Estevam , Frieder Schrempf , NXP Linux Team , Peng Fan , Shawn Guo Date: Sat, 17 Jul 2021 11:07:39 +0200 In-Reply-To: References: <20210630225902.237192-1-marex@denx.de> <7685e3da21367e66057592fc003392abb0674dda.camel@pengutronix.de> User-Agent: Evolution 3.40.3 (3.40.3-1.fc34) MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210717_020744_094788_D363EE15 X-CRM114-Status: GOOD ( 17.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Samstag, dem 17.07.2021 um 02:55 +0200 schrieb Marek Vasut: > On 7/17/21 1:32 AM, Lucas Stach wrote: > > Hi Marek, > > Hi, > > > Am Donnerstag, dem 01.07.2021 um 00:59 +0200 schrieb Marek Vasut: > > > In case the power domain clock are ungated before the reset is asserted, > > > the system might freeze completely. However, the MX8MM GPUMIX and VPUMIX > > > domains require different reset deassertion timing, and incorrect reset > > > deassertion timing also leads to hang. > > > > > > Add per-domain reset_{,de}assert_early flags which allow fine-grained > > > control of the reset assertion and deassertion sequence. Currently, on > > > MX8MM, the behavior is as follows and aligned with NXP downstream ATF > > > fork: > > > - VPUMIX: reset assert, reset deassert, domain power up > > > - GPUMIX: reset assert, domain power on, reset deassert > > > > > This patch should now be necessary, as my testing over the last few > > days showed that the VPUMIX isn't actually different and copes just > > fine with the reset being asserted early, just like the GPUMIX domain. > > Yes, this patch is absolutely essential, otherwise the system hangs at > random, as explained in the commit message. And I was tired. This should have read *not* be necessary. Please take a look at the series I posted, where I just reverted the patch which changed the reset order to a late reset. With this the GPC now once again uses the reset order as required by the GPU, without any additional complexity. Regards, Lucas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel