Re: [OE-core] [hardknott][PATCH v2] rust-cross: Replace TARGET_ARCH with TUNE_PKGARCH

From: Randy MacLeod <randy.macleod@windriver.com>
To: Pgowda <pgowda.cve@gmail.com>, openembedded-core@lists.openembedded.org
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>,
	Randy MacLeod <rwmacleod@gmail.com>,
	umesh.kalappa0@gmail.com
Subject: Re: [OE-core] [hardknott][PATCH v2] rust-cross: Replace TARGET_ARCH with TUNE_PKGARCH
Date: Thu, 18 Nov 2021 18:16:13 -0500	[thread overview]
Message-ID: <d583f076-b721-f482-535d-1c22867b6b63@windriver.com> (raw)
In-Reply-To: <CALY4987g508BzDM2fmYvoTpNH7KAKJkycF4OUABhtUjMLmZbxg@mail.gmail.com>

On 2021-11-18 10:30 a.m., Pgowda wrote:
> Hi,
> 
> Gentle ping on this patch.

It's in master-next but it may not have been this morning.

$ pwd

.../oe-core.git

$ git status

On branch master-next

Your branch is up to date with 'origin/master-next'.

nothing to commit, working tree clean

git log --pretty=fuller

...
commit c2c3477377f3c41c6bf791a42d66386da17b0ba3

Author:     Pgowda <pgowda.cve@gmail.com>

AuthorDate: Mon Nov 15 09:03:40 2021

Commit:     Richard Purdie <richard.purdie@linuxfoundation.org>

CommitDate: Tue Nov 16 17:22:18 2021

     rust-cross: Replace TARGET_ARCH with TUNE_PKGARCH

../Randy

> 
> Thanks,
> pgowda
> 
> On Mon, Nov 15, 2021 at 7:33 PM Pgowda <pgowda.cve@gmail.com> wrote:
>>
>> rust-cross-* imported from meta-rust has incorrect signatures,
>> depending on MACHINEOVERRIDES making it effectively MACHINE_ARCH
>> as shown by sstate-diff-machines.sh:
>>
>> openembedded-core/scripts/sstate-diff-machines.sh --tmpdir=tmp-glibc \
>> --machines="qemuarm64 qemuarm64copy" --targets=rust-cross-aarch64-glibc \
>> --analyze
>>
>>   === Comparing signatures for task do_configure.sigdata between
>>   qemuarm64 and qemuarm64copy ===
>> ERROR: gcc-runtime different signature for task do_configure.sigdata
>> between qemuarm64 and qemuarm64copy
>> NOTE: Starting bitbake server...
>> Hash for dependent task gcc/gcc-runtime_11.2.bb:do_prepare_recipe_sysroot
>> changed from
>> da4ebf1b272cb73153145a0a95e6438d2955ae2d36f84db10f6880b2781ec331 to
>> 47a0ebb7a88c9f896fb9dbce269f575ab8a6faabb2b9e62d164be6e71c5e4e40
>> Unable to find matching sigdata for
>> openembedded-core/meta/recipes-devtools/gcc/gcc-runtime_11.2.bb:
>> do_prepare_recipe_sysroot with hashes
>> da4ebf1b272cb73153145a0a95e6438d2955ae2d36f84db10f6880b2781ec331 or
>> 47a0ebb7a88c9f896fb9dbce269f575ab8a6faabb2b9e62d164be6e71c5e4e40
>>
>> The following patch takes TUNE_PKGARCH into consideration instead
>> of TARGET_ARCH and results in signatures as expected.
>>
>> [YOCTO #14613]
>>
>> Signed-off-by: Pgowda <pgowda.cve@gmail.com>
>> ---
>>   meta/recipes-devtools/rust/rust-cross.inc | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/rust/rust-cross.inc b/meta/recipes-devtools/rust/rust-cross.inc
>> index bb625f4240..a77f7d5122 100644
>> --- a/meta/recipes-devtools/rust/rust-cross.inc
>> +++ b/meta/recipes-devtools/rust/rust-cross.inc
>> @@ -34,7 +34,7 @@ DEPENDS += "virtual/${TARGET_PREFIX}gcc virtual/${TARGET_PREFIX}compilerlibs vir
>>   DEPENDS += "rust-native"
>>
>>   PROVIDES = "virtual/${TARGET_PREFIX}rust"
>> -PN = "rust-cross-${TARGET_ARCH}-${TCLIBC}"
>> +PN = "rust-cross-${TUNE_PKGARCH}-${TCLIBC}"
>>
>>   # In the cross compilation case, rustc doesn't seem to get the rpath quite
>>   # right. It manages to include '../../lib/${TARGET_PREFIX}', but doesn't
>> --
>> 2.31.1
>>
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#158478): https://lists.openembedded.org/g/openembedded-core/message/158478
>> Mute This Topic: https://lists.openembedded.org/mt/87069441/3616765
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [randy.macleod@windriver.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>

-- 
# Randy MacLeod
# Wind River Linux