From: Valentin Schneider <valentin.schneider@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v2] sched/fair: fix imbalance due to CPU affinity
Date: Tue, 2 Jul 2019 15:29:21 +0100 [thread overview]
Message-ID: <d71ab6f7-3aab-adb3-f170-7757bde94f7c@arm.com> (raw)
In-Reply-To: <CAKfTPtBGDZ5P91hwGdHADYpcbOPeniDLE7x3-U9dXDvFVMAi1w@mail.gmail.com>
On 02/07/2019 11:00, Vincent Guittot wrote:
>> Does that want a
>>
>> Cc: stable@vger.kernel.org
>> Fixes: afdeee0510db ("sched: Fix imbalance flag reset")
>
> I was not sure that this has been introduced by this patch or
> following changes. I haven't been able to test it on such old kernel
> with my platform
>
Right, seems like
65a4433aebe3 ("sched/fair: Fix load_balance() affinity redo path")
also played in this area. From surface level it looks like it only reduced
the amount of CPUs the load_balance() redo can use (and interestingly it
mentions the exact same bug as you observed, through triggered slightly
differently).
I'd be inclined to say that the issue was introduced by afdeee0510db, since
from looking at the code from that time I can see the issue happening:
- try to pull from a CPU with only tasks pinned to itself
- set sgc->imbalance
- redo with a CPU that sees no big imbalance
- goto out_balanced
- env.LBF_ALL_PINNED is still set but we clear sgc->imbalance
>>
>> ?
>>
next prev parent reply other threads:[~2019-07-02 14:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 15:47 [PATCH v2] sched/fair: fix imbalance due to CPU affinity Vincent Guittot
2019-07-01 19:03 ` Peter Zijlstra
2019-07-02 9:34 ` Valentin Schneider
2019-07-02 10:00 ` Vincent Guittot
2019-07-02 14:29 ` Valentin Schneider [this message]
2019-07-05 12:23 ` Vincent Guittot
2019-07-25 16:13 ` [tip:sched/core] sched/fair: Fix " tip-bot for Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d71ab6f7-3aab-adb3-f170-7757bde94f7c@arm.com \
--to=valentin.schneider@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.