From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0DD8C433F5 for ; Thu, 28 Apr 2022 10:45:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233870AbiD1Ksj (ORCPT ); Thu, 28 Apr 2022 06:48:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230474AbiD1Ksf (ORCPT ); Thu, 28 Apr 2022 06:48:35 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E713890BE for ; Thu, 28 Apr 2022 03:45:21 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id g6so8744772ejw.1 for ; Thu, 28 Apr 2022 03:45:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=cYKCRoREjH87n5LGj1ImFAnKPWrOHAXKmxpNcNNNnIw=; b=l17YCFMxKiwjEr5HZ0HPvJ9Lp/No3mKPtEwmSTNmRmgT2RGTJcYSTwyW3ZAGFxNhhG hemeitu4DciYBdWDTVfpRkaS4x14zdyI4L6NtXH1TBAWKHDN9AyxE/u3/GlKo2LuRr8S R5kWe+WsFQl6l1GEXZamWspcggud4YW1AHazmNflTGkpcSZN2UwIGJ457pndK0rlZbk5 bDtLeUKFu+7YurGBdZ2t+SrjRzkoneO4541QY4RHWSC+7E2Bm+EVDy+YyF8Y40k0FiJZ UT+6IDNuGkq8AQRkGQh4GZGA6YYifsOo8ZX1qcpZWS09L30vH/rRXx09o4OVFllVV0xL t3GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=cYKCRoREjH87n5LGj1ImFAnKPWrOHAXKmxpNcNNNnIw=; b=1BLW+9Im3DwupLS7mkQcGV/C7zZZlbZJEF5aURLrN6LqWrWqSjvHeDuL0F5bDK4+qH I33/D77vKO+zANBhXGCsGGBisoUnpIHE6WEBL9uICIjKQw64FGAPANDh75ITwS6LNoGw Xllufbf60v1sAgziGvq0N4eaU/IrMu54M5iMuiCM8LA4TN5p7RlR+GsNRohK0E7xlHt0 04dTZ5WCZAH30e1b8WoedaLFNxnX2vddVPuzDjPt6NPAevsYTWyv2yyHGIakKD4tu63r m8pR70rlnTObC0J7+uOZeDtCEn7xWSaV907iJ/cOdtgLiKWts9fkeptUUEL1EHBJgqVe yzVQ== X-Gm-Message-State: AOAM5325yi7rZa+3ctLY2oyqTIb+ME+1JFEz4WDKMXJutyd1+NaTwe/6 yDydKtNELNIr090rmjdK7Bgyjw== X-Google-Smtp-Source: ABdhPJyp6f5iGveZCxbZ+tLf8F4Iv7cCwecumgh+r4Mv003t4J9QnoHQJbOmBYZwweCyrVxme8/N/g== X-Received: by 2002:a17:907:7ba3:b0:6ef:f9ca:f2da with SMTP id ne35-20020a1709077ba300b006eff9caf2damr20181561ejc.634.1651142719668; Thu, 28 Apr 2022 03:45:19 -0700 (PDT) Received: from [192.168.0.161] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id h7-20020a1709060f4700b006e8d0746969sm8053221ejj.222.2022.04.28.03.45.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 03:45:19 -0700 (PDT) Message-ID: Date: Thu, 28 Apr 2022 12:45:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 04/10] arm64: dts: juno: use proper 'dma-channels/requests' properties Content-Language: en-US To: Robin Murphy , Lee Jones , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , Dinh Nguyen , Michal Simek , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Ray Jui , Scott Branden , Broadcom Kernel Team , Sylwester Nawrocki , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rob Herring References: <20220427155840.596535-1-krzysztof.kozlowski@linaro.org> <20220427155840.596535-5-krzysztof.kozlowski@linaro.org> <1d1aae6e-50db-d6db-9727-62f9c2d1ca6b@arm.com> From: Krzysztof Kozlowski In-Reply-To: <1d1aae6e-50db-d6db-9727-62f9c2d1ca6b@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/04/2022 12:43, Robin Murphy wrote: > On 2022-04-27 16:58, Krzysztof Kozlowski wrote: >> pl330 DMA controller bindings documented 'dma-channels' and >> 'dma-requests' properties (without leading hash sign), so fix the DTS to >> match the bindings. >> >> Reported-by: Rob Herring >> Signed-off-by: Krzysztof Kozlowski >> --- >> arch/arm64/boot/dts/arm/juno-base.dtsi | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi >> index 4f40a5c8f565..96ef0ddc0b2d 100644 >> --- a/arch/arm64/boot/dts/arm/juno-base.dtsi >> +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi >> @@ -829,8 +829,8 @@ dma-controller@7ff00000 { >> compatible = "arm,pl330", "arm,primecell"; >> reg = <0x0 0x7ff00000 0 0x1000>; >> #dma-cells = <1>; >> - #dma-channels = <8>; >> - #dma-requests = <32>; >> + dma-channels = <8>; >> + dma-requests = <32>; > > BTW, this has always been wrong - Juno is configured with only 8 request > interfaces. But then it's moot anyway since PL330 has an ID register for > this stuff[1], so the DT properties aren't used by Linux, and shouldn't > be needed in general. Marek also raised the point [1] that these properties are useless for PL330 because the actual data is read from the device registers. I understand you are also supporting the idea of removing them from pl330 device nodes? [1] https://lore.kernel.org/linux-devicetree/20220427155840.596535-1-krzysztof.kozlowski@linaro.org/T/#mf108b8c9f0d513ebc6e381775e3c6887b5c2fe31 Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C09F4C433F5 for ; Thu, 28 Apr 2022 10:46:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EDHNxZk1urKRz9QxMJobgY2l8fiYsTXG9UAVHgoOrco=; b=N7hcEByWix0FKF CG87h42/pGWFH2i87GSpko4jtDhp6vt3lMVnAEyX9PZwjyadQhqXqus9TYgM1WbgNANqia5+GPJ4K op7jb7/VFQxyYtDbh6uE0afXNbo8Ez/CPjXwydfuClnLG55bpNrCsFS0DcFJav+pCqHX2V+3vH39y yR/+qY2vLh9fLE0TDXneu+o8/Tc6AW5KWwlJG5Q/hPsoFSczWOolOD8H7q6Md+dAIOmclAYv4Ir6j r3+L5mvdAy3k+hk1Fu26gjiiwslJn6dHMCCXB31jr0F9ivlto5lm/YxFar2m4YTtP0r3Bd3y01h95 kY8uGqs09uMqLhB7YZvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nk1eG-006EAO-85; Thu, 28 Apr 2022 10:45:24 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nk1eD-006E9L-Pc for linux-arm-kernel@lists.infradead.org; Thu, 28 Apr 2022 10:45:23 +0000 Received: by mail-ej1-x632.google.com with SMTP id r13so8728603ejd.5 for ; Thu, 28 Apr 2022 03:45:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=cYKCRoREjH87n5LGj1ImFAnKPWrOHAXKmxpNcNNNnIw=; b=l17YCFMxKiwjEr5HZ0HPvJ9Lp/No3mKPtEwmSTNmRmgT2RGTJcYSTwyW3ZAGFxNhhG hemeitu4DciYBdWDTVfpRkaS4x14zdyI4L6NtXH1TBAWKHDN9AyxE/u3/GlKo2LuRr8S R5kWe+WsFQl6l1GEXZamWspcggud4YW1AHazmNflTGkpcSZN2UwIGJ457pndK0rlZbk5 bDtLeUKFu+7YurGBdZ2t+SrjRzkoneO4541QY4RHWSC+7E2Bm+EVDy+YyF8Y40k0FiJZ UT+6IDNuGkq8AQRkGQh4GZGA6YYifsOo8ZX1qcpZWS09L30vH/rRXx09o4OVFllVV0xL t3GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=cYKCRoREjH87n5LGj1ImFAnKPWrOHAXKmxpNcNNNnIw=; b=R1an1QXiLZwLN4CWVRF0k0CVg8HzmdMlhIq1zZ5hLjEltrlyAq5IhkSvl2wlPyxzg6 egr0oQDuXh8d3H5Vicaud2VOAMys3NU/VdPO80UOC6PeWu9HLeGJPp992SWBKqhwATcA 3FwUWH4cBZSA4FYkZMa6epRZ3n9g1Wyr5DlnNpZY4uVn8Bzz3RBfoINkAnMVBQvkUO+U AvzU79BblbtNno+JvtQJsiubRgFoQm/o7l8WLS/4nIDpdDGs3EgO4sOtujwO84O5Lw1q MZJT4D2pQZwrgD5Mo57CleB3ttLfbepALfCzSKo4f7IGOYd7ztsOWQ4B7PpMmvHZY+1X w0jw== X-Gm-Message-State: AOAM532glz61jNtSZOYWE9PU1qAHvpm+n7AFp602cnkPJDZFFwpHSiEz C0a9emzaSSnuMOZ+u6out1smaA== X-Google-Smtp-Source: ABdhPJyp6f5iGveZCxbZ+tLf8F4Iv7cCwecumgh+r4Mv003t4J9QnoHQJbOmBYZwweCyrVxme8/N/g== X-Received: by 2002:a17:907:7ba3:b0:6ef:f9ca:f2da with SMTP id ne35-20020a1709077ba300b006eff9caf2damr20181561ejc.634.1651142719668; Thu, 28 Apr 2022 03:45:19 -0700 (PDT) Received: from [192.168.0.161] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id h7-20020a1709060f4700b006e8d0746969sm8053221ejj.222.2022.04.28.03.45.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 03:45:19 -0700 (PDT) Message-ID: Date: Thu, 28 Apr 2022 12:45:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 04/10] arm64: dts: juno: use proper 'dma-channels/requests' properties Content-Language: en-US To: Robin Murphy , Lee Jones , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , Dinh Nguyen , Michal Simek , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Ray Jui , Scott Branden , Broadcom Kernel Team , Sylwester Nawrocki , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rob Herring References: <20220427155840.596535-1-krzysztof.kozlowski@linaro.org> <20220427155840.596535-5-krzysztof.kozlowski@linaro.org> <1d1aae6e-50db-d6db-9727-62f9c2d1ca6b@arm.com> From: Krzysztof Kozlowski In-Reply-To: <1d1aae6e-50db-d6db-9727-62f9c2d1ca6b@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220428_034521_885545_3911A211 X-CRM114-Status: GOOD ( 17.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/04/2022 12:43, Robin Murphy wrote: > On 2022-04-27 16:58, Krzysztof Kozlowski wrote: >> pl330 DMA controller bindings documented 'dma-channels' and >> 'dma-requests' properties (without leading hash sign), so fix the DTS to >> match the bindings. >> >> Reported-by: Rob Herring >> Signed-off-by: Krzysztof Kozlowski >> --- >> arch/arm64/boot/dts/arm/juno-base.dtsi | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi >> index 4f40a5c8f565..96ef0ddc0b2d 100644 >> --- a/arch/arm64/boot/dts/arm/juno-base.dtsi >> +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi >> @@ -829,8 +829,8 @@ dma-controller@7ff00000 { >> compatible = "arm,pl330", "arm,primecell"; >> reg = <0x0 0x7ff00000 0 0x1000>; >> #dma-cells = <1>; >> - #dma-channels = <8>; >> - #dma-requests = <32>; >> + dma-channels = <8>; >> + dma-requests = <32>; > > BTW, this has always been wrong - Juno is configured with only 8 request > interfaces. But then it's moot anyway since PL330 has an ID register for > this stuff[1], so the DT properties aren't used by Linux, and shouldn't > be needed in general. Marek also raised the point [1] that these properties are useless for PL330 because the actual data is read from the device registers. I understand you are also supporting the idea of removing them from pl330 device nodes? [1] https://lore.kernel.org/linux-devicetree/20220427155840.596535-1-krzysztof.kozlowski@linaro.org/T/#mf108b8c9f0d513ebc6e381775e3c6887b5c2fe31 Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel