All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Jaroslav Kysela <perex@perex.cz>, alsa-devel@alsa-project.org
Subject: Re: [PATCH alsa-lib v2 0/3] mixer: Volume control fixes
Date: Thu, 4 Mar 2021 22:50:43 +0100	[thread overview]
Message-ID: <d879513b-7047-8e95-d037-cd45669bb0b3@redhat.com> (raw)
In-Reply-To: <20210228161304.241288-1-hdegoede@redhat.com>

Hi All,

On 2/28/21 5:13 PM, Hans de Goede wrote:
> Hi All,
> 
> Here is v2 of my series of alsa-lib volume-control fixes which I wrote
> while working on adding hw-volume control to UCM profiles for various
> x86 ASoC setups.
> 
> New in v2 is adding an extra entry to the capture_volume_names array
> for the "ADC PGA Gain Volume" control used in the es8316 codec driver
> in patch 3/3.
> 
> Note that patch 3/3 is not strictly necessary to make hw-volume control
> work. At least the PA hw-vol-control code does not care if the controls
> are wronly marked as global-volume-controls instead of
> capture-volume-controls. I mostly wrote patch 3/3 because for
> correctness reasons, so if it is deemed controversial we can drop it.

Self-nack, I have some plans to make this more generic and I found
another set of control-names which need special handling (which is
the motivation to make the exception mechanism more generic).

I will post a new version sometime this weekend.

Regards,

Hans


  parent reply	other threads:[~2021-03-04 21:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-28 16:13 [PATCH alsa-lib v2 0/3] mixer: Volume control fixes Hans de Goede
2021-02-28 16:13 ` [PATCH alsa-lib v2 1/3] mixer: Unify simple_none: base_len() exception handling Hans de Goede
2021-02-28 16:13 ` [PATCH alsa-lib v2 2/3] mixer: Add exception for non " Volume" suffixed capture vol-ctls used in ASoC realtek codec drivers Hans de Goede
2021-02-28 16:13 ` [PATCH alsa-lib v2 3/3] mixer: Add exception for some capture-vol-ctls which have a " Volume" suffix Hans de Goede
2021-03-04 21:50 ` Hans de Goede [this message]
2021-03-05  9:57   ` [PATCH alsa-lib v2 0/3] mixer: Volume control fixes Jaroslav Kysela
2021-03-05 10:03     ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d879513b-7047-8e95-d037-cd45669bb0b3@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.