From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45540C43381 for ; Mon, 18 Mar 2019 02:11:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1820D20857 for ; Mon, 18 Mar 2019 02:11:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727682AbfCRCLq (ORCPT ); Sun, 17 Mar 2019 22:11:46 -0400 Received: from anchovy3.45ru.net.au ([203.30.46.155]:52890 "EHLO anchovy3.45ru.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726906AbfCRCLq (ORCPT ); Sun, 17 Mar 2019 22:11:46 -0400 Received: (qmail 2529 invoked by uid 5089); 18 Mar 2019 02:11:43 -0000 Received: by simscan 1.2.0 ppid: 2393, pid: 2394, t: 0.0384s scanners: regex: 1.2.0 attach: 1.2.0 clamav: 0.88.3/m:40/d:1950 Received: from unknown (HELO ?192.168.0.122?) (preid@electromag.com.au@203.59.235.95) by anchovy2.45ru.net.au with ESMTPA; 18 Mar 2019 02:11:43 -0000 Subject: Re: regression from: net: phy: marvell: Avoid unnecessary soft reset To: Florian Fainelli , netdev@vger.kernel.org Cc: Andrew Lunn , "David S. Miller" , dongsheng.wang@hxt-semitech.com, cphealy@gmail.com, clemens.gruber@pqgruber.com, hkallweit1@gmail.com, nbd@nbd.name, harini.katakam@xilinx.com References: <20180925182846.30042-1-f.fainelli@gmail.com> <20180925182846.30042-3-f.fainelli@gmail.com> <5ddf46b1-1959-832d-c6a5-86d8f93dc409@electromag.com.au> From: Phil Reid Message-ID: Date: Mon, 18 Mar 2019 10:11:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-AU Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 16/03/2019 5:58 am, Florian Fainelli wrote: > On 3/15/19 1:52 AM, Phil Reid wrote: >> G'day All, >> >> I've just update from kernel 4.19 to 5.0 on a custom board that has a >> marvell >> dsa mv88e6085 and the phy on the mv88e6085 will only connect at 10Mb/s with >> the above mentioned patch applied. >> >> Bisecting the issue lead me to the following patch. >> >> d6ab93364734bd (net: phy: marvell: Avoid unnecessary soft reset) >> >> Revert the patch, and the associated build fix >> 4b1bd6976945417 (net: phy: marvell: Fix build.) >> restores connections to 1Gb/s. >> >> Anyone have any thoughts as to the correct fix? > > What is the PHY OUI (MII_PHYSID1/ID2) for that PHY? We may need to add a > specific entry in drivers/net/phy/marvell.c to restore the software > reset to commit changes to the register. > G'day Florian, OUI is 0x005043 Model is 101011 Phy1ID: 0x0141 Phy2ID: 0x0eb1 The running phy driver is "Marvell 88E1540" -- Regards Phil