From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Peter Maydell <peter.maydell@linaro.org>,
Alexandre Iooss <erdnaxe@crans.org>
Cc: "open list:STM32F100" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
Alistair Francis <alistair@alistair23.me>
Subject: Re: [PATCH 0/2] STM32VLDISCOVERY Machine Model
Date: Mon, 14 Jun 2021 18:16:28 +0200 [thread overview]
Message-ID: <d9833bea-412b-1c45-660b-80d138d50658@amsat.org> (raw)
In-Reply-To: <CAFEAcA_Dx+7Gt-7bzRu7t27xQs-59oo2jnpybroPqN-46ak0Kw@mail.gmail.com>
On 6/14/21 6:05 PM, Peter Maydell wrote:
> On Tue, 8 Jun 2021 at 17:10, Alexandre Iooss <erdnaxe@crans.org> wrote:
>>
>> This patch series adds the STM32VLDISCOVERY Machine to QEMU
>>
>> Information on the board is available at:
>> https://www.st.com/en/evaluation-tools/stm32vldiscovery.html
>>
>> Alexandre Iooss (2):
>> stm32f100: Add the stm32f100 SoC
>> stm32vldiscovery: Add the STM32VLDISCOVERY Machine
>>
>> MAINTAINERS | 12 ++
>> default-configs/devices/arm-softmmu.mak | 1 +
>> hw/arm/Kconfig | 10 ++
>> hw/arm/meson.build | 2 +
>> hw/arm/stm32f100_soc.c | 182 ++++++++++++++++++++++++
>> hw/arm/stm32vldiscovery.c | 66 +++++++++
>> include/hw/arm/stm32f100_soc.h | 58 ++++++++
>> 7 files changed, 331 insertions(+)
>> create mode 100644 hw/arm/stm32f100_soc.c
>> create mode 100644 hw/arm/stm32vldiscovery.c
>> create mode 100644 include/hw/arm/stm32f100_soc.h
>
> Looks generally OK to me, but cc'ing Alistair who wrote the
> STM32F405 model in case he wants to have a look at it.
The SoC in the STM32Fxxx family seems very similar.
Maybe OK for this one but next machines should consider reuse
components. Alexandre, if you plan to add more SoC, you might
want to look at how the abstract TYPE_ATMEGA_MCU handles multiples
MCU of the same family.
Regards,
Phil.
prev parent reply other threads:[~2021-06-14 16:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 16:10 [PATCH 0/2] STM32VLDISCOVERY Machine Model Alexandre Iooss
2021-06-08 16:10 ` [PATCH 1/2] stm32f100: Add the stm32f100 SoC Alexandre Iooss
2021-06-14 16:04 ` Peter Maydell
2021-06-15 7:56 ` Alexandre IOOSS
2021-06-15 7:41 ` Alistair Francis
2021-06-15 7:49 ` Alexandre IOOSS
2021-06-15 8:04 ` Alistair Francis
2021-06-15 9:15 ` Alexandre IOOSS
2021-06-15 10:40 ` Alistair Francis
2021-06-08 16:10 ` [PATCH 2/2] stm32vldiscovery: Add the STM32VLDISCOVERY Machine Alexandre Iooss
2021-06-14 15:52 ` Peter Maydell
2021-06-15 7:16 ` Alexandre IOOSS
2021-06-15 7:50 ` Alistair Francis
2021-06-15 9:07 ` Peter Maydell
2021-06-14 16:05 ` [PATCH 0/2] STM32VLDISCOVERY Machine Model Peter Maydell
2021-06-14 16:16 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9833bea-412b-1c45-660b-80d138d50658@amsat.org \
--to=f4bug@amsat.org \
--cc=alistair@alistair23.me \
--cc=erdnaxe@crans.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.