From: Randy Dunlap <rdunlap@infradead.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Len Brown <lenb@kernel.org>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: linux-next: Tree for Nov 27 (drivers/idle/intel_idle.c)
Date: Fri, 27 Nov 2020 13:38:40 -0800 [thread overview]
Message-ID: <d9a42bb5-7a5d-cc19-2866-0cee1b8dd9bd@infradead.org> (raw)
In-Reply-To: <20201128083617.50021fff@canb.auug.org.au>
On 11/27/20 1:36 PM, Stephen Rothwell wrote:
> Hi Randy,
>
> On Fri, 27 Nov 2020 07:57:32 -0800 Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> On 11/27/20 1:04 AM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20201126:
>>>
>>
>> (This looks strange to me.)
>>
>>
>> on i386 or x86_64:
>>
>> # CONFIG_ACPI is not set
>>
>> ../drivers/idle/intel_idle.c: In function ‘intel_idle_init_cstates_icpu’:
>> ../drivers/idle/intel_idle.c:1510:7: error: implicit declaration of function ‘intel_idle_state_needs_timer_stop’; did you mean ‘intel_idle_init_cstates_icpu’? [-Werror=implicit-function-declaration]
>> if (intel_idle_state_needs_timer_stop(&drv->states[drv->state_count]))
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> intel_idle_state_needs_timer_stop() is only defined when
> CONFIG_ACPI_PROCESSOR_CSTATE is set, but is used once where that is not
> necessarily set. I assume CONFIG_ACPI_PROCESSOR_CSTATE is not set in
> your config?
Yes, you are correct (not set).
> Caused by commit
>
> 6e1d2bc675bd ("intel_idle: Fix intel_idle() vs tracing")
>
> from the tip tree.
--
~Randy
next prev parent reply other threads:[~2020-11-27 21:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 9:04 linux-next: Tree for Nov 27 Stephen Rothwell
2020-11-27 15:57 ` linux-next: Tree for Nov 27 (drivers/idle/intel_idle.c) Randy Dunlap
2020-11-27 21:36 ` Stephen Rothwell
2020-11-27 21:38 ` Randy Dunlap [this message]
2020-11-30 11:54 ` Peter Zijlstra
2020-11-30 16:44 ` Randy Dunlap
2020-12-03 9:07 ` [tip: locking/urgent] intel_idle: Build fix tip-bot2 for Peter Zijlstra
2020-11-27 18:43 ` linux-next: Tree for Nov 27 (parisc: signal flags) Randy Dunlap
2020-11-27 19:12 ` Randy Dunlap
2020-11-27 21:44 ` Stephen Rothwell
2020-11-30 14:44 ` Eric W. Biederman
2020-11-30 17:30 ` [PATCH] signal/parics: Remove parsic specific definition of __ARCH_UAPI_SA_FLAGS Eric W. Biederman
2020-11-30 19:15 ` Randy Dunlap
2020-11-30 19:46 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9a42bb5-7a5d-cc19-2866-0cee1b8dd9bd@infradead.org \
--to=rdunlap@infradead.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.