All of lore.kernel.org
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <fmartine@redhat.com>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	The development of GNU GRUB <grub-devel@gnu.org>
Cc: Daniel Kiper <daniel.kiper@oracle.com>, Peter Jones <pjones@redhat.com>
Subject: Re: GRUB error: unknown filesystem on ia64
Date: Wed, 21 Apr 2021 19:54:32 +0200	[thread overview]
Message-ID: <da72e60a-8333-46a4-3626-59886760b7b0@redhat.com> (raw)
In-Reply-To: <3bfc2c36-c57f-f31b-0279-ca8aa3515e41@redhat.com>

On 4/19/21 7:56 PM, Javier Martinez Canillas wrote:

[snip]

>>
>> Could you send the patch to the mailing list separately with git send-email
>> or so that it doesn't get overlooked in the longer discussion we had?
>>
> 
> Yes, I was waiting for someone else more familiar with the COFF/PE binary
> format to chime in. But I'll post it as a proper patch in a couple of days
> if no one complains.
>  

Daniel pointed me out that my patch was wrong. Instead proper padding has to
be added by grub-mkimage for the sections in the actual PE32+ binary file.

That indeed makes more sense to me and I'll post a different RFC patch now.

Best regards,
Javier



  reply	other threads:[~2021-04-21 17:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-17 18:22 GRUB error: unknown filesystem on ia64 John Paul Adrian Glaubitz
2021-03-26 18:01 ` Daniel Kiper
2021-03-26 18:28   ` John Paul Adrian Glaubitz
2021-03-26 18:43     ` Daniel Kiper
2021-04-08 16:45       ` John Paul Adrian Glaubitz
2021-04-08 17:10         ` Javier Martinez Canillas
2021-04-08 17:30           ` John Paul Adrian Glaubitz
2021-04-10  9:40             ` John Paul Adrian Glaubitz
2021-04-12  6:21               ` Javier Martinez Canillas
2021-04-12  6:57                 ` John Paul Adrian Glaubitz
2021-04-16 15:21                   ` Javier Martinez Canillas
2021-04-16 16:43                     ` John Paul Adrian Glaubitz
2021-04-16 16:55                       ` John Paul Adrian Glaubitz
2021-04-16 20:14                         ` Javier Martinez Canillas
2021-04-16 20:32                           ` John Paul Adrian Glaubitz
2021-04-16 21:32                             ` Javier Martinez Canillas
2021-04-19 15:33                               ` John Paul Adrian Glaubitz
2021-04-19 17:56                                 ` Javier Martinez Canillas
2021-04-21 17:54                                   ` Javier Martinez Canillas [this message]
2021-04-16 15:21                   ` Javier Martinez Canillas
2021-06-16 14:22 Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da72e60a-8333-46a4-3626-59886760b7b0@redhat.com \
    --to=fmartine@redhat.com \
    --cc=daniel.kiper@oracle.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=grub-devel@gnu.org \
    --cc=pjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.