From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77A99C433EF for ; Thu, 9 Sep 2021 09:21:33 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC269610FF for ; Thu, 9 Sep 2021 09:21:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CC269610FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8E3AB83157; Thu, 9 Sep 2021 11:21:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="FOuOzQrJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id ADBE7831BA; Thu, 9 Sep 2021 11:21:28 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 73DB683131 for ; Thu, 9 Sep 2021 11:21:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1631179282; bh=chavahiHE/OoSGdgE677JlwQp4iL4xCLM5NVJxBtq0A=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=FOuOzQrJO4QRZMquQedEKGbI5uFpEuX4Yv3z9Uhiu/GH3+CNBkwcio/4D525959KU QdGypl3aMzC+imOSFd/3NsQX62vVWdkGkC/N9YvCjKYtHWJY+UtAFdH2fTDV0hE/vh 3PJSZz09TIZDv8u1GDMoc2MV471apWCuM1j+M3L8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.55] ([88.152.144.157]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MvbBu-1nGVKG0Wso-00saDP; Thu, 09 Sep 2021 11:21:22 +0200 Subject: Re: [PATCH 11/35] RFC: efi: Drop code that doesn't work with driver model To: Simon Glass Cc: U-Boot Mailing List , Ilias Apalodimas , Bin Meng , Tom Rini , Christian Melki , Alexander Graf References: <20210908133405.696481-1-sjg@chromium.org> <20210908073355.11.Id572ddf5eb457096b95d30ae2d8675f539367fe8@changeid> From: Heinrich Schuchardt Message-ID: Date: Thu, 9 Sep 2021 11:21:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:9+EKMLVyYGVz08XdGEKx6ohjU2GGSrRE9Tfvuwrk0hzAeI4peEC fb/bnt8cicmiNpyQFv7sGySn8+Jn02X5tbOSw3wDWIgV68dE0PR76ZNRLH6n1HNCvGZ4skC bjTYU3AVPEhDamui1NH1f+uE8Buyn9U4n3N+dLv/h7vKZpGAF+Kmmm9efJ4GK4d7HUjzV0q ydnZxXwPM4yptLm6zgGpQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:VFGghweG//4=:Yz2MTxc6/rtqP8x2zY1jVT sWp+fVr6RIE7A6XGC7/vDvyL4sF/MfsGulRpuWwtT04zKwFi2gQbcYLEFhpj7fnHkQ8nUPG6k RJ+yM4SmhjJDvd/S3OBvmenCWJpql5L21q0ckkrnZX1ZLXRgwBnNJAqhD932wUInd/1QlTY6K +3QutcgviXKO/w8uWKP1sTOIkZ7mqMp9SyOU32R4gpIi/6eM4zrc9uObgU9+jQG8tzuS0gNrO zWLDfjW07NqK3cmeA1VyiIgRXqxkiJQoYIgfID8AYnU77Itgyw7ZyDXppmj/FVfl3HjVBWAPo vEA9KZKHRf1HDPvsqN6JdzVR9na8+hrRQi5tLv5LDe7JEI3aAM92Q5brcLyFmiFtHERmNr72V +/CTylBFeEO51FMXE9P4R/TPlRK0FF5B1gqJ6RMwQF2jpu1p4vRTwNAT4zZcKrBZ++peuljVQ MD7ldHSy6q9YLa00kdKhkRi6POwpyyhdZ8Z36p0mQA4QvC3g9PwI3qllmbCa7nlPEpAfAQo5r IIZ6NmIDokOr0nSOKETCMTbQWDjLTivws9nxk7K1FMKiug2Q44WXhwFOPsyK7R7YDcBGCyCUW YGcgoymiBbZzgitXg8vCceqaW7K9icmiphFAPpN1JeIX51TUhOVRJmQEdjsxU2xDWcJJjMnM6 350Uo8MnmFGjCvxW5T20boKuZQ80ybQYBjanl432ByPMrPIFDuITy9Y4NoIiVwWDLWvI1URI2 agFGs+2lAk3XI5bAXaDJMLCEAxUdcgrO0HQsl58WOsifG4UN9YOvAfE3DGa//vdl5nIuHcg+2 IuGkTPaEWxUeZYqbxvy3hL0FMUTKBOOBDwGSaolgLfs519usFXVMe7Ak+U7zEyoUdcKN0uGfA wVVMO/uWib9WljNF9WCaHYDY6qxRmLekVTsJOurCCI5iCQt2D+9NjQrWVm5snWpsPVISmKCd1 V7olJqUhNYJgs+LYDzvdfHPtFLMgC5XxyOdMQWqRKgSMqck/ztZSvFDpPkDh/v0D1XQtneKDf Hsqfm41dOzQk9BcxAKGJywYVL5XbzZMXocsNRY7xO+kz4DOuvnpdEn3PKom1CiYVpaKhnRhva d8yZo+DCvMdLjQ= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 9/9/21 10:57 AM, Simon Glass wrote: > Hi Heinrich, > > On Wed, 8 Sept 2021 at 11:44, Heinrich Schuchardt w= rote: >> >> >> >> On 9/8/21 3:33 PM, Simon Glass wrote: >>> This code should never have been added as it builds a new feature on t= op >>> of legacy code. Drop it and add a dependency on BLK for this feature. >>> >>> Boards which want EFI_LOADER should migrate to driver model first. >>> >>> Signed-off-by: Simon Glass >> >> This patch is not related to the rest of the series and the code has a >> different maintainer. >> >> So, please, separate it from the series. > > Who is the maintainer? Until 623b3a57976 ("efi_selftest: provide an EFI selftest application") there was no official maintainer for lib/efi/ but you were the main contributor. But with that patch directory lib/efi/ was assigned to EFI PAYLOAD. I am happy if you would continue to care about U-Boot on EFI. > > I need this patch for this series to work. You can still review things > for other maintainers and in this case it is common for one maintainer > to pick up the series once the others are happy. The direction of this patch is completely correct. There are some things that will have to be changed, e.g we should not require CONFIG_DM_ETH=3Dy. I will work on reviewing this patch in detail. I already added CONFIG_BLK as a requirement for CONFIG_EFI_LOADER in a submitted patch. Removing legacy code from lib/efi_loader/efi_disk.c and lib/efi_loader/efi_device_path.c could be done before all U-Boot on EFI patches. Therefore I still think it makes sense to split the series in two: 1) Cleanup of the UEFI implementation 2) Rework of U-Boot on EFI I hope merging in this sequence of patch series makes send to you. Best regards Heinrich