All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: lironh@marvell.com
Cc: dev@dpdk.org, walan@marvell.com
Subject: Re: [PATCH v5] net/kni: calc mbuf&mtu according to given mb_pool
Date: Mon, 25 Mar 2019 21:11:04 +0000	[thread overview]
Message-ID: <dd5f9743-5dca-4ac6-c3bb-9fefad318858@intel.com> (raw)
In-Reply-To: <1553546882-22702-1-git-send-email-lironh@marvell.com>

On 3/25/2019 8:48 PM, lironh@marvell.com wrote:
> From: Liron Himi <lironh@marvell.com>
> 
> - mbuf_size and mtu are now being calculated according
> to the given mb-pool.
> 
> - max_mtu is now being set according to the given mtu
> 
> the above two changes provide the ability to work with jumbo frames
> 
> Signed-off-by: Liron Himi <lironh@marvell.com>
> ---

<...>

> @@ -187,6 +187,8 @@ The ``struct rte_kni_conf`` structure contains fields which allow the
>  user to specify the interface name, set the MTU size, set an explicit or
>  random MAC address and control the affinity of the kernel Rx thread(s)
>  (both single and multi-threaded modes).
> +by default kni sample gets mtu from matching device, and for kni pmd it
> +is derived from mbuf buffer length,

Hi Liron,

I can see you copy/pasted the comment to the doc, but the intention was not to
use it exactly. This is a public documentation, can you please correct the
wording, cases and punctuation, please make it something documentation quality.

  reply	other threads:[~2019-03-25 21:11 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-21  8:47 [PATCH] net/kni: calc mbuf&mtu according to given mb_pool lironh
2019-02-23 20:14 ` [PATCH v2] " lironh
2019-02-25 11:29   ` Liron Himi
2019-03-10 14:27     ` Liron Himi
2019-03-13 16:57       ` Ferruh Yigit
2019-03-14  6:37         ` Liron Himi
2019-03-14  9:28           ` Ferruh Yigit
2019-03-15 17:02             ` Liron Himi
2019-03-15 17:59               ` Ferruh Yigit
2019-03-17  9:43                 ` Liron Himi
2019-03-20 19:48                   ` Ferruh Yigit
2019-03-22 18:12   ` [PATCH v3] " lironh
2019-03-23 21:48     ` Rami Rosen
2019-03-24 10:05       ` [EXT] " Liron Himi
2019-03-24 12:15     ` [PATCH v4] " lironh
2019-03-25 15:44       ` Ferruh Yigit
2019-03-25 20:48       ` [PATCH v5] " lironh
2019-03-25 21:11         ` Ferruh Yigit [this message]
2019-03-26 18:40         ` [PATCH v6] " lironh
2019-03-26 17:59           ` Ferruh Yigit
2019-03-30  0:00             ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd5f9743-5dca-4ac6-c3bb-9fefad318858@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=lironh@marvell.com \
    --cc=walan@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.