All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guoqing Jiang <jgq516@gmail.com>
To: Artur Paszkiewicz <artur.paszkiewicz@intel.com>, song@kernel.org
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH V2 3/7] md: the latest try for improve io stats accounting
Date: Fri, 21 May 2021 15:43:23 +0800	[thread overview]
Message-ID: <de1ca79c-a099-33bf-930f-5a194071422b@gmail.com> (raw)
In-Reply-To: <83d02180-27ee-f8c2-7a41-f9b587324536@intel.com>



On 5/21/21 3:32 PM, Artur Paszkiewicz wrote:
>> @@ -2340,9 +2383,12 @@ int md_integrity_register(struct mddev *mddev)
>>                               bdev_get_integrity(reference->bdev));
>>   
>>        pr_debug("md: data integrity enabled on %s\n", mdname(mddev));
>> -     if (bioset_integrity_create(&mddev->bio_set, BIO_POOL_SIZE)) {
>> +     if (bioset_integrity_create(&mddev->bio_set, BIO_POOL_SIZE) ||
>> +         bioset_integrity_create(&mddev->md_io_bs, BIO_POOL_SIZE)) {
>>                pr_err("md: failed to create integrity pool for %s\n",
>>                       mdname(mddev));
>> +             bioset_exit(&mddev->bio_set);
>> +             bioset_exit(&mddev->md_io_bs);
>>                return -EINVAL;
> Are you sure bioset_exit() here is correct? This is always called from
> pers->run() and the cleanup in case of error is handled in md_run().

You are right! Maybe it deserves additional comment given it is
not obvious. Will drop it.

Thanks,
Guoqing

  reply	other threads:[~2021-05-21  7:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-21  0:55 [PATCH V2 0/7] md: io stats accounting Guoqing Jiang
2021-05-21  0:55 ` [PATCH V2 1/7] md: revert " Guoqing Jiang
2021-05-21  0:55 ` [PATCH V2 2/7] md: add accounting_bio for raid0 and raid5 Guoqing Jiang
2021-05-24  5:48   ` Song Liu
2021-05-24  8:45   ` Christoph Hellwig
2021-05-21  0:55 ` [PATCH V2 3/7] md: the latest try for improve io stats accounting Guoqing Jiang
2021-05-21  7:32   ` Artur Paszkiewicz
2021-05-21  7:43     ` Guoqing Jiang [this message]
2021-05-21  0:55 ` [PATCH V2 4/7] md/raid1: rename print_msg with r1bio_existed Guoqing Jiang
2021-05-21  0:55 ` [PATCH V2 5/7] md/raid1: enable io accounting Guoqing Jiang
2021-05-21  0:55 ` [PATCH V2 6/7] md/raid10: " Guoqing Jiang
2021-05-21  0:55 ` [PATCH V2 7/7] md: mark some personalities as deprecated Guoqing Jiang
2021-05-21  8:00 ` [UPDATE PATCH V2 3/7] md: the latest try for improve io stats accounting Guoqing Jiang
2021-05-24  5:49   ` Song Liu
2021-05-24  6:04 ` [PATCH V2 0/7] md: " Song Liu
2021-05-27 14:09   ` Paweł Wiejacha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de1ca79c-a099-33bf-930f-5a194071422b@gmail.com \
    --to=jgq516@gmail.com \
    --cc=artur.paszkiewicz@intel.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.