From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-serial <linux-serial@vger.kernel.org>,
"Eric Tremblay" <etremblay@distech-controls.com>,
"Lukas Wunner" <lukas.wunner@intel.com>,
kernel@pengutronix.de,
"Heiko Stuebner" <heiko.stuebner@theobroma-systems.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Giulio Benetti" <giulio.benetti@micronovasrl.com>
Subject: Re: [PATCH v3 1/3] serial: 8250: Handle UART without interrupt on TEMT using em485
Date: Tue, 19 Apr 2022 13:36:28 +0300 (EEST) [thread overview]
Message-ID: <de499011-16e2-1ef5-5cb6-ae6dcdc3f2de@linux.intel.com> (raw)
In-Reply-To: <Yl6KyWGmB5+KOAKU@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]
On Tue, 19 Apr 2022, Greg Kroah-Hartman wrote:
> On Tue, Apr 19, 2022 at 11:09:56AM +0300, Ilpo Järvinen wrote:
> > Hi Greg,
> >
> > This change now appears in your tty-next tree.
>
> What change? Please never top-post.
f6f586102add59d57bcc6eea06fdeaae11bb17a1 (serial: 8250: Handle UART
without interrupt on TEMT using em485).
> > As you seem to have missed
> > there is an obvious problem with it, I'm asking which direction I should
> > take to fix it.
>
> Send a fix! You don't need my permission to do so.
Yes, I know I don't need permission :-).
What I asked is whether I should provide:
a) a minimal fix to the issue in this particular change
or
b) send patches that replace this notemt approach with the another
that I believe is better than this one (*)
?
(*) In case you want to see the another approach before answering, it's
part of my RS485 patchset (patches 1-2) [1]. My solution doesn't need
the extra notemt timer and also allows drivers easy access to frame
timing information (rather than them storing it per purpose).
--
i.
[1] https://lore.kernel.org/linux-serial/20220411083321.9131-3-ilpo.jarvinen@linux.intel.com/T/#u
next prev parent reply other threads:[~2022-04-19 10:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 10:46 [PATCH v3 0/3] Handle UART without interrupt on TEMT using em485 Uwe Kleine-König
2022-03-30 10:46 ` [PATCH v3 1/3] serial: 8250: " Uwe Kleine-König
2022-03-30 11:20 ` Ilpo Järvinen
2022-03-30 14:21 ` Uwe Kleine-König
2022-03-31 8:03 ` Ilpo Järvinen
2022-04-19 8:09 ` Ilpo Järvinen
2022-04-19 10:11 ` Greg Kroah-Hartman
2022-04-19 10:36 ` Ilpo Järvinen [this message]
2022-04-19 10:41 ` Greg Kroah-Hartman
2022-03-30 10:46 ` [PATCH v3 2/3] serial: 8250: Add UART_CAP_NOTEMT on PORT_16550A_FSL64 Uwe Kleine-König
2022-03-30 10:46 ` [PATCH v3 3/3] serial: 8250: add compatible for fsl,16550-FIFO64 Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de499011-16e2-1ef5-5cb6-ae6dcdc3f2de@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=etremblay@distech-controls.com \
--cc=giulio.benetti@micronovasrl.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=jirislaby@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-serial@vger.kernel.org \
--cc=lukas.wunner@intel.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.