From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: Tom Rini <trini@konsulko.com>
Cc: u-boot <u-boot@lists.denx.de>
Subject: Re: [PATCH 3/4] socfpga64: Do not define CONFIG_SYS_MEM_RESERVE_SECURE to 0
Date: Thu, 3 Jun 2021 17:07:17 +0200 [thread overview]
Message-ID: <df8aefa9-9809-bbe0-a726-7541b3b629f5@prevas.dk> (raw)
In-Reply-To: <20210603133902.4192-3-trini@konsulko.com>
On 03/06/2021 15.39, Tom Rini wrote:
> Based on the comment in socfpga_soc64_common.h, the intention is for
> CONFIG_SYS_MEM_RESERVE_SECURE to be unused. However, in the code we do:
> ...
>
> and that will evaluate to true. This leads to unwanted code being
Some cleanup made lines beginning with # disappear? I can _strongly_
recommend setting commit.cleanup to scissors; I have lost count of the
number of times I've had a commit message mangled and become practically
useless because important lines got removed.
For example
<http://lists.busybox.net/pipermail/busybox/2018-September/086647.html>
became
<https://git.busybox.net/busybox/commit/?id=571e525a141a2de87b9c2ced485745e96418d921>
Rasmus
next prev parent reply other threads:[~2021-06-03 15:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 17:32 [PATCH] powerpc: fix regression in arch_initr_trap() Matt Merhar
2021-05-18 5:50 ` Stefan Roese
2021-05-18 7:04 ` Rasmus Villemoes
2021-05-18 9:19 ` [RFC PATCH 0/2] sizeof(gd_t) sanity checking Rasmus Villemoes
2021-05-18 9:19 ` [RFC PATCH 1/2] build_bug.h: add wrapper for _Static_assert Rasmus Villemoes
2021-05-19 15:34 ` Simon Glass
2021-07-01 21:54 ` Tom Rini
2021-05-18 9:19 ` [RFC PATCH 2/2] global-data.h: add build-time sanity check of sizeof(struct global_data) Rasmus Villemoes
2021-05-19 15:34 ` Simon Glass
2021-07-01 21:54 ` Tom Rini
2021-06-03 13:38 ` [PATCH 1/4] powerpc: Don't use relative include for config.h in global_data.h Tom Rini
2021-06-03 13:39 ` [PATCH 2/4] Revert "powerpc: fix regression in arch_initr_trap()" Tom Rini
2021-06-24 13:15 ` Tom Rini
2021-06-03 13:39 ` [PATCH 3/4] socfpga64: Do not define CONFIG_SYS_MEM_RESERVE_SECURE to 0 Tom Rini
2021-06-03 15:07 ` Rasmus Villemoes [this message]
2021-06-03 15:14 ` Tom Rini
2021-06-24 13:15 ` Tom Rini
2021-06-03 13:39 ` [PATCH 4/4] global_data: Ensure we have <config.h> when symbols are not in Kconfig yet Tom Rini
2021-06-24 13:15 ` Tom Rini
2021-06-05 19:18 ` [PATCH 1/4] powerpc: Don't use relative include for config.h in global_data.h Matt Merhar
2021-06-24 13:15 ` Tom Rini
2021-05-27 11:42 ` [PATCH] powerpc: fix regression in arch_initr_trap() Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df8aefa9-9809-bbe0-a726-7541b3b629f5@prevas.dk \
--to=rasmus.villemoes@prevas.dk \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.