From: Julien Grall <julien@xen.org>
To: Penny Zheng <penny.zheng@arm.com>,
xen-devel@lists.xenproject.org, sstabellini@kernel.org
Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com, nd@arm.com
Subject: Re: [PATCH 01/10] xen/arm: introduce domain on Static Allocation
Date: Tue, 18 May 2021 09:58:21 +0100 [thread overview]
Message-ID: <e1b90f06-92d2-11da-c556-4081907124b8@xen.org> (raw)
In-Reply-To: <20210518052113.725808-2-penny.zheng@arm.com>
Hi Penny,
On 18/05/2021 06:21, Penny Zheng wrote:
> Static Allocation refers to system or sub-system(domains) for which memory
> areas are pre-defined by configuration using physical address ranges.
> Those pre-defined memory, -- Static Momery, as parts of RAM reserved in the
s/Momery/Memory/
> beginning, shall never go to heap allocator or boot allocator for any use.
>
> Domains on Static Allocation is supported through device tree property
> `xen,static-mem` specifying reserved RAM banks as this domain's guest RAM.
> By default, they shall be mapped to the fixed guest RAM address
> `GUEST_RAM0_BASE`, `GUEST_RAM1_BASE`.
>
> This patch introduces this new `xen,static-mem` property to define static
> memory nodes in device tree file.
> This patch also documents and parses this new attribute at boot time and
> stores related info in static_mem for later initialization.
>
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> ---
> docs/misc/arm/device-tree/booting.txt | 33 +++++++++++++++++
> xen/arch/arm/bootfdt.c | 52 +++++++++++++++++++++++++++
> xen/include/asm-arm/setup.h | 2 ++
> 3 files changed, 87 insertions(+)
>
> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
> index 5243bc7fd3..d209149d71 100644
> --- a/docs/misc/arm/device-tree/booting.txt
> +++ b/docs/misc/arm/device-tree/booting.txt
> @@ -268,3 +268,36 @@ The DTB fragment is loaded at 0xc000000 in the example above. It should
> follow the convention explained in docs/misc/arm/passthrough.txt. The
> DTB fragment will be added to the guest device tree, so that the guest
> kernel will be able to discover the device.
> +
> +
> +Static Allocation
> +=============
> +
> +Static Allocation refers to system or sub-system(domains) for which memory
> +areas are pre-defined by configuration using physical address ranges.
> +Those pre-defined memory, -- Static Momery, as parts of RAM reserved in the
s/Momery/Memory/
> +beginning, shall never go to heap allocator or boot allocator for any use.
> +
> +Domains on Static Allocation is supported through device tree property
> +`xen,static-mem` specifying reserved RAM banks as this domain's guest RAM.
I would suggest to use "physical RAM" when you refer to the host memory.
> +By default, they shall be mapped to the fixed guest RAM address
> +`GUEST_RAM0_BASE`, `GUEST_RAM1_BASE`.
There are a few bits that needs to clarified or part of the description:
1) "By default" suggests there is an alternative possibility.
However, I don't see any.
2) Will the first region of xen,static-mem be mapped to
GUEST_RAM0_BASE and the second to GUEST_RAM1_BASE? What if a third
region is specificed?
3) We don't guarantee the base address and the size of the banks.
Wouldn't it be better to let the admin select the region he/she wants?
4) How do you determine the number of cells for the address and the size?
> +Static Allocation is only supported on AArch64 for now.
The code doesn't seem to be AArch64 specific. So why can't this be used
for 32-bit Arm?
> +
> +The dtb property should look like as follows:
> +
> + chosen {
> + domU1 {
> + compatible = "xen,domain";
> + #address-cells = <0x2>;
> + #size-cells = <0x2>;
> + cpus = <2>;
> + xen,static-mem = <0x0 0x30000000 0x0 0x20000000>;
> +
> + ...
> + };
> + };
> +
> +DOMU1 on Static Allocation has reserved RAM bank at 0x30000000 of 512MB size
Do you mean "DomU1 will have a static memory of 512MB reserved from the
physical address..."?
> +as guest RAM.
> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
> index dcff512648..e9f14e6a44 100644
> --- a/xen/arch/arm/bootfdt.c
> +++ b/xen/arch/arm/bootfdt.c
> @@ -327,6 +327,55 @@ static void __init process_chosen_node(const void *fdt, int node,
> add_boot_module(BOOTMOD_RAMDISK, start, end-start, false);
> }
>
> +static int __init process_static_memory(const void *fdt, int node,
> + const char *name,
> + u32 address_cells, u32 size_cells,
> + void *data)
> +{
> + int i;
> + int banks;
> + const __be32 *cell;
> + paddr_t start, size;
> + u32 reg_cells = address_cells + size_cells;
> + struct meminfo *mem = data;
> + const struct fdt_property *prop;
> +
> + if ( address_cells < 1 || size_cells < 1 )
> + {
> + printk("fdt: invalid #address-cells or #size-cells for static memory");
> + return -EINVAL;
> + }
> +
> + /*
> + * Check if static memory property belongs to a specific domain, that is,
> + * its node `domUx` has compatible string "xen,domain".
> + */
> + if ( fdt_node_check_compatible(fdt, node, "xen,domain") != 0 )
> + printk("xen,static-mem property can only locate under /domUx node.\n");
> +
> + prop = fdt_get_property(fdt, node, name, NULL);
> + if ( !prop )
> + return -ENOENT;
> +
> + cell = (const __be32 *)prop->data;
> + banks = fdt32_to_cpu(prop->len) / (reg_cells * sizeof (u32));
> +
> + for ( i = 0; i < banks && mem->nr_banks < NR_MEM_BANKS; i++ )
> + {
> + device_tree_get_reg(&cell, address_cells, size_cells, &start, &size);
> + /* Some DT may describe empty bank, ignore them */
> + if ( !size )
> + continue;
> + mem->bank[mem->nr_banks].start = start;
> + mem->bank[mem->nr_banks].size = size;
> + mem->nr_banks++;
> + }
> +
> + if ( i < banks )
> + return -ENOSPC;
> + return 0;
> +}
> +
> static int __init early_scan_node(const void *fdt,
> int node, const char *name, int depth,
> u32 address_cells, u32 size_cells,
> @@ -345,6 +394,9 @@ static int __init early_scan_node(const void *fdt,
> process_multiboot_node(fdt, node, name, address_cells, size_cells);
> else if ( depth == 1 && device_tree_node_matches(fdt, node, "chosen") )
> process_chosen_node(fdt, node, name, address_cells, size_cells);
> + else if ( depth == 2 && fdt_get_property(fdt, node, "xen,static-mem", NULL) )
> + process_static_memory(fdt, node, "xen,static-mem", address_cells,
> + size_cells, &bootinfo.static_mem);
I am a bit concerned to add yet another method to parse the DT and all
the extra code it will add like in patch #2.
From the host PoV, they are memory reserved for a specific purpose.
Would it be possible to consider the reserve-memory binding for that
purpose? This will happen outside of chosen, but we could use a phandle
to refer the region.
>
> if ( rc < 0 )
> printk("fdt: node `%s': parsing failed\n", name);
> diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h
> index 5283244015..5e9f296760 100644
> --- a/xen/include/asm-arm/setup.h
> +++ b/xen/include/asm-arm/setup.h
> @@ -74,6 +74,8 @@ struct bootinfo {
> #ifdef CONFIG_ACPI
> struct meminfo acpi;
> #endif
> + /* Static Memory */
> + struct meminfo static_mem;
> };
>
> extern struct bootinfo bootinfo;
>
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2021-05-18 8:58 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 5:21 [PATCH 00/10] Domain on Static Allocation Penny Zheng
2021-05-18 5:21 ` [PATCH 01/10] xen/arm: introduce domain " Penny Zheng
2021-05-18 8:58 ` Julien Grall [this message]
2021-05-19 2:22 ` Penny Zheng
2021-05-19 18:27 ` Julien Grall
2021-05-20 6:07 ` Penny Zheng
2021-05-20 8:50 ` Julien Grall
2021-06-02 10:09 ` Penny Zheng
2021-06-03 9:09 ` Julien Grall
2021-06-03 21:32 ` Stefano Stabellini
2021-06-03 22:07 ` Julien Grall
2021-06-03 23:55 ` Stefano Stabellini
2021-06-04 4:00 ` Penny Zheng
2021-06-05 2:00 ` Stefano Stabellini
2021-06-07 18:09 ` Julien Grall
2021-06-09 9:56 ` Bertrand Marquis
2021-06-09 10:47 ` Julien Grall
2021-06-15 6:08 ` Penny Zheng
2021-06-17 11:22 ` Julien Grall
2021-05-18 5:21 ` [PATCH 02/10] xen/arm: handle static memory in dt_unreserved_regions Penny Zheng
2021-05-18 9:04 ` Julien Grall
2021-05-18 5:21 ` [PATCH 03/10] xen/arm: introduce PGC_reserved Penny Zheng
2021-05-18 9:45 ` Julien Grall
2021-05-19 3:16 ` Penny Zheng
2021-05-19 9:49 ` Jan Beulich
2021-05-19 19:49 ` Julien Grall
2021-05-20 7:05 ` Jan Beulich
2021-05-19 19:46 ` Julien Grall
2021-05-20 6:19 ` Penny Zheng
2021-05-20 8:40 ` Penny Zheng
2021-05-20 8:59 ` Julien Grall
2021-05-20 9:27 ` Jan Beulich
2021-05-20 9:45 ` Julien Grall
2021-05-18 5:21 ` [PATCH 04/10] xen/arm: static memory initialization Penny Zheng
2021-05-18 7:15 ` Jan Beulich
2021-05-18 9:51 ` Penny Zheng
2021-05-18 10:43 ` Jan Beulich
2021-05-20 9:04 ` Penny Zheng
2021-05-20 9:32 ` Jan Beulich
2021-05-18 10:00 ` Julien Grall
2021-05-18 10:01 ` Julien Grall
2021-05-19 5:02 ` Penny Zheng
2021-05-18 5:21 ` [PATCH 05/10] xen/arm: introduce alloc_staticmem_pages Penny Zheng
2021-05-18 7:24 ` Jan Beulich
2021-05-18 9:30 ` Penny Zheng
2021-05-18 10:09 ` Julien Grall
2021-05-18 10:15 ` Julien Grall
2021-05-19 5:23 ` Penny Zheng
2021-05-24 10:10 ` Penny Zheng
2021-05-24 10:24 ` Julien Grall
2021-05-18 5:21 ` [PATCH 06/10] xen: replace order with nr_pfns in assign_pages for better compatibility Penny Zheng
2021-05-18 7:27 ` Jan Beulich
2021-05-18 9:11 ` Penny Zheng
2021-05-18 10:20 ` Julien Grall
2021-05-19 5:35 ` Penny Zheng
2021-05-18 5:21 ` [PATCH 07/10] xen/arm: intruduce alloc_domstatic_pages Penny Zheng
2021-05-18 7:34 ` Jan Beulich
2021-05-18 8:57 ` Penny Zheng
2021-05-18 11:23 ` Jan Beulich
2021-05-21 6:41 ` Penny Zheng
2021-05-21 7:09 ` Jan Beulich
2021-06-03 2:44 ` Penny Zheng
2021-05-18 12:13 ` Julien Grall
2021-05-19 7:52 ` Penny Zheng
2021-05-19 20:01 ` Julien Grall
2021-05-18 10:30 ` Julien Grall
2021-05-19 6:03 ` Penny Zheng
2021-05-18 5:21 ` [PATCH 08/10] xen/arm: introduce reserved_page_list Penny Zheng
2021-05-18 7:39 ` Jan Beulich
2021-05-18 8:38 ` Penny Zheng
2021-05-18 11:24 ` Jan Beulich
2021-05-19 6:46 ` Penny Zheng
2021-05-18 11:02 ` Julien Grall
2021-05-19 6:43 ` Penny Zheng
2021-05-18 5:21 ` [PATCH 09/10] xen/arm: parse `xen,static-mem` info during domain construction Penny Zheng
2021-05-18 12:09 ` Julien Grall
2021-05-19 7:58 ` Penny Zheng
2021-05-18 5:21 ` [PATCH 10/10] xen/arm: introduce allocate_static_memory Penny Zheng
2021-05-18 12:05 ` Julien Grall
2021-05-19 7:27 ` Penny Zheng
2021-05-19 20:10 ` Julien Grall
2021-05-20 6:29 ` Penny Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1b90f06-92d2-11da-c556-4081907124b8@xen.org \
--to=julien@xen.org \
--cc=Bertrand.Marquis@arm.com \
--cc=Wei.Chen@arm.com \
--cc=nd@arm.com \
--cc=penny.zheng@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.