From: Li Tuo <islituo@gmail.com>
To: sre@kernel.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
baijiaju1990@gmail.com
Subject: [BUG] power: supply: 88pm860x_battery: possible uninitialized-variable access in measure_vbatt()
Date: Wed, 28 Jul 2021 18:24:12 +0800 [thread overview]
Message-ID: <e2080eb9-bbe2-5077-761d-b5594edb6006@gmail.com> (raw)
Hello,
Our static analysis tool finds a possible uninitialized-variable access
in the 88pm860x_battery driver in Linux 5.14.0-rc3:
In calc_soc():
369: int ocv;
376: switch (state) {
380: case OCV_MODE_SLEEP:
381: ret = measure_vbatt(info, OCV_MODE_SLEEP, &ocv);
In measure_vbatt(struct pm860x_battery_info *info, int state, int *data)
176: switch (state) {
184: case OCV_MODE_SLEEP:
201: *data = ((*data & 0xff) * 27 * 25) >> 9;
If the variable state is OCV_MODE_SLEEP, the function measure_vbatt() is
called with the argument &ocv,
and the corresponding parameter is data. Thus *data is uninitialized but
it is used at line 201.
I am not quite sure whether this possible uninitialized-variable access
is real and how to fix it if it is real.
Any feedback would be appreciated, thanks!
Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Best wishes,
Tuo Li
next reply other threads:[~2021-07-28 10:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 10:24 Li Tuo [this message]
2021-08-05 17:49 ` [BUG] power: supply: 88pm860x_battery: possible uninitialized-variable access in measure_vbatt() Sebastian Reichel
2021-08-06 3:29 ` Tuo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2080eb9-bbe2-5077-761d-b5594edb6006@gmail.com \
--to=islituo@gmail.com \
--cc=baijiaju1990@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.