From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752730AbdH2LMo (ORCPT ); Tue, 29 Aug 2017 07:12:44 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:17007 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751805AbdH2LMk (ORCPT ); Tue, 29 Aug 2017 07:12:40 -0400 X-AuditID: b6c32a49-f79a26d000001fba-2a-59a54c267026 Subject: Re: [PATCH] scsi: ufs: Make use of UFS_BIT macro wherever possible To: Bart Van Assche , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: "martin.petersen@oracle.com" , Arnd Bergmann , "vinholikatti@gmail.com" From: Alim Akhtar Message-ID: Date: Tue, 29 Aug 2017 16:35:13 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1503935147.2841.25.camel@wdc.com> Content-Language: en-US Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBKsWRmVeSWpSXmKPExsWy7bCmlq6az9JIgyc3ZS3+TjrGbnHpzxdG i8u75rBZdF/fwWax/Pg/JosdC6sc2Dx+/5rE6LFz1l12j49Pb7F4fN4k59F+oJspgDWKyyYl NSezLLVI3y6BK+P61TnMBVc5K7ZsusPSwHiUvYuRk0NCwETi9IJmNghbTOLCvfVgtpDAbkaJ pZtdIexPjBK7P7F2MXIB2d8YJc6//wnX/LtnHTNEYi+jxJ3zf9ghnLeMEv9+zWcGqRIW8JbY 1TUbrEpEYBWjxP99C8FmMQtMZJTY0zkRbBabgLbE3elbmEBsXgE7iUc3FjCC2CwCqhKr7pxh AbFFBSIktn2fwQZRIyhxcuYTsDingL7E5JUXwOqZBcQlbj2ZzwRhy0tsfzsHbLOEwG02ifPP WlkgDneR2HBnKdTXwhKvjm+BekhK4mV/G5RdLtF+9R9UcwejxKlJ56Ca7SUOXJkDZHMAbdCU WL9LHyJsK3Hx3nGoxXwSvb+fMEHEVSWa310FK5cQ4JXoaBOCCHtITG6YyzKBUWkWkndmIXlh FpIXZiEsW8DIsopRMrWgODc9tdi0wDAvtVyvODG3uDQvXS85P3cTIzj9aHnuYJx1zucQowAH oxIPL4Pdkkgh1sSy4srcQ4wSHMxKIrxnvZZGCvGmJFZWpRblxxeV5qQWH2KU5mBREuc9trM0 UkggPbEkNTs1tSC1CCbLxMEp1cAYvuj0hMyu5sTYCaWzq2XKHa7MaL0V7rVzjVFsW9s2tQ1V U5WSolgMPhsIHmuIP1e1/WVLgpTDVlExIbXuth97H+aHTDXhKD0udJzz/PFlsx1rz72uk88s mNp96tbqIk5BWQOjjBye9M1q0wUWsxkfubcr4tAj3f9T3ie8rBc5XuMX6KCe90qJpTgj0VCL uag4EQDzXQQkOwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpkkeLIzCtJLcpLzFFi42LZdlhJTlfVZ2mkwZQ2HYu/k46xW1z684XR 4vKuOWwW3dd3sFksP/6PyWLHwioHNo/fvyYxeuycdZfd4+PTWywenzfJebQf6GYKYI3isklJ zcksSy3St0vgyrh+dQ5zwVXOii2b7rA0MB5l72Lk5JAQMJH43bOOuYuRi0NIYDejxP4J99kg EtIS1zdOgCoSllj57zk7RNFrRolDf14wgiSEBbwldnXNBusWEVjFKNHbfZARxGEWmMwocfjo VhaIlgOMEls/TGACaWET0Ja4O30LmM0rYCfx6MYCsFEsAqoSq+6cYQGxRQUiJPreXmaHqBGU ODnzCVicU0BfYvLKC2D1zAJmEvM2P2SGsMUlbj2ZzwRhy0tsfzuHeQKj0Cwk7bOQtMxC0jIL ScsCRpZVjJKpBcW56bnFhgWGeanlesWJucWleel6yfm5mxjBEaOluYPx8pL4Q4wCHIxKPLwM dksihVgTy4orcw8xSnAwK4nwunovjRTiTUmsrEotyo8vKs1JLT7EKM3BoiTOm9Y7I1JIID2x JDU7NbUgtQgmy8TBKdXAqCzJbBHVnH7oe/oqiQzFTS9m3lsqztfEUJxw5vkMr6pOX2O2Yr7P 10+1sTlN838SJ3duccjEIF3GCq89a2JPhZ6rl5/S2ZtstOCM0sHb6x9OOL5tt4zP/g7PTxMf HrBq2d7+sSjvfb/8opurRRc+evXpgKh7peC/bvkts6MqP3eb6q0If1Xor8RSnJFoqMVcVJwI AD+113+UAgAA X-CMS-MailID: 20170829111237epcas5p4214da2afbe430bbb22e35bcbf80cbf44 X-Msg-Generator: CA X-Sender-IP: 182.195.40.13 X-Local-Sender: =?UTF-8?B?7JWM66a8G1NTSVItRkRTIFNXG+yCvOyEseyghOyekBsuL1Nl?= =?UTF-8?B?bmlvciBDaGllZiBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QUxJTSBBS0hUQVIbU1NJUi1GRFMgU1cbU2Ftc3VuZyBFbGVj?= =?UTF-8?B?dHJvbmljcxsuL1NlbmlvciBDaGllZiBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElEMDdJRDAxMDk5Nw==?= Content-Type: text/plain; charset="utf-8" X-MTR: 20170829111237epcas5p4214da2afbe430bbb22e35bcbf80cbf44 CMS-TYPE: 105P X-CMS-RootMailID: 20170828122625epcas2p33e3e912339c1e29051ad8e28251ea91b X-RootMTR: 20170828122625epcas2p33e3e912339c1e29051ad8e28251ea91b References: <1503922783-14317-1-git-send-email-alim.akhtar@samsung.com> <1503935147.2841.25.camel@wdc.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bart, Thanks for your review. On 08/28/2017 09:15 PM, Bart Van Assche wrote: > On Mon, 2017-08-28 at 17:49 +0530, Alim Akhtar wrote: >> This entire file uses UFS_BIT macro for bits definition, expect for few >> places. This patch convert those defines to use UFS_BIT macro to be aligned >> with reset of the file. > > This is the definition of the UFS_BIT() macro I found in > drivers/scsi/ufs/ufshci.h: > > #define UFS_BIT(x) (1L << (x)) > > Using this macro makes code longer instead of shorter and does not improve > code readability. Is this macro really useful? Wouldn't it be better to > remove the UFS_BIT() macro instead of introducing more uses of it? > Well, the intension of this patch is to make use of already existing UFS_BIT() macro. I am not aware of the history why this macro was created at first place. Well, it does improve code readability, for me at least, no need for one to do a calculation to see which bit it is, as we pass _bit_ number to UFS_BIT. I am totally okay, if you or other reviewers suggests me to change UFS_BIT to actual bit position, something like the original case, which this patch is trying to change. > Thanks, > > Bart. > Thanks! Alim