From: Arun KS <arunks@codeaurora.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: akpm@linux-foundation.org, keescook@chromium.org,
khlebnikov@yandex-team.ru, minchan@kernel.org, vbabka@suse.cz,
osalvador@suse.de, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, getarunks@gmail.com
Subject: Re: [PATCH v3 4/4] mm: Remove managed_page_count spinlock
Date: Thu, 08 Nov 2018 16:01:10 +0530 [thread overview]
Message-ID: <e3ca027726d9683a9fbf3694a96afd17@codeaurora.org> (raw)
In-Reply-To: <20181108101400.GU27423@dhcp22.suse.cz>
On 2018-11-08 15:44, Michal Hocko wrote:
> On Thu 08-11-18 15:33:06, Arun KS wrote:
>> On 2018-11-08 14:04, Michal Hocko wrote:
>> > On Thu 08-11-18 13:53:18, Arun KS wrote:
>> > > Now totalram_pages and managed_pages are atomic varibles. No need
>> > > of managed_page_count spinlock.
>> >
>> > As explained earlier. Please add a motivation here. Feel free to reuse
>> > wording from
>> > http://lkml.kernel.org/r/20181107103630.GF2453@dhcp22.suse.cz
>>
>> Sure. Will add in next spin.
>
> Andrew usually updates changelogs if you give him the full wording.
> I would wait few days before resubmitting, if that is needed at all.
mm: Remove managed_page_count spinlock
Now that totalram_pages and managed_pages are atomic varibles, no need
of managed_page_count spinlock. The lock had really a weak consistency
guarantee. It hasn't been used for anything but the update but no reader
actually cares about all the values being updated to be in sync.
Signed-off-by: Arun KS <arunks@codeaurora.org>
Reviewed-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Acked-by: Michal Hocko <mhocko@suse.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> 0day will throw a lot of random configs which can reveal some
> leftovers.
Yea. Fixed few of them during v3.
Regards,
Arun
next prev parent reply other threads:[~2018-11-08 10:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 8:23 [PATCH v3 0/4] mm: convert totalram_pages, totalhigh_pages and managed pages to atomic Arun KS
2018-11-08 8:23 ` [PATCH v3 1/4] mm: reference totalram_pages and managed_pages once per function Arun KS
2018-11-08 11:44 ` Vlastimil Babka
2018-11-09 11:33 ` kbuild test robot
2018-11-09 11:33 ` kbuild test robot
2018-11-08 8:23 ` [PATCH v3 2/4] mm: convert zone->managed_pages to atomic variable Arun KS
2018-11-08 8:32 ` Michal Hocko
2018-11-08 8:23 ` [PATCH v3 3/4] mm: convert totalram_pages and totalhigh_pages variables to atomic Arun KS
2018-11-08 8:23 ` [PATCH v3 4/4] mm: Remove managed_page_count spinlock Arun KS
2018-11-08 8:34 ` Michal Hocko
2018-11-08 10:03 ` Arun KS
2018-11-08 10:14 ` Michal Hocko
2018-11-08 10:31 ` Arun KS [this message]
2018-11-09 15:42 ` Arun KS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3ca027726d9683a9fbf3694a96afd17@codeaurora.org \
--to=arunks@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=getarunks@gmail.com \
--cc=keescook@chromium.org \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=osalvador@suse.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.