From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E18AC432BE for ; Thu, 19 Aug 2021 11:47:59 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CBD16109F for ; Thu, 19 Aug 2021 11:47:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9CBD16109F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EF5BE83222; Thu, 19 Aug 2021 13:47:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.b="c4D9x4Te"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 645358319C; Thu, 19 Aug 2021 13:47:49 +0200 (CEST) Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 48AAF83211 for ; Thu, 19 Aug 2021 13:47:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=prvs=2865fff45f=patrice.chotard@foss.st.com Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17JBaPvc014824; Thu, 19 Aug 2021 13:47:43 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=BPPpdxCgd71t/AnOWkDf7r3LSKfgQ9gMMvSaTqQMImU=; b=c4D9x4TefnbTm8+EQhLT/vCu8nOggzuHQaXGzGPTMiCyA4XvD0j5Z49rh4jcCblJQnWJ +/NDf8xCymUEcelYzkiOKUjfAijg/OOA6p7+SnrtPdXQ0DddsN5Z3+HQSreLLDYx9IEH MjlViQLDNa1OvaUsVPo3cN+/CfWkwlA7bjrzbeQUlVgvspqxVXK/JKwPKlOVkihJgtrJ jzJNP2W/0ovndc9Vfa+XsSHAqoCObY9w7q0ZLDQUl41Kqa7w6gFI9UKbMdLPVDI2RxaD +V6hadbIy7G/DsOqhJznRYpC61URQSdc5xWwyft+Pn0sSdQzpkj20LGUSU9bu29e0shE uA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 3ahe1su7s7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Aug 2021 13:47:43 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id E25AB10002A; Thu, 19 Aug 2021 13:47:42 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id D71AC22F7BC; Thu, 19 Aug 2021 13:47:42 +0200 (CEST) Received: from lmecxl0573.lme.st.com (10.75.127.51) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 19 Aug 2021 13:47:42 +0200 Subject: Re: [PATCH v1 6/7] i2c: stm32f7: add support for DNF i2c-digital-filter binding To: CC: Patrick DELAUNAY , U-Boot STM32 , Heiko Schocher References: <20210803100515.29383-1-patrice.chotard@foss.st.com> <20210803100515.29383-7-patrice.chotard@foss.st.com> From: Patrice CHOTARD Message-ID: Date: Thu, 19 Aug 2021 13:47:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210803100515.29383-7-patrice.chotard@foss.st.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-08-19_04:2021-08-17, 2021-08-19 signatures=0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean HI Patrick On 8/3/21 12:05 PM, Patrice Chotard wrote: > From: Patrick Delaunay > > Add the support for the i2c-digital-filter binding, allowing to enable > the digital filter via the device-tree and indicate its value in the DT > > Signed-off-by: Patrick Delaunay > Signed-off-by: Patrice Chotard > --- > > drivers/i2c/stm32f7_i2c.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/stm32f7_i2c.c b/drivers/i2c/stm32f7_i2c.c > index 7e6c65fadc..2b2dae67a3 100644 > --- a/drivers/i2c/stm32f7_i2c.c > +++ b/drivers/i2c/stm32f7_i2c.c > @@ -107,7 +107,6 @@ struct stm32_i2c_regs { > > #define STM32_I2C_MAX_LEN 0xff > > -#define STM32_I2C_DNF_DEFAULT 0 > #define STM32_I2C_DNF_MAX 15 > > #define STM32_I2C_ANALOG_FILTER_DELAY_MIN 50 /* ns */ > @@ -204,6 +203,7 @@ struct stm32_i2c_timings { > * @regmap_sreg: register address for setting Fast Mode Plus bits > * @regmap_creg: register address for clearing Fast Mode Plus bits > * @regmap_mask: mask for Fast Mode Plus bits > + * @dnf_dt: value of digital filter requested via dt > */ > struct stm32_i2c_priv { > struct stm32_i2c_regs *regs; > @@ -214,6 +214,7 @@ struct stm32_i2c_priv { > u32 regmap_sreg; > u32 regmap_creg; > u32 regmap_mask; > + u32 dnf_dt; > }; > > static const struct stm32_i2c_spec i2c_specs[] = { > @@ -684,6 +685,7 @@ static int stm32_i2c_compute_timing(struct stm32_i2c_priv *i2c_priv, > const struct stm32_i2c_spec *specs; > struct stm32_i2c_timings *v, *_v; > struct list_head solutions; > + u32 i2cclk = DIV_ROUND_CLOSEST(STM32_NSEC_PER_SEC, setup->clock_src); > int ret; > > specs = get_specs(setup->speed_freq); > @@ -701,6 +703,8 @@ static int stm32_i2c_compute_timing(struct stm32_i2c_priv *i2c_priv, > return -EINVAL; > } > > + /* Analog and Digital Filters */ > + setup->dnf = DIV_ROUND_CLOSEST(i2c_priv->dnf_dt, i2cclk); > if (setup->dnf > STM32_I2C_DNF_MAX) { > log_err("DNF out of bound %d/%d\n", > setup->dnf, STM32_I2C_DNF_MAX); > @@ -923,7 +927,10 @@ static int stm32_of_to_plat(struct udevice *dev) > fall_time = dev_read_u32_default(dev, "i2c-scl-falling-time-ns", > STM32_I2C_FALL_TIME_DEFAULT); > > - i2c_priv->setup.dnf = STM32_I2C_DNF_DEFAULT; > + i2c_priv->dnf_dt = dev_read_u32_default(dev, "i2c-digital-filter-width-ns", 0); > + if (!dev_read_bool(dev, "i2c-digital-filter")) > + i2c_priv->dnf_dt = 0; > + > i2c_priv->setup.analog_filter = dev_read_bool(dev, "i2c-analog-filter"); > > /* Optional */ > Reviewed-by: Patrice Chotard Thanks Patrice