From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E38F0C433E0 for ; Mon, 29 Mar 2021 17:02:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BAD1E61970 for ; Mon, 29 Mar 2021 17:02:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231134AbhC2RCF (ORCPT ); Mon, 29 Mar 2021 13:02:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbhC2RBv (ORCPT ); Mon, 29 Mar 2021 13:01:51 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E635C061574; Mon, 29 Mar 2021 10:01:51 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id gb6so6324883pjb.0; Mon, 29 Mar 2021 10:01:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3KaU2X8BYBo2iEYrCYnDX7Io7zwEGngt8bXiDSOA3dU=; b=Kg42A+C8lwb0lncwa2RQMG/aGsCwIFedHnSNQ5tAzBoKpV7+4z32DzKBLqagztyFcR 5foEL4IWF1C2q3jlXjdsh7nliv2yDPKhtPOIpnPICy4j8l0aMeZoXyAQyrTmUcL32PAB b3XxiYzpReNucgoVjwzRn+OFrqbtj07XYipNt6AhQ8uemiICKdx+rPfhBi2AfDs7HQ4J xWAdzSQlZGkbN7nHm5QkqXUCiO9A7gorZVuGXwdS8EyAeO9CrvEH8NBGLWktcPooXpeJ q4LxzdRWU9wkxHOF0Mhl0aJKJy2nDI6nVYe6jeAVrr5lgPsx+AOfGkRFnsCHsCSEmOHH Re0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3KaU2X8BYBo2iEYrCYnDX7Io7zwEGngt8bXiDSOA3dU=; b=Pw7docRGW/AJJl653krYWmO7Ldv5byPNrMVn4FY7Rk8kOaT7oGwPmJO9q+hZVhzcDh O7Y1NeylzqgELkM+N7+R1OK0TMWub61QrtIUWLOyiOJoTBITqerP2LNYua+JHf/+BhJw +aHyjG3lE4fIiF6Y+JCj4WhGoj4WxwlNd5TicknvmYvwALkp/MG7UjOp0Y+LsE5+hjF1 vNKQMBXPHi1kUQ66N36HWpq13euhqeBhjGvufpOT0FeUjRB5yxFQQeCmUQ5Tn1qn98gg 1c7CD5+yFyaErAmxeWF84WqSf7FSgeu5fOfYs9TgUtUs8Acf44fu3ua2sBn3SdnFfpfA z6Ig== X-Gm-Message-State: AOAM532HgDxETakxLXCrC/PvUc5XQ86cVe1BMwgPvEaEQFnDQPzpKOyM HOd0INU2snlEq/mAaJ0gsSJ+mVkOask= X-Google-Smtp-Source: ABdhPJzLqubBwMwApiffsPDmTZ/4mHx8yGrQUWgZKoYE3ro/5jmcfBk2I7198NgYttUDrK18m1+TqQ== X-Received: by 2002:a17:90a:bb81:: with SMTP id v1mr62162pjr.123.1617037310528; Mon, 29 Mar 2021 10:01:50 -0700 (PDT) Received: from [10.67.49.104] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id w3sm43671pjg.7.2021.03.29.10.01.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Mar 2021 10:01:50 -0700 (PDT) Subject: Re: [PATCH v5 2/2] PCI: brcmstb: Use reset/rearm instead of deassert/assert To: Lorenzo Pieralisi Cc: Jim Quinlan , Bjorn Helgaas , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com, Rob Herring , Bjorn Helgaas , Philipp Zabel , Jim Quinlan , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list References: <20210312204556.5387-1-jim2101024@gmail.com> <20210312204556.5387-3-jim2101024@gmail.com> <20210329161040.GB9677@lpieralisi> <71903454-c20c-31f7-aaee-0d05eb22db7f@gmail.com> <20210329165847.GA10454@lpieralisi> From: Florian Fainelli Message-ID: Date: Mon, 29 Mar 2021 10:01:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210329165847.GA10454@lpieralisi> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/29/21 9:58 AM, Lorenzo Pieralisi wrote: > On Mon, Mar 29, 2021 at 09:50:13AM -0700, Florian Fainelli wrote: >> On 3/29/21 9:10 AM, Lorenzo Pieralisi wrote: >>> On Fri, Mar 12, 2021 at 03:45:55PM -0500, Jim Quinlan wrote: >>>> The Broadcom STB PCIe RC uses a reset control "rescal" for certain chips. >>>> The "rescal" implements a "pulse reset" so using assert/deassert is wrong >>>> for this device. Instead, we use reset/rearm. We need to use rearm so >>>> that we can reset it after a suspend/resume cycle; w/o using "rearm", the >>>> "rescal" device will only ever fire once. >>>> >>>> Of course for suspend/resume to work we also need to put the reset/rearm >>>> calls in the suspend and resume routines. >>> >>> Actually - I am sorry but it looks like you will have to split the patch >>> in two since this is two logical changes. >> >> I do not believe this can be easily split, since there is currently a >> misused of the reset controller API and this patch fixes all call sites >> at once. It would not really make sense to fix probe/remove and then >> leave suspend/resume broken in the same manner. > > Right - I was reading the previous versions of the set, it makes sense > to keep it in one logical change. > > Do you want me to take it or you prefer an ACK so that it can go via > a different tree ? I would be comfortable with you taking this via the PCI driver trees, we would want an Ack from Jens that he is okay with taking the ahci_brcm.c change as well through your tree. Thank you! -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CB15C433DB for ; Mon, 29 Mar 2021 23:38:06 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 102F561996 for ; Mon, 29 Mar 2021 23:38:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 102F561996 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sxSjQ3bY46LD72mGr4t078jkkMgaanXJrgZBIpdZsaU=; b=d0hc+HB6eqbjJ4CGjubNiVHlN ygPJ+8vNn3ZORvgT4LinMX1gSVMzVafnLPlnLS0Kh8MLYhyuoqP4c+IcFA+n7mWhCMqgibeo4CQ3M a9rM20ufLPTFjLkiA/zyxO0XLjXBadwh9GpJAmp3YZcZUmthEnzqYROxdDPFuGb438AAvKMv5s9wU kDIJ2yUjjbSMu0kbipMzM3gQS4rhxq3jA0qRr6+TH4OP81o3dOLtIm/++SilIa+JkpweR1H/QsXX7 gnMB9wqo0k67uIcmxqMCFKABlDKEVGSb5SoD0JrlB6wb7SeAUsFArzNabvJ8EhfJMHug5XmZIJBWm I3tPghn2w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lR1PZ-001y9v-UC; Mon, 29 Mar 2021 23:35:10 +0000 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lQvGy-000pHY-3u; Mon, 29 Mar 2021 17:01:54 +0000 Received: by mail-pl1-x631.google.com with SMTP id h8so4691254plt.7; Mon, 29 Mar 2021 10:01:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3KaU2X8BYBo2iEYrCYnDX7Io7zwEGngt8bXiDSOA3dU=; b=Kg42A+C8lwb0lncwa2RQMG/aGsCwIFedHnSNQ5tAzBoKpV7+4z32DzKBLqagztyFcR 5foEL4IWF1C2q3jlXjdsh7nliv2yDPKhtPOIpnPICy4j8l0aMeZoXyAQyrTmUcL32PAB b3XxiYzpReNucgoVjwzRn+OFrqbtj07XYipNt6AhQ8uemiICKdx+rPfhBi2AfDs7HQ4J xWAdzSQlZGkbN7nHm5QkqXUCiO9A7gorZVuGXwdS8EyAeO9CrvEH8NBGLWktcPooXpeJ q4LxzdRWU9wkxHOF0Mhl0aJKJy2nDI6nVYe6jeAVrr5lgPsx+AOfGkRFnsCHsCSEmOHH Re0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3KaU2X8BYBo2iEYrCYnDX7Io7zwEGngt8bXiDSOA3dU=; b=KQ5dW3EhzG2SPg2KOEjblpV96JP/CcwUE50Eugn6uHNBKfwF/s7gJCvTT+JKy1hxNc XjH/oM2eTVZtHOrwfiP0mY/z3tBWSa1/N5aAnDginoFaruktPCxTZrMEhQr48c3soc/d 8Wy4GWEvsBLWSNYdNDaYVPIJ1Jriyf0gA6NaiWXBCRzUzRoncTdYhcIemXxbcfmuNpud dHPRgoJffBQWxfDO5gAisQO230xRa+00tKy/h1Ohv2xQY+IU5ZdI8eDcDn0gjH0Cg4tF +e7IGA1UULHRXj69CaVtjB1EMkSij2s7wezKwAQzgIIqb8p5aqaZtEmy0Zk89CwreLTt b7cQ== X-Gm-Message-State: AOAM531/1FslXHWUjEf3c+Tm7zI7NpTiRs1M28G2wgCVS+qqE1NYvivG zoe1Sz7nko+aMjd3+eBr97w= X-Google-Smtp-Source: ABdhPJzLqubBwMwApiffsPDmTZ/4mHx8yGrQUWgZKoYE3ro/5jmcfBk2I7198NgYttUDrK18m1+TqQ== X-Received: by 2002:a17:90a:bb81:: with SMTP id v1mr62162pjr.123.1617037310528; Mon, 29 Mar 2021 10:01:50 -0700 (PDT) Received: from [10.67.49.104] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id w3sm43671pjg.7.2021.03.29.10.01.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Mar 2021 10:01:50 -0700 (PDT) Subject: Re: [PATCH v5 2/2] PCI: brcmstb: Use reset/rearm instead of deassert/assert To: Lorenzo Pieralisi Cc: Jim Quinlan , Bjorn Helgaas , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com, Rob Herring , Bjorn Helgaas , Philipp Zabel , Jim Quinlan , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list References: <20210312204556.5387-1-jim2101024@gmail.com> <20210312204556.5387-3-jim2101024@gmail.com> <20210329161040.GB9677@lpieralisi> <71903454-c20c-31f7-aaee-0d05eb22db7f@gmail.com> <20210329165847.GA10454@lpieralisi> From: Florian Fainelli Message-ID: Date: Mon, 29 Mar 2021 10:01:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210329165847.GA10454@lpieralisi> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210329_180152_456147_5AFF0432 X-CRM114-Status: GOOD ( 20.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/29/21 9:58 AM, Lorenzo Pieralisi wrote: > On Mon, Mar 29, 2021 at 09:50:13AM -0700, Florian Fainelli wrote: >> On 3/29/21 9:10 AM, Lorenzo Pieralisi wrote: >>> On Fri, Mar 12, 2021 at 03:45:55PM -0500, Jim Quinlan wrote: >>>> The Broadcom STB PCIe RC uses a reset control "rescal" for certain chips. >>>> The "rescal" implements a "pulse reset" so using assert/deassert is wrong >>>> for this device. Instead, we use reset/rearm. We need to use rearm so >>>> that we can reset it after a suspend/resume cycle; w/o using "rearm", the >>>> "rescal" device will only ever fire once. >>>> >>>> Of course for suspend/resume to work we also need to put the reset/rearm >>>> calls in the suspend and resume routines. >>> >>> Actually - I am sorry but it looks like you will have to split the patch >>> in two since this is two logical changes. >> >> I do not believe this can be easily split, since there is currently a >> misused of the reset controller API and this patch fixes all call sites >> at once. It would not really make sense to fix probe/remove and then >> leave suspend/resume broken in the same manner. > > Right - I was reading the previous versions of the set, it makes sense > to keep it in one logical change. > > Do you want me to take it or you prefer an ACK so that it can go via > a different tree ? I would be comfortable with you taking this via the PCI driver trees, we would want an Ack from Jens that he is okay with taking the ahci_brcm.c change as well through your tree. Thank you! -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel